Bug 4159

Summary: Definition needed for "item-time" checkpoint policy (see email to issues list)
Product: jbatch Reporter: ScottKurz
Component: sourceAssignee: cvignola
Status: CLOSED FIXED    
Severity: minor CC: issues
Priority: P5    
Version: 1   
Target Milestone: ---   
Hardware: All   
OS: All   

Description ScottKurz 2012-09-28 14:37:35 UTC
Copying the email I sent to the 'issues' list:
(the earlier formatting might have been easier to read)


Not sure how you envisioned the JSL looking for the "item-time" checkpoint policy given that you said it is a "built-in custom" policy.

I could imagine it implemented as another built-in with either:

                               <!-- overload existing attr using CSV of (item, time)-->
		<chunk ... commit-interval="10,5" checkpoint-policy="item-time">

                        spec needs to say: 
                                - that there is NO defaulting of either item or time
                                - strike out the statement  "It must be valid XML integer. "   (by the way this statement was only true after substitution but I think the point was clear)

                               <!-- new attributes -->
		<chunk ... checkpoint-policy="item-time"item-size="10" time-interval="5">

                        spec needs to say: 
                                - maybe a bit more complicated statement of what <chunk> attribute combos are allowed (note the new attrs probably could be defaulted, )

Trying to read into your thoughts, I could imagine you were thinking something like:

2a.		<chunk ... checkpoint-policy="custom">
		<checkpoint-algorithm ref="item-time">
				<property name="item" value="10" />
				<property name="time" value="5" />

or even:

2b.		<chunk ... checkpoint-policy="custom">
				<property name="item" value="10" />   <!-- Could default -->
				<property name="time" value="5" />    <!-- Could default -->

2c.                         <chunk ... checkpoint-policy="custom">
		    <checkpoint-algorithm item-time="true">     ... use either attrs like in 1b. or child elements like in 2b.

I don't like 2a)  since it seems to pollute the batch artifact namespace...     

I guess 2b. or 2c. would work... we don't have a need to assign any other significance to "custom" policy minus a @ref...   The 2c. option makes it even
more clear we are omitting @ref in order to do item-time.

Comment 1 cvignola 2012-10-05 19:31:09 UTC
item-time will be removed from the spec.  I recommend we implement it in the RI/TCK as the way to test checkpoint-algorithm.  The way to define it is style "2a".
Comment 2 cvignola 2013-01-16 16:27:54 UTC
item-time checkpoint policy has been removed