Bug 4560

Summary: JobOperator#getRunningInstances is confusing.
Product: jbatch Reporter: mminella
Component: sourceAssignee: cvignola
Status: RESOLVED FIXED    
Severity: normal CC: issues
Priority: P5    
Version: 1   
Target Milestone: ---   
Hardware: All   
OS: All   
Whiteboard:

Description mminella 2013-01-18 16:05:05 UTC
In section 7.8.10 on page 98 the JobOperator defines a method JobOperator#getRunningInstances(String jobName).  I see two issues with this:

1. An instance doesn't run…an execution does so it doesn't make much sense to get running instances (The SB JobOperator has a getRunningExecutions).  
2. SB just returns the ids instead of the full objects.  I know there was a conversation about consistency on whether to use ids vs full objects on this interface but I don't remember where it ended up (and it isn't consistent on the interface so wanted to double check).
Comment 1 cvignola 2013-01-23 20:47:45 UTC
The id vs full object discussion concluded with the following principle:  executionId would be the only id passed on JobOperator methods - primarily on methods centered around start/restarting/stopping a job.  Objects would be passed in all other cases.  

getRunningExecutions morphed into getRunningInstances somewhere along the way. 

The signature should probably be:

List<JobExecutions> getRunningExecutions
Comment 2 cvignola 2013-03-01 18:00:24 UTC
Actual signature is:

	public List<Long> getRunningExecutions(String jobName)

Update in PFD v1.5