Bug 4634

Summary: support subclass of java.lang.Throwable in all ExceptionClassFilter elements
Product: jbatch Reporter: cf126330
Component: sourceAssignee: cvignola
Status: RESOLVED WORKSFORME    
Severity: normal CC: issues, waynexlund
Priority: P5    
Version: 1   
Target Milestone: ---   
Hardware: PC   
OS: Mac OS   
Whiteboard:

Description cf126330 2013-01-30 21:41:03 UTC
These elements include <skippable-exception-classes>, <retryable-exception-classes>, <no-rollback-exception-classes>.  Currently they take subclasses of exception.  I think we can broaden it to take all subclasses of Throwable to be flexible.

Some apps may need to recover from, or retry java.lang.Error, such as java.lang.AssertionError.
Comment 1 cvignola 2013-01-31 18:55:40 UTC
I don't think we should do this.  

As per http://docs.oracle.com/javase/6/docs/api/java/lang/Error.html

"An Error is a subclass of Throwable that indicates serious problems that a reasonable application should not try to catch."

And therefore should not try to skip or retry.
Comment 2 waynexlund 2013-01-31 19:01:14 UTC
I second the veto.