Bug 4744 - SPEC - time-limit needs a unit of measure
SPEC - time-limit needs a unit of measure
Product: jbatch
Classification: Unclassified
Component: source
All All
: P5 minor
: ---
Assigned To: cvignola
Depends on:
  Show dependency treegraph
Reported: 2013-03-08 20:47 UTC by mminella
Modified: 2013-03-20 03:07 UTC (History)
3 users (show)

See Also:


Note You need to log in before you can comment on or make changes to this bug.
Description mminella 2013-03-08 20:47:16 UTC
Within the chunk element, the time-limit needs to define the unit of time it's measuring.  I would recommend milliseconds to be consistent with the rest of the way Java measures time.
Comment 1 cvignola 2013-03-11 15:16:17 UTC
I agree it needs to be specified.  And I recognize the Java precedent of milliseconds.  But do you really believe conforming to precedent is the right thing here?  Batch times are usually seconds if not minutes.  E.g.

E.g. a 3 minute chunk limit is 180000.

Using milliseconds will make the JSL less readable IMO.   That would be fine if times less than a second where necessary.  Such small times are typical for OLTP but not batch. 

I think seconds as the unit of measure makes more sense.  Opinions?
Comment 2 cf126330 2013-03-11 16:30:06 UTC
I think Michael's comment implies we need to add a new attribute, like time-limit-unit, and these 2 together can accurately define the time limit.  We can default time-limit-unit to a common value such as minutes or seconds, while allowing use of other units like millis, nanos, or days.  For example, ejb 3.1 stateful-timeout uses this structure with minutes as default unit:

Comment 3 ScottKurz 2013-03-12 03:07:01 UTC
I don't think we should make a change given the lateness of the date.    There are other ways to achieve "quick checkpointing" (custom or item-based), and I think we should prioritize this low.
Comment 4 mminella 2013-03-14 18:13:10 UTC
At the least, we do need a unit of measure specified in the spec.
Comment 5 cvignola 2013-03-20 03:07:52 UTC
It will have to come in a future revision.  Anyone that needs to checkpoint more frequently than 1 second can do so with a checkpoint algorithm artifact.