Bugzilla – Bug 5655
ChunkTests for skipping writes don't go far enough
Last modified: 2015-09-03 14:24:51 UTC
ChunkTests#testChunkSkipWrite and ChunkTests#testChunkSkipWriteExceedSkip verify that the list the SkipWriteListener receives does not have any nulls in it, but it does not verify the number of items in the list (or that the items are the correct ones for that matter). We noticed this on accident by just wrapping the Spring Batch equivalent of this listener. In SB, by default, we only pass in the item that was skipped (instead of all of the items in the current chunk as the spec requires). When we wrap the SB functionality (passing a new list that contains only the skipped item to the listener), the test passes even though the implemented behavior is incorrect.