adfemg
  1. adfemg
  2. ADFEMG-130

ER 16782260 : JDEV SHOULD GENERATE UI COMPONENT BINDING USING COMPONENTREFERENCE

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Labels:
      None

      Description

      hi

      Please consider enhancement request 16782260, "JDEV SHOULD GENERATE UI COMPONENT BINDING USING COMPONENTREFERENCE", which can be found on My Oracle Support.

      It currently has "Severity 1 - Extremely desirable feature" but does not publish much details:

      Abstract: JDEV SHOULD GENERATE UI COMPONENT BINDING USING COMPONENTREFERENCE
      *** 05/08/13 11:25 am REQUEST TEXT ***
      *** 05/08/13 11:25 am BUSINESS NEED ***
      *** 05/08/13 11:28 am *** 
      

      Can someone please explain what this ER 16782260 is about?

      many thanks
      Jan Vervecken

        Activity

        Hide
        Andreas Koop added a comment -

        Hi Jan,

        I guess it relates somehow to the following Article by Steven Davelaar:
        http://www.unitask.com/oracledaily/2012/12/20/rules-and-best-practices-for-jsf-component-binding-in-adf/

        Regards,
        Andreas Koop

        Show
        Andreas Koop added a comment - Hi Jan, I guess it relates somehow to the following Article by Steven Davelaar: http://www.unitask.com/oracledaily/2012/12/20/rules-and-best-practices-for-jsf-component-binding-in-adf/ Regards, Andreas Koop
        Hide
        Jan Vervecken added a comment -

        Thanks for your reply Andreas.

        Based on the abstract of ER 16782260, it sure looks related to the interesting article you refer to.

        regards
        Jan Vervecken

        Show
        Jan Vervecken added a comment - Thanks for your reply Andreas. Based on the abstract of ER 16782260, it sure looks related to the interesting article you refer to. regards Jan Vervecken
        Hide
        steven.davelaar added a comment -

        Jan,

        Andreas is right, I logged this ER yesterday after a conversation with ADF Faces engineering.
        They asked me to do so, and they will pick it up with priority as they agree this is something that should be fixed asap.
        Unfortunately, when I create an enhancement, it is marked as internal request and the text is hidden. Here is the text from the ER:

        When using the JDeveloper design-time dialogs to set the binding property on
        @ a UI component, the code that is generated by JDeveloper is not optimal. The
        @ generated code can cause severe memory and serialization issues depending on
        @ the scope of the bean.
        @ Example of currently generated code:
        @ .
        @ import oracle.adf.view.rich.component.rich.input.RichInputText;
        @ .
        @ private RichInputText greetingField;
        @ .
        @ public void setGreetingField(RichInputText greetingField)
        @

        { @ this.greetingField = greetingField; @ }


        @ .
        @ public RichInputText getGreetingField()
        @

        { @ return greetingField; @ }


        @ .
        @ The correct code is as follows:
        @ .
        @ import oracle.adf.view.rich.component.rich.input.RichInputText;
        @ import org.apache.myfaces.trinidad.util.ComponentReference;
        @ .
        @ private ComponentReference greetingField;
        @ .
        @ public void setGreetingField(RichInputText greetingField)
        @

        { @ this.greetingField = @ ComponentReference.newUIComponentReference(greetingField); @ }


        @ .
        @ public RichInputText getGreetingField()
        @ {
        @ if (greetingField!=null)
        @

        { @ return (RichInputText) greetingField.getComponent(); @ }


        @ return null;
        @ }
        @ .

        Show
        steven.davelaar added a comment - Jan, Andreas is right, I logged this ER yesterday after a conversation with ADF Faces engineering. They asked me to do so, and they will pick it up with priority as they agree this is something that should be fixed asap. Unfortunately, when I create an enhancement, it is marked as internal request and the text is hidden. Here is the text from the ER: When using the JDeveloper design-time dialogs to set the binding property on @ a UI component, the code that is generated by JDeveloper is not optimal. The @ generated code can cause severe memory and serialization issues depending on @ the scope of the bean. @ Example of currently generated code: @ . @ import oracle.adf.view.rich.component.rich.input.RichInputText; @ . @ private RichInputText greetingField; @ . @ public void setGreetingField(RichInputText greetingField) @ { @ this.greetingField = greetingField; @ } @ . @ public RichInputText getGreetingField() @ { @ return greetingField; @ } @ . @ The correct code is as follows: @ . @ import oracle.adf.view.rich.component.rich.input.RichInputText; @ import org.apache.myfaces.trinidad.util.ComponentReference; @ . @ private ComponentReference greetingField; @ . @ public void setGreetingField(RichInputText greetingField) @ { @ this.greetingField = @ ComponentReference.newUIComponentReference(greetingField); @ } @ . @ public RichInputText getGreetingField() @ { @ if (greetingField!=null) @ { @ return (RichInputText) greetingField.getComponent(); @ } @ return null; @ } @ . SDAVELAA 05/08/13 11:25 am BUSINESS NEED *** @ The generated code is causing serious memory and performance issues at almost @ all ADF customers. The proper code is largely unknown. @ See also this blog post: @ https://blogs.oracle.com/ATEAM_WEBCENTER/entry/rules_and_best_practices_for
        Hide
        Jan Vervecken added a comment -

        Thanks for your reply Steven, and for including details of ER 16782260.

        regards
        Jan Vervecken

        Show
        Jan Vervecken added a comment - Thanks for your reply Steven, and for including details of ER 16782260. regards Jan Vervecken
        Hide
        chriscmuir added a comment -

        Jan, as you've the details of the ER can you now close this ADF EMG issue please.

        CM.

        Show
        chriscmuir added a comment - Jan, as you've the details of the ER can you now close this ADF EMG issue please. CM.
        Hide
        chriscmuir added a comment -

        No further info received, closing issue.

        CM.

        Show
        chriscmuir added a comment - No further info received, closing issue. CM.

          People

          • Assignee:
            Unassigned
            Reporter:
            Jan Vervecken
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: