facelets
  1. facelets
  2. FACELETS-316

DevTools.writeAttributes does wrong null check

    Details

    • Type: Task Task
    • Status: Open
    • Priority: Major Major
    • Resolution: Unresolved
    • Affects Version/s: 1.1.14
    • Fix Version/s: 1.1.15
    • Component/s: jsf
    • Labels:
      None
    • Environment:

      Operating System: All
      Platform: All

    • Issuezilla Id:
      316

      Description

      DevTools line 240 and 241...
      if (pd[i].getWriteMethod() != null && Arrays.binarySearch(IGNORE,
      pd[i].getName()) < 0) {
      m = pd[i].getReadMethod();
      ...

      Shouldn't that check on line 240 be
      if (pd[i].getReadMethod()
      since you call getReadMethod not getWriteMethod? It's minor since the method
      eats the exception, but it would be a lot cleaner to not generate the NPE in the
      first place.

        Activity

        There are no comments yet on this issue.

          People

          • Assignee:
            Unassigned
            Reporter:
            gstacey
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated: