facelets
  1. facelets
  2. FACELETS-347

TagValueExpression.equals does not work properly

    Details

    • Type: Bug Bug
    • Status: Open
    • Priority: Major Major
    • Resolution: Unresolved
    • Affects Version/s: 1.1.14
    • Fix Version/s: 1.1.15
    • Component/s: jsf
    • Labels:
      None
    • Environment:

      Operating System: All
      Platform: All

    • Issuezilla Id:
      347

      Description

      This is the source code of TagValueExpression equals method:

      public boolean equals(Object obj) {
      return this.orig.equals(obj.orig);
      }

      This implementation uses the orig property to be compared with the obj parameter
      and not the orig property of the obj parameter. i.e. this should be:

      public boolean equals(Object obj) {
      return this.orig.equals(obj.orig);
      }

        Activity

        Hide
        igor_ti added a comment -

        Today I reviewed this issue and realized that I posted the current facelets
        source code incorrectly (with the fix applied), then follow down the source of
        the current class TagValueExpression that makes the comparison unfair manner.

        public boolean equals(Object obj)

        { return this.orig.equals(obj); }

        This method remains the same on the current 1.1.15 draft release.

        Show
        igor_ti added a comment - Today I reviewed this issue and realized that I posted the current facelets source code incorrectly (with the fix applied), then follow down the source of the current class TagValueExpression that makes the comparison unfair manner. public boolean equals(Object obj) { return this.orig.equals(obj); } This method remains the same on the current 1.1.15 draft release.

          People

          • Assignee:
            Unassigned
            Reporter:
            igor_ti
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated: