Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: V3
    • Fix Version/s: 3.1
    • Component/s: build_system
    • Labels:
      None
    • Environment:

      Operating System: All
      Platform: All

    • Issuezilla Id:
      10,456
    • Status Whiteboard:
      Hide

      v3_exclude

      Show
      v3_exclude

      Description

      A lot of pom.xmls still specify versions instead of using dependencyManagement.
      Take a look at the output produced by the following command:
      find . -name pom.xml | xargs grep version | grep -v ^\./pom.xml | grep -v
      project.*.version | grep -v 3.0-SNAPSHOT | grep -v target | grep /version | grep
      -v publish | grep -v tests

      ./ejb/ejb-container/pom.xml: <version>$

      {pom.parent.version}</version>
      ./ejb/ejb-container/pom.xml:
      <version>${glassfish-corba.version}</version>
      ./ejb/ejb-timer-service-app/pom.xml: <version>2.0.2</version>
      ./orb/orb-connector/pom.xml:
      <version>${glassfish-corba.version}</version>
      ./orb/orb-connector/pom.xml: <version>${pom.parent.version}

      </version>
      ./orb/orb-iiop/pom.xml: <version>$

      {pom.parent.version}</version>
      ./orb/orb-iiop/pom.xml: <version>${glassfish-corba.version}</version>
      ./orb/orb-iiop/pom.xml: <version>${glassfish-corba.version}</version>
      ./orb/orb-iiop/pom.xml: <version>${glassfish-corba.version}</version>
      ./orb/orb-iiop/pom.xml: <version>${glassfish-corba.version}</version>
      ./orb/orb-iiop/pom.xml: <version>${glassfish-corba.version}</version>
      ./web/jstl-connector/pom.xml: <version>${jstl-impl.version}</version>
      ./web/web-embed/impl/pom.xml: <version>1.1</version>
      ./web/jsf-connector/pom.xml: <version>${jsf-impl.version}</version>
      ./core/branding/pom.xml: <version>4.3.1</version>
      ./core/kernel/pom.xml: <version>1.1</version>
      ./core/kernel/pom.xml: <version>1.0-2</version>
      ./core/bootstrap/pom.xml: <version>1.1</version>
      ./jdbc/jdbc-ra/jdbc-core/pom.xml: <version>4.3.1</version>
      ./jdbc/jdbc-ra/pom.xml: <version>1.8</version>
      ./jdbc/pom.xml: <version>1.8</version>
      ./persistence/cmp/support-sqlstore/pom.xml:
      <version>${antlr.version}</version>
      ./persistence/cmp/support-ejb/pom.xml:
      <version>${antlr.version}</version>
      ./appclient/client/acc/pom.xml: <version>2.2</version>
      ./appclient/client/acc/pom.xml: <version>2.4</version>
      ./appclient/client/acc/pom.xml: <version>2.1</version>
      ./appclient/client/acc/pom.xml: <version>${acc.corba-version}</version>
      ./appclient/client/acc-config/pom.xml: <version>2.2</version>
      ./appclient/server/core/pom.xml: <version>1.6</version>
      ./appclient/server/core/pom.xml: <version>1.6</version>
      ./appclient/server/core/pom.xml: <version>${hk2.version}</version>
      ./maven-plugin/src/test/start/pom.xml: <version>1.8</version>
      ./maven-plugin/src/test/start/pom.xml: <version>2.0</version>
      ./maven-plugin/src/test/start/pom.xml: <version>2.0</version>
      ./maven-plugin/src/test/deploy/pom.xml: <version>1.8</version>
      ./maven-plugin/src/test/deploy/pom.xml: <version>2.0</version>
      ./maven-plugin/src/test/deploy/pom.xml: <version>2.0</version>
      ./maven-plugin/src/test/pom.xml: <version>1.8</version>
      ./maven-plugin/src/test/pom.xml: <version>2.0</version>
      ./maven-plugin/src/test/pom.xml: <version>2.0</version>
      ./maven-plugin/src/test/pom.xml: <version>3.8.1</version>
      ./maven-plugin/pom.xml: <version>1.8</version>
      ./maven-plugin/pom.xml: <version>2.0</version>
      ./maven-plugin/pom.xml: <version>2.0</version>
      ./admin/rest/pom.xml: <version>1.1</version>
      ./admin/addon/pom.xml: <version>1.1-SNAPSHOT</version>
      ./admin/addon/pom.xml: <version>1.1-SNAPSHOT</version>
      ./admin/addon/pom.xml: <version>1.1-SNAPSHOT</version>
      ./admin/addon/pom.xml: <version>4.3.1</version>
      ./admin/runtime/rtapt/apt/pom.xml: <version>1.1-SNAPSHOT</version>
      ./admin/runtime/rtapt/apt/pom.xml: <version>1.1-SNAPSHOT</version>
      ./admin/runtime/rtapt/apt/pom.xml: <version>1.4.2</version>
      ./admin/runtime/rtapt/annotations/pom.xml: <version>1.1-SNAPSHOT</version>
      ./admin/runtime/rtapt/pom.xml: <version>1</version>
      ./admin/runtime/rtapt/pom.xml: <version>1.1-SNAPSHOT</version>
      ./admin/config-api/pom.xml: <version>1.0</version>
      ./build/maven-glassfishbuild-extension/pom.xml: <version>2.0.7</version>
      ./build/glassfishbuild-repo-setup/pom.xml: <version>${mq.version}</version>
      ./build/glassfishbuild-repo-setup/pom.xml: <version>${javadb.version}</version>
      ./build/glassfishbuild-repo-setup/pom.xml: <version>${javadb.version}</version>
      ./build/glassfishbuild-repo-setup/pom.xml: <version>${javadb.version}</version>
      ./build/glassfishbuild-repo-setup/pom.xml: <version>${javadb.version}</version>
      ./build/glassfishbuild-repo-setup/pom.xml: <version>${javadb.version}</version>
      ./build/glassfishbuild-repo-setup/pom.xml: <version>${javadb.version}</version>
      ./build/maven-glassfishbuild-plugin/pom.xml: <version>1.8</version>
      ./build/maven-glassfishbuild-plugin/pom.xml: <version>1.3.1</version>
      ./build/maven-glassfishbuild-plugin/pom.xml: <version>2.0</version>
      ./build/maven-glassfishbuild-plugin/pom.xml: <version>2.0.7</version>
      ./build/maven-glassfishbuild-plugin/pom.xml:
      <version>1.0-beta-3</version>
      ./build/maven-glassfishbuild-plugin/pom.xml:
      <version>1.0-beta-3</version>
      ./build/maven-glassfishbuild-plugin/pom.xml: <version>2.0</version>
      ./build/maven-glassfishbuild-plugin/pom.xml: <version>2.0</version>
      ./build/maven-glassfishbuild-plugin/pom.xml: <version>1.7.0</version>
      ./build/maven-glassfishbuild-plugin/pom.xml: <version>1.1</version>
      ./build/pom.xml: <version>1.0-beta-2</version>
      ./packager/mq/pom.xml: <version>${mq.version}</version>
      ./packager/external/ant/pom.xml: <version>1.7.0</version>
      ./packager/external/ant/pom.xml: <version>1.7.0</version>
      ./packager/external/jmsra/pom.xml: <version>${mq.version}</version>
      ./packager/external/apache-commons/pom.xml:
      <version>${commons.beanutils.version}</version>
      ./packager/external/apache-commons/pom.xml:
      <version>${commons.collections.version}</version>
      ./packager/external/apache-commons/pom.xml:
      <version>${commons.digester.version}</version>
      ./packager/external/apache-commons/pom.xml:
      <version>${commons.modeler.version}</version>
      ./packager/external/jmxremote_optional/pom.xml:
      <version>1.0_01-ea</version>
      ./packager/external/javadb/pom.xml: <version>${javadb.version}</version>
      ./packager/external/ldapbp/pom.xml: <version>1.0</version>
      ./packager/external/sysnet-registration/pom.xml: <version>1.0.2</version>
      ./packager/external/asm-all/pom.xml: <version>${asm.version}</version>
      ./packager/external/commons-codec/pom.xml:
      <version>20041127.091804</version>
      ./packager/external/jaxr_ra/pom.xml: <version>${jaxr.version}</version>
      ./packager/glassfish-web-incorporation/pom.xml:
      <version>0.2</version>
      ./packager/glassfish-generic-ra/pom.xml: <version>2.0-20081121</version>
      ./packager/glassfish-hk2/pom.xml: <version>${hk2.version}</version>
      ./packager/glassfish-gui/pom.xml:
      <version>${dataprovider.version}</version>
      ./packager/glassfish-gui/pom.xml:
      <version>${jsftemplating.version}</version>
      ./packager/glassfish-jsf/pom.xml: <version>${jsf-api.version}</version>
      ./packager/glassfish-jsf/pom.xml: <version>${jsf-impl.version}</version>
      ./packager/glassfish-jdbc-gui/pom.xml: <version>0.2</version>
      ./packager/glassfish-full-incorporation/pom.xml:
      <version>0.2</version>
      ./packager/glassfish-common-tmp/pom.xml: <version>2.0.02</version>
      ./packager/glassfish-corba-omgapi/pom.xml:
      <version>${glassfish-corba.version}</version>
      ./packager/jersey/pom.xml: <version>${jersey.version}</version>
      ./packager/glassfish-nucleus/pom.xml: <version>3.0-Prelude</version>
      ./packager/glassfish-nucleus/pom.xml: <version>3.0.0-b008</version>
      ./packager/glassfish-corba/pom.xml:
      <version>${glassfish-corba.version}</version>
      ./packager/glassfish-corba/pom.xml:
      <version>${glassfish-corba.version}</version>
      ./packager/glassfish-corba/pom.xml:
      <version>${glassfish-corba.version}</version>
      ./packager/glassfish-web-gui/pom.xml: <version>0.2</version>
      ./packager/glassfish-scripting/pom.xml:
      <version>${jruby-scripting.version}</version>
      ./packager/glassfish-codegen/pom.xml:
      <version>${glassfish-corba.version}</version>
      ./packager/glassfish-codegen/pom.xml:
      <version>${glassfish-corba.version}</version>
      ./packager/glassfish-codegen/pom.xml:
      <version>${glassfish-corba.version}</version>
      ./deployment/dol/pom.xml: <version>${hk2.version}</version>
      ./deployment/dol/pom.xml:
      <version>${javax-persistence-api.version}</version>
      ./deployment/dol/pom.xml: <version>${pom.parent.version}

      </version>
      ./javaee-api/javax.servlet.jsp/pom.xml:
      <version>$

      {jsp-api.version}

      </version>
      ./javaee-api/javax.servlet.jsp/pom.xml:
      <version>$

      {el-api.version}

      </version>
      ./javaee-api/javax.mail/pom.xml: <version>$

      {mail.version}

      </version>
      ./javaee-api/javax.javaee/compact/pom.xml: <version>1.1.1</version>
      ./javaee-api/javax.javaee/compact/pom.xml: <version>1.6</version>
      ./javaee-api/javax.javaee/compact/pom.xml: <version>1.6</version>
      ./javaee-api/javax.javaee/compact/pom.xml: <version>1.6.0</version>
      ./javaee-api/javax.javaee/pom.xml: <version>RELEASE</version>
      ./javaee-api/javax.javaee/pom.xml: <version>RELEASE</version>
      ./javaee-api/javax.javaee/pom.xml: <version>1.1</version>
      ./javaee-api/javax.javaee/pom.xml:
      <version>$

      {javax-persistence-api.version}</version>
      ./javaee-api/javax.javaee/pom.xml:
      <version>3.0-JBoss-4.0.0.Beta1-b01</version>
      ./javaee-api/javax.javaee/pom.xml: <version>${webbeans.version}</version>
      ./javaee-api/javax.javaee/pom.xml: <version>4.3</version>
      ./javaee-api/javax.javaee/pom.xml:
      <version>${jstl-impl.version}</version>
      ./javaee-api/javax.xml.bind/pom.xml:
      <version>${jaxb-api.version}</version>
      ./javaee-api/javax.xml.soap/pom.xml:
      <version>${saaj-api.version}</version>
      ./javaee-api/javax.xml.stream/pom.xml:
      <version>${stax-api.version}</version>
      ./javaee-api/javax.xml.rpc/pom.xml:
      <version>${jaxrpc-api.version}</version>
      ./javaee-api/javax.servlet.jsp.jstl/pom.xml:
      <version>${jstl-api.version}</version>
      ./javaee-api/javax.xml.ws/pom.xml:
      <version>${jaxws-api.version}</version>
      ./javaee-api/pom.xml: <version>4.3.1</version>
      ./javaee-api/javax.jms/pom.xml: <version>${jms-api.version}</version>
      ./javaee-api/javax.jws/pom.xml: <version>${jsr181-api.version}</version>
      ./webservices/jsr109-impl/pom.xml:
      <version>${webservices.version>}</version>
      ./webservices/jsr109-impl/pom.xml:
      <version>${jaxb.version}</version>
      ./synchronization/pom.xml: <version>${hk2.plugin.version}</version>
      ./synchronization/pom.xml: <version>4.3.1</version>
      ./common/glassfish-api/pom.xml: <version>${hk2.version}</version>
      ./common/glassfish-api/pom.xml: <version>4.3.1</version>
      ./common/amx-ext-impl/pom.xml: <version>3.0.0-b004</version>
      ./common/glassfish-naming/pom.xml: <version>1.0</version>
      ./common/container-common/pom.xml: <version>4.3.1</version>
      ./extras/grizzly-container/pom.xml: <version>${hk2.version}</version>
      ./extras/jmxcmd/pom.xml: <version>1.0-SNAPSHOT</version>
      ./extras/jmxcmd/pom.xml: <version>0.9.9</version>
      ./extras/jmxcmd/pom.xml: <version>4.5</version>
      ./extras/jmxcmd/pom.xml: <version>1.0.1_04</version>
      ./extras/jmxcmd/pom.xml: <version>1.0_01-ea</version>
      ./extras/osgi-container/pom.xml: <version>${hk2.version}</version>
      ./verifier/verifier-impl/pom.xml: <version>2.0.02</version>
      ./osgi-platforms/felix/pom.xml:
      <version>2.0.0</version>
      ./osgi-platforms/felix/pom.xml:
      <version>1.4.0</version>
      ./osgi-platforms/felix/pom.xml:
      <version>1.4.0</version>
      ./osgi-platforms/felix/pom.xml:
      <version>1.0.4</version>
      ./osgi-platforms/felix/pom.xml:
      <version>1.2.0</version>
      ./osgi-platforms/felix/pom.xml:
      <version>1.2.4</version>
      ./osgi-platforms/felix/pom.xml:
      <version>1.0.8</version>
      ./osgi-platforms/felix/pom.xml: <version>1.0.3</version>
      ./security/core/pom.xml: <version>1.0</version>
      ./security/core/pom.xml: <version>1.0</version>
      ./security/ejb.security/pom.xml:
      <version>${glassfish-corba.version}</version>
      ./security/ejb.security/pom.xml:
      <version>${glassfish-corba.version}</version>
      ./security/ejb.security/pom.xml:
      <version>${glassfish-corba.version}</version>
      ./flashlight/framework/pom.xml: <version>1.6.0</version>
      ./flashlight/framework/pom.xml: <version>1.6.0</version>
      ./flashlight/btrace/pom.xml: <version>1.0.3</version>
      ./flashlight/btrace/pom.xml: <version>1.0.3</version>
      ./flashlight/client/pom.xml: <version>1.6.0</version>
      ./ant-tasks/pom.xml: <version>1.7.0</version>
      ./transaction/jta/pom.xml:
      <version>${javax-persistence-api.version}

      </version>
      ./transaction/jts/pom.xml: <version>$

      {glassfish-corba.version}</version>
      ./transaction/jts/pom.xml: <version>${glassfish-corba.version}

      </version>
      ./transaction/internal-api/pom.xml:
      <version>$

      {javax-persistence-api.version}

      </version>
      ./admingui/war/pom.xml: <version>2.0.2</version>
      ./admingui/war/pom.xml: <version>$

      {scales.version}

      </version>
      ./admingui/war/pom.xml: <version>3.0-b01</version>
      ./admingui/war/pom.xml: <version>1.1.1</version>
      ./admingui/core/pom.xml: <version>1.0</version>
      ./admingui/core/pom.xml: <version>0.4.1</version>
      ./admingui/core/pom.xml: <version>1.5.0</version>
      ./admingui/jsftemplating/pom.xml: <version>$

      {jsftemplating.version}</version>
      ./admingui/jsftemplating/pom.xml:
      <version>${jsftemplating.version}

      </version>
      ./admingui/console-plugin-archetype/src/main/resources/archetype-resources/pom.xml:
      <version>$

      {hk2.plugin.version}</version>
      ./admingui/console-plugin-archetype/pom.xml: <version>1.0-beta-2</version>
      ./admingui/console-plugin-archetype/pom.xml: <version>2.0-alpha-3</version>
      ./admingui/console-plugin-archetype/pom.xml: <version>2.0-alpha-3</version>
      ./admingui/plugin-service/pom.xml: <!-<version>10.0.0-rev6</version>->
      ./admingui/plugin-service/pom.xml: <!--<version>[10.0*,11.0)</version> -->
      ./admingui/common/pom.xml:
      <version>${jsftemplating.version}</version>
      ./admingui/common/pom.xml: <version>${jsftemplating.version}</version>
      ./admingui/common/pom.xml: <version>${jsftemplating.version}</version>
      ./admingui/common/pom.xml: <version>${jsf-api.version}</version>
      ./admingui/dataprovider/pom.xml: <version>4.2</version>
      ./admingui/dataprovider/pom.xml: <version>1.0</version>
      ./admingui/community-theme/pom.xml:
      <version>${hk2.plugin.version}

      </version>
      ./admingui/jms-plugin/pom.xml: <version>4.3</version>
      ./admingui/pom.xml:
      <version>$

      {jsftemplating.version}</version>
      ./admingui/pom.xml: <version>${hk2.version}</version>
      ./admingui/pom.xml: <version>${jsftemplating.version}

      </version>
      ./admingui/pom.xml: <version>$

      {jsftemplating.version}

      </version>
      ./admingui/pom.xml: <version>$

      {jsf-api.version}

      </version>
      ./admingui/pom.xml: <version>$

      {dataprovider.version}

      </version>
      ./distributions/web/pom.xml: <version>2.4.2</version>
      ./distributions/appclient/pom.xml: <version>2.2-beta-3</version>
      ./distributions/nucleus/pom.xml: <version>2.4.2</version>
      ./distributions/nucleus/pom.xml: <version>$

      {hk2.version}</version>
      ./installer/pom.xml: <version>1.6</version>
      ./installer/pom.xml: <version>0.9.4.6</version>
      ./installer/pom.xml: <version>0.9.4.2</version>
      ./registration/glassfish-registration/pom.xml:
      <version>${hk2.version}

      </version>

        Activity

        Hide
        janey added a comment -

        confirmed

        Show
        janey added a comment - confirmed
        Hide
        janey added a comment -

        working on this...

        Show
        janey added a comment - working on this...
        Hide
        janey added a comment -

        Added the following to dependencyManagement:

        + <dependency>
        + <groupId>com.sun.tools.btrace</groupId>
        + <artifactId>btrace-agent</artifactId>
        + <version>$

        {btrace.version}</version>
        + </dependency>

        + <dependency>
        + <groupId>com.sun.tools.btrace</groupId>
        + <artifactId>btrace-boot</artifactId>
        + <version>${btrace.version}

        </version>
        + </dependency>
        +
        + <dependency>
        + <groupId>com.sun.corba</groupId>
        + <artifactId>glassfish-corba-orbgeneric</artifactId>
        + <version>$

        {glassfish-corba.version}</version>
        + </dependency>
        + <dependency>
        + <groupId>com.sun.corba</groupId>
        + <artifactId>glassfish-corba-omgapi</artifactId>
        + <version>${glassfish-corba.version}

        </version>
        + </dependency>
        + <dependency>
        + <groupId>org.kohsuke.metainf-services</groupId>
        + <artifactId>metainf-services</artifactId>
        + <version>1.1</version>
        + </dependency>
        + <dependency>
        + <groupId>javax.xml.stream</groupId>
        + <artifactId>stax-api</artifactId>
        + <version>$

        {stax-api.version}

        </version>
        + </dependency>
        + <dependency>
        + <groupId>com.sun.xml.stream</groupId>
        + <artifactId>sjsxp</artifactId>
        + <version>1.0</version>
        + </dependency>
        + <dependency>
        + <groupId>junit</groupId>
        + <artifactId>junit</artifactId>
        + <version>4.3.1</version>
        + </dependency>

        Show
        janey added a comment - Added the following to dependencyManagement: + <dependency> + <groupId>com.sun.tools.btrace</groupId> + <artifactId>btrace-agent</artifactId> + <version>$ {btrace.version}</version> + </dependency> + <dependency> + <groupId>com.sun.tools.btrace</groupId> + <artifactId>btrace-boot</artifactId> + <version>${btrace.version} </version> + </dependency> + + <dependency> + <groupId>com.sun.corba</groupId> + <artifactId>glassfish-corba-orbgeneric</artifactId> + <version>$ {glassfish-corba.version}</version> + </dependency> + <dependency> + <groupId>com.sun.corba</groupId> + <artifactId>glassfish-corba-omgapi</artifactId> + <version>${glassfish-corba.version} </version> + </dependency> + <dependency> + <groupId>org.kohsuke.metainf-services</groupId> + <artifactId>metainf-services</artifactId> + <version>1.1</version> + </dependency> + <dependency> + <groupId>javax.xml.stream</groupId> + <artifactId>stax-api</artifactId> + <version>$ {stax-api.version} </version> + </dependency> + <dependency> + <groupId>com.sun.xml.stream</groupId> + <artifactId>sjsxp</artifactId> + <version>1.0</version> + </dependency> + <dependency> + <groupId>junit</groupId> + <artifactId>junit</artifactId> + <version>4.3.1</version> + </dependency>
        Hide
        janey added a comment -

        Add more dependencies in dependencyManagement in v3/pom.xml:

        + <dependency>
        + <groupId>com.sun.jsftemplating</groupId>
        + <artifactId>jsftemplating</artifactId>
        + <version>$

        {jsftemplating.version}</version>
        + </dependency>
        +
        + <dependency>
        + <groupId>com.sun.jsftemplating</groupId>
        + <artifactId>jsftemplating-dt</artifactId>
        + <version>${jsftemplating.version}

        </version>
        + </dependency>
        +
        + <dependency>
        + <groupId>com.sun.woodstock.dependlibs</groupId>
        + <artifactId>json</artifactId>
        + <version>1.0</version>
        + </dependency>
        + <dependency>
        + <groupId>com.sun.woodstock.dependlibs</groupId>
        + <artifactId>dojo-ajax</artifactId>
        + <version>0.4.1</version>
        + </dependency>
        + <dependency>
        + <groupId>com.sun.woodstock.dependlibs</groupId>
        + <artifactId>prototype</artifactId>
        + <version>1.5.0</version>
        + </dependency>
        + <dependency>
        + <groupId>com.sun.woodstock.dependlibs</groupId>
        + <artifactId>dataprovider</artifactId>
        + <version>1.0</version>
        + </dependency>
        + <dependency>
        + <groupId>com.sun.messaging.mq</groupId>
        + <artifactId>imqjmx</artifactId>
        + <version>4.3</version>
        + </dependency>

        and remove the version element in the submodule pom files.

        svn revision 33918.

        Show
        janey added a comment - Add more dependencies in dependencyManagement in v3/pom.xml: + <dependency> + <groupId>com.sun.jsftemplating</groupId> + <artifactId>jsftemplating</artifactId> + <version>$ {jsftemplating.version}</version> + </dependency> + + <dependency> + <groupId>com.sun.jsftemplating</groupId> + <artifactId>jsftemplating-dt</artifactId> + <version>${jsftemplating.version} </version> + </dependency> + + <dependency> + <groupId>com.sun.woodstock.dependlibs</groupId> + <artifactId>json</artifactId> + <version>1.0</version> + </dependency> + <dependency> + <groupId>com.sun.woodstock.dependlibs</groupId> + <artifactId>dojo-ajax</artifactId> + <version>0.4.1</version> + </dependency> + <dependency> + <groupId>com.sun.woodstock.dependlibs</groupId> + <artifactId>prototype</artifactId> + <version>1.5.0</version> + </dependency> + <dependency> + <groupId>com.sun.woodstock.dependlibs</groupId> + <artifactId>dataprovider</artifactId> + <version>1.0</version> + </dependency> + <dependency> + <groupId>com.sun.messaging.mq</groupId> + <artifactId>imqjmx</artifactId> + <version>4.3</version> + </dependency> and remove the version element in the submodule pom files. svn revision 33918.
        Hide
        janey added a comment -

        Remove hard-coded version in admingui/dataprovider/pom.xml

        Index: pom.xml
        ===============================================================
        ====
        — pom.xml (revision 34372)
        +++ pom.xml (working copy)
        @@ -127,7 +127,6 @@
        <jmac-api.version>1.0-rev-1</jmac-api.version>
        <jaxws-ri.version>2.1.3</jaxws-ri.version>
        <stax-api.version>1.0-2</stax-api.version>

        • <dataprovider.version>4.2</dataprovider.version>
          <jsftemplating.version>2.0.2</jsftemplating.version>
          <scales.version>1.3.1</scales.version>
          <glassfish-corba.version>3.0.0-b038</glassfish-corba.version>
          Index: packager/glassfish-gui/pom.xml
          ===============================================================
          ====
            • packager/glassfish-gui/pom.xml (revision 34372)
              +++ packager/glassfish-gui/pom.xml (working copy)
              @@ -79,7 +79,7 @@
              <dependency>
              <groupId>org.glassfish.admingui</groupId>
              <artifactId>dataprovider</artifactId>
        • <version>$ {dataprovider.version}</version>
          + <version>${project.version}</version>
          </dependency>
          <dependency>
          <groupId>com.sun.jsftemplating</groupId>
          Index: admingui/dataprovider/pom.xml
          ===============================================================
          ====
          — admingui/dataprovider/pom.xml (revision 34372)
          +++ admingui/dataprovider/pom.xml (working copy)
          @@ -48,7 +48,6 @@
          <groupId>org.glassfish.admingui</groupId>
          <artifactId>dataprovider</artifactId>
          <name>DataProvider</name>
          - <version>4.2</version>
          <modelVersion>4.0.0</modelVersion>
          <description>DataProvider Repackaged as OSGi bundle for GlassFish</description>

          Index: admingui/core/pom.xml
          ===============================================================
          ====
          — admingui/core/pom.xml (revision 34372)
          +++ admingui/core/pom.xml (working copy)
          @@ -206,5 +206,11 @@
          <version>${project.version}</version>
          <scope>provided</scope>
          </dependency>
          + <dependency>
          + <groupId>org.glassfish.admingui</groupId>
          + <artifactId>dataprovider</artifactId>
          + <version>${project.version}</version>
          + <scope>provided</scope>
          + </dependency>
          </dependencies>
          </project>
          Index: admingui/pom.xml
          ===============================================================
          ====
          — admingui/pom.xml (revision 34372)
          +++ admingui/pom.xml (working copy)
          @@ -146,20 +146,5 @@
          <version>${project.version}</version>
          <scope>provided</scope>
          </dependency>
          - <dependency>
          - <groupId>org.glassfish.admingui</groupId>
          - <artifactId>dataprovider</artifactId>
          - <version>${dataprovider.version}

          </version>

        • <scope>provided</scope>
        • </dependency>
          </dependencies>
          -
        • <properties>
          -
        • <!-- raih:During release first official release change the versions of the following to the current
          level and then release the comments
        • <glassfish-api.version>10.0.0-rev8</glassfish-api.version>
        • <hk2.version>0.3.8</hk2.version>
        • -->
        • <dataprovider.version>4.2</dataprovider.version>
        • </properties>
          </project>
        Show
        janey added a comment - Remove hard-coded version in admingui/dataprovider/pom.xml Index: pom.xml =============================================================== ==== — pom.xml (revision 34372) +++ pom.xml (working copy) @@ -127,7 +127,6 @@ <jmac-api.version>1.0-rev-1</jmac-api.version> <jaxws-ri.version>2.1.3</jaxws-ri.version> <stax-api.version>1.0-2</stax-api.version> <dataprovider.version>4.2</dataprovider.version> <jsftemplating.version>2.0.2</jsftemplating.version> <scales.version>1.3.1</scales.version> <glassfish-corba.version>3.0.0-b038</glassfish-corba.version> Index: packager/glassfish-gui/pom.xml =============================================================== ==== packager/glassfish-gui/pom.xml (revision 34372) +++ packager/glassfish-gui/pom.xml (working copy) @@ -79,7 +79,7 @@ <dependency> <groupId>org.glassfish.admingui</groupId> <artifactId>dataprovider</artifactId> <version>$ {dataprovider.version}</version> + <version>${project.version}</version> </dependency> <dependency> <groupId>com.sun.jsftemplating</groupId> Index: admingui/dataprovider/pom.xml =============================================================== ==== — admingui/dataprovider/pom.xml (revision 34372) +++ admingui/dataprovider/pom.xml (working copy) @@ -48,7 +48,6 @@ <groupId>org.glassfish.admingui</groupId> <artifactId>dataprovider</artifactId> <name>DataProvider</name> - <version>4.2</version> <modelVersion>4.0.0</modelVersion> <description>DataProvider Repackaged as OSGi bundle for GlassFish</description> Index: admingui/core/pom.xml =============================================================== ==== — admingui/core/pom.xml (revision 34372) +++ admingui/core/pom.xml (working copy) @@ -206,5 +206,11 @@ <version>${project.version}</version> <scope>provided</scope> </dependency> + <dependency> + <groupId>org.glassfish.admingui</groupId> + <artifactId>dataprovider</artifactId> + <version>${project.version}</version> + <scope>provided</scope> + </dependency> </dependencies> </project> Index: admingui/pom.xml =============================================================== ==== — admingui/pom.xml (revision 34372) +++ admingui/pom.xml (working copy) @@ -146,20 +146,5 @@ <version>${project.version}</version> <scope>provided</scope> </dependency> - <dependency> - <groupId>org.glassfish.admingui</groupId> - <artifactId>dataprovider</artifactId> - <version>${dataprovider.version} </version> <scope>provided</scope> </dependency> </dependencies> - <properties> - <!-- raih:During release first official release change the versions of the following to the current level and then release the comments <glassfish-api.version>10.0.0-rev8</glassfish-api.version> <hk2.version>0.3.8</hk2.version> --> <dataprovider.version>4.2</dataprovider.version> </properties> </project>
        Hide
        janey added a comment -

        Add more to dependencyManagement.

        Index: pom.xml
        ===============================================================
        ====
        — pom.xml (revision 34382)
        +++ pom.xml (working copy)
        @@ -159,6 +159,7 @@
        <opendmk.version>1.0-b01-ea</opendmk.version>
        <v3-docs.version>3.0-b07</v3-docs.version>
        <l10n.version>3.0-b70</l10n.version>
        + <asm.version>3.1</asm.version>
        </properties>

        @@ -910,6 +911,12 @@
        <version>1.2.0</version>
        </dependency>
        <dependency>
        + <groupId>org.apache.felix</groupId>
        + <artifactId>org.apache.felix.main</artifactId>
        + <version>1.0.3</version>
        + </dependency>
        +
        + <dependency>
        <groupId>org.osgi</groupId>
        <artifactId>osgi_R4_core</artifactId>
        <version>1.0</version>
        @@ -1125,8 +1132,19 @@
        <groupId>com.sun.corba</groupId>
        <artifactId>glassfish-corba-asm</artifactId>
        <version>$

        {glassfish-corba.version}</version>
        - </dependency>
        + </dependency>
        <dependency>
        + <groupId>com.sun.corba</groupId>
        + <artifactId>glassfish-corba-csiv2-idl</artifactId>
        + <version>${glassfish-corba.version}

        </version>
        + </dependency>
        + <dependency>
        + <groupId>com.sun.corba</groupId>
        + <artifactId>glassfish-corba-newtimer</artifactId>
        + <version>$

        {glassfish-corba.version}

        </version>
        + </dependency>
        +
        + <dependency>
        <groupId>org.kohsuke.metainf-services</groupId>
        <artifactId>metainf-services</artifactId>
        <version>1.1</version>
        @@ -1262,6 +1280,11 @@
        <version>$

        {jstl-api.version}

        </version>
        </dependency>
        <dependency>
        + <groupId>org.glassfish.web</groupId>
        + <artifactId>jstl-impl</artifactId>
        + <version>$

        {jstl-impl.version}

        </version>
        + </dependency>
        + <dependency>
        <groupId>javax.xml</groupId>
        <artifactId>jaxrpc-api</artifactId>
        <version>$

        {jaxrpc-api.version}

        </version>
        @@ -1272,6 +1295,32 @@
        <version>$

        {saaj-api.version}

        </version>
        </dependency>

        + <dependency>
        + <groupId>org.glassfish</groupId>
        + <artifactId>genericra</artifactId>
        + <version>2.0-20081121</version>
        + </dependency>
        + <dependency>
        + <groupId>com.sun.scn</groupId>
        + <artifactId>sysnet-registration</artifactId>
        + <version>1.0.2</version>
        + </dependency>
        + <dependency>
        + <groupId>com.sun</groupId>
        + <artifactId>ldapbp</artifactId>
        + <version>1.0</version>
        + </dependency>
        + <dependency>
        + <groupId>commons-codec</groupId>
        + <artifactId>commons-codec</artifactId>
        + <version>20041127.091804</version>
        + </dependency>
        + <dependency>
        + <groupId>asm</groupId>
        + <artifactId>asm-commons</artifactId>
        + <version>$

        {asm.version}

        </version>
        + </dependency>
        +
        </dependencies>
        </dependencyManagement>
        <!-- End: Dependency management -->

        Show
        janey added a comment - Add more to dependencyManagement. Index: pom.xml =============================================================== ==== — pom.xml (revision 34382) +++ pom.xml (working copy) @@ -159,6 +159,7 @@ <opendmk.version>1.0-b01-ea</opendmk.version> <v3-docs.version>3.0-b07</v3-docs.version> <l10n.version>3.0-b70</l10n.version> + <asm.version>3.1</asm.version> </properties> @@ -910,6 +911,12 @@ <version>1.2.0</version> </dependency> <dependency> + <groupId>org.apache.felix</groupId> + <artifactId>org.apache.felix.main</artifactId> + <version>1.0.3</version> + </dependency> + + <dependency> <groupId>org.osgi</groupId> <artifactId>osgi_R4_core</artifactId> <version>1.0</version> @@ -1125,8 +1132,19 @@ <groupId>com.sun.corba</groupId> <artifactId>glassfish-corba-asm</artifactId> <version>$ {glassfish-corba.version}</version> - </dependency> + </dependency> <dependency> + <groupId>com.sun.corba</groupId> + <artifactId>glassfish-corba-csiv2-idl</artifactId> + <version>${glassfish-corba.version} </version> + </dependency> + <dependency> + <groupId>com.sun.corba</groupId> + <artifactId>glassfish-corba-newtimer</artifactId> + <version>$ {glassfish-corba.version} </version> + </dependency> + + <dependency> <groupId>org.kohsuke.metainf-services</groupId> <artifactId>metainf-services</artifactId> <version>1.1</version> @@ -1262,6 +1280,11 @@ <version>$ {jstl-api.version} </version> </dependency> <dependency> + <groupId>org.glassfish.web</groupId> + <artifactId>jstl-impl</artifactId> + <version>$ {jstl-impl.version} </version> + </dependency> + <dependency> <groupId>javax.xml</groupId> <artifactId>jaxrpc-api</artifactId> <version>$ {jaxrpc-api.version} </version> @@ -1272,6 +1295,32 @@ <version>$ {saaj-api.version} </version> </dependency> + <dependency> + <groupId>org.glassfish</groupId> + <artifactId>genericra</artifactId> + <version>2.0-20081121</version> + </dependency> + <dependency> + <groupId>com.sun.scn</groupId> + <artifactId>sysnet-registration</artifactId> + <version>1.0.2</version> + </dependency> + <dependency> + <groupId>com.sun</groupId> + <artifactId>ldapbp</artifactId> + <version>1.0</version> + </dependency> + <dependency> + <groupId>commons-codec</groupId> + <artifactId>commons-codec</artifactId> + <version>20041127.091804</version> + </dependency> + <dependency> + <groupId>asm</groupId> + <artifactId>asm-commons</artifactId> + <version>$ {asm.version} </version> + </dependency> + </dependencies> </dependencyManagement> <!-- End: Dependency management -->
        Hide
        janey added a comment -

        There are other artifacts that have versions specified in the submodule pom.xml files since they are
        either plugin and extension artifacts or dependencies specified in the configuration element of a
        plugin. Also I found out I can't use dependencyManagement when the dependency is either a pom, rar
        or zip type.

        Example: add the mq-distribution artifact in dependencyManagement in v3/pom.xml and remove
        version element for mq-distribution artifact in v3/packager/mq/pom.xml and the build will fail.

        I have taken care of most of the dependencies in v3 workspace but don't think I can take care of all the
        dependencies because of the above issues mentioned.

        I will leave this bug open but mark as v3_exclude and revisit this after v3.

        Show
        janey added a comment - There are other artifacts that have versions specified in the submodule pom.xml files since they are either plugin and extension artifacts or dependencies specified in the configuration element of a plugin. Also I found out I can't use dependencyManagement when the dependency is either a pom, rar or zip type. Example: add the mq-distribution artifact in dependencyManagement in v3/pom.xml and remove version element for mq-distribution artifact in v3/packager/mq/pom.xml and the build will fail. I have taken care of most of the dependencies in v3 workspace but don't think I can take care of all the dependencies because of the above issues mentioned. I will leave this bug open but mark as v3_exclude and revisit this after v3.
        Hide
        kumara added a comment -

        Setting target release for unresolved issues submitted on v3 release to the next release. Not changing
        issues submitted on v2.x release because they might not apply to v3.next release.

        Show
        kumara added a comment - Setting target release for unresolved issues submitted on v3 release to the next release. Not changing issues submitted on v2.x release because they might not apply to v3.next release.
        Hide
        janey added a comment -

        I'm closing this bug since majority of the dependencies in v3 workspace are adding to v3/pom.xml's
        dependencyManagement (other than the exceptions I mentioned in the earlier comment).

        Show
        janey added a comment - I'm closing this bug since majority of the dependencies in v3 workspace are adding to v3/pom.xml's dependencyManagement (other than the exceptions I mentioned in the earlier comment).

          People

          • Assignee:
            janey
            Reporter:
            Sanjeeb Sahoo
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: