glassfish
  1. glassfish
  2. GLASSFISH-10524

change/remove printd messages from all classes in flashlight

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Critical Critical
    • Resolution: Fixed
    • Affects Version/s: V3
    • Fix Version/s: V3
    • Component/s: monitoring
    • Labels:
      None
    • Environment:

      Operating System: All
      Platform: Sun

    • Issuezilla Id:
      10,524

      Description

      It has been noticed that performance is impacted by the usage of printd in the
      source code within flashlight and related packages. To start with we need to
      change these calls into log messages or remove them appropriately.

      For ex.

      Attr. Excl. Incl. Name
      User CPU User CPU User CPU
      sec. sec. sec.
      432.823 982.687 2679.564
      org.glassfish.flashlight.provider.FlashlightProbe.fireProbe(java.lang.Object[])
      3.773 55.769 429.661
      org.apache.jsp.purchase_jsp._jspService(javax.servlet.http.HttpServletRequest,
      javax.servlet.http.HttpServletResponse)
      0.590 1.721 47.023
      org.apache.jsp.dealerinventory_jsp._jspService(javax.servlet.http.HttpServletRequest,
      javax.servlet.http.HttpServletResponse)
      0.360 0.240 1.261
      com.sun.messaging.jmq.jmsserver.core.Session.<init>(com.sun.messaging.jmq.jmsserver.core.SessionUID,
      com.sun.messaging.jmq.jmsserver.service.ConnectionUID, java.lang.String)
      0.320 0.220 0.600
      com.sun.messaging.jmq.jmsserver.core.Producer.<init>(com.sun.messaging.jmq.jmsserver.service.ConnectionUID,
      com.sun.messaging.jmq.jmsserver.core.DestinationUID)
      0.320 0.080 0.420
      com.sun.messaging.jmq.jmsserver.core.Producer.toString()
      0.110 0.180 1.231
      com.sun.messaging.jmq.jmsserver.core.Destination.addProducer(com.sun.messaging.jmq.jmsserver.core.Producer)
      0.110 0.120 0.520 com.sun.messaging.jmq.jmsserver.core.Session.close()
      0.070 6008.043 6008.043 <Total>
      0.070 0.110 0.290
      com.sun.enterprise.naming.impl.SerialContext.<init>(java.lang.String,
      java.util.Hashtable, org.jvnet.hk2.component.Habitat)
      0.040 0. 0.040
      com.sun.enterprise.connectors.util.SetMethodAction.getMutatorMethod(java.lang.String,
      java.lang.Class)
      0.020 0.190 5.494
      org.apache.jsp.order_jsp._jspService(javax.servlet.http.HttpServletRequest,
      javax.servlet.http.HttpServletResponse)
      0.010 0.010 0.721
      com.sun.enterprise.resource.naming.AdministeredObjectFactory.getObjectInstance(java.lang.Object,
      javax.naming.Name, javax.naming.Context, java.util.Hashtable)
      0.010 0.140 0.560
      com.sun.messaging.jmq.jmsserver.service.imq.IMQDirectService.createDestination(long,
      com.sun.messaging.jmq.jmsservice.Destination)
      8.146 8.146 438.627 *java.lang.StringBuilder.append(java.lang.Object)
      348.844 43.701 362.283 java.lang.String.valueOf(java.lang.Object)
      81.637 2.602 139.618 java.lang.StringBuilder.append(java.lang.String)

      public void fireProbe(Object[] params) {
      if(!listenerEnabled.get())
      return;

      Set<Map.Entry<Integer, ProbeClientInvoker>> entries = invokers.entrySet();

      for (Map.Entry<Integer, ProbeClientInvoker> entry : entries)

      { ProbeClientInvoker invoker = entry.getValue(); printd ("+++++++++++++++++ Invoking probe: " + entry.getKey()); if(invoker != null) invoker.invoke(params); }

      }

        Activity

        Hide
        abbagani added a comment -

        Fixed all printd's in Flashlight and monitoring infrastructure.

        Show
        abbagani added a comment - Fixed all printd's in Flashlight and monitoring infrastructure.

          People

          • Assignee:
            abbagani
            Reporter:
            msreddy
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: