glassfish
  1. glassfish
  2. GLASSFISH-10646

redundant processing for setting low/high watermarks

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: V3
    • Fix Version/s: V3
    • Component/s: web_container
    • Labels:
      None
    • Environment:

      Operating System: All
      Platform: Sun

    • Issuezilla Id:
      10,646

      Description

      Perhaps this was done earlier, before the StatistcisImpl code was refactored.

      I see that the following classes do set the lowWaterMark and highWaterMark which
      is already done by corresponding StatistcisImpl as part of setting current value
      or count, pl. see
      http://kenai.com/projects/gmbal/sources/gf_common/show/src/org/glassfish/external/statistics/impl?rev=36

      ./SessionStatsProvider.java:
      activeSessionsCount.getHighWaterMark()) {
      ./SessionStatsProvider.java: activeSessionsCount.setHighWaterMark(
      ./SessionStatsProvider.java: activeSessionsCount.setLowWaterMark(0L);
      ./SessionStatsProvider.java: activeSessionsCount.setHighWaterMark(0L);
      ./ServletStatsProvider.java: activeServletsLoadedCount.setLowWaterMark(0L);
      ./ServletStatsProvider.java: activeServletsLoadedCount.setHighWaterMark(0L);
      ./JspStatsProvider.java:
      activeJspsLoadedCount.getHighWaterMark()) {
      ./JspStatsProvider.java: activeJspsLoadedCount.setHighWaterMark(
      ./JspStatsProvider.java: activeJspsLoadedCount.setLowWaterMark(0L);
      ./JspStatsProvider.java: activeJspsLoadedCount.setHighWaterMark(0L);

      Pl. modifiy the code approproately which will help in improving v3 performance.

        Activity

        Hide
        jluehe added a comment -

        Shing Wai, can you please take a look?

        Show
        jluehe added a comment - Shing Wai, can you please take a look?
        Hide
        Shing Wai Chan added a comment -

        v3/web/admin/src/main/java/org/glassfish/web/admin/monitor
        Sending JspStatsProvider.java
        Sending ServletStatsProvider.java
        Sending SessionStatsProvider.java
        Sending TimeStatData.java
        Transmitting file data ....
        Committed revision 33536.

        Show
        Shing Wai Chan added a comment - v3/web/admin/src/main/java/org/glassfish/web/admin/monitor Sending JspStatsProvider.java Sending ServletStatsProvider.java Sending SessionStatsProvider.java Sending TimeStatData.java Transmitting file data .... Committed revision 33536.

          People

          • Assignee:
            Shing Wai Chan
            Reporter:
            msreddy
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: