glassfish
  1. glassfish
  2. GLASSFISH-1171

Make ddl generation default mode consistent

    Details

    • Type: Bug Bug
    • Status: Open
    • Priority: Minor Minor
    • Resolution: Unresolved
    • Affects Version/s: 9.0pe
    • Fix Version/s: not determined
    • Component/s: entity-persistence
    • Labels:
      None
    • Environment:

      Operating System: All
      Platform: All

    • Issuezilla Id:
      1,171
    • Status Whiteboard:
      Hide

      HIGH

      Show
      HIGH

      Description

      Currently TopLink's ddlGeneration mode is different when running with
      createEntityManagerFactory than it is for createContinerEntityManagerFactory.

      DEFAULT_DDL_GENERATION_MODE = DDL_SQL_SCRIPT_GENERATION

      This default mode was set in the early days of the GlassFish integration before
      the createContainerEntityManagerFactory(PersistenceUnitInfo info, Map
      properties) had a map of properties available.

      When running with createEntityManagerFactory() we override the default by
      setting an inSEMode flag and when running in SE mode, we effectively use:
      DDL_BOTH_GENERATION

      We need to remove the inSEMode flag and always use the setting provided to
      TopLink.

      We should also change the default to: DDL_DATABASE_GENERATION since this will
      allow most users to work by default.

      In order for GlassFish DDL generation to continue to work, GlassFish will have
      to pass the toplink.ddl-generation.output-mode=sql-script to the properties map
      provided in createContainerEntityManagerFactory(). A separate bug will be
      filed for that issue and it will be linked to this one.

        Issue Links

          Activity

          Hide
          Tom Mueller added a comment -

          Bulk change to set fix version to "not determined" where the issue is open but the value is for a released version.

          Show
          Tom Mueller added a comment - Bulk change to set fix version to "not determined" where the issue is open but the value is for a released version.
          Hide
          pkrogh added a comment -

          Reprioritized based on BUG triage. P4 HIGH.

          Show
          pkrogh added a comment - Reprioritized based on BUG triage. P4 HIGH.
          Hide
          bpasero added a comment -

          adding myself to cc

          Show
          bpasero added a comment - adding myself to cc
          Hide
          ijuma added a comment -

          Adding myself to cc list.

          Show
          ijuma added a comment - Adding myself to cc list.
          Hide
          sherryshen added a comment -

          add myself to cc

          Show
          sherryshen added a comment - add myself to cc
          Hide
          tware added a comment -

          depends on issue 1172

          Show
          tware added a comment - depends on issue 1172
          Hide
          tware added a comment -

          added dependancy

          Show
          tware added a comment - added dependancy
          Hide
          tware added a comment -

          Forgot to set to NEW

          This is a bug rather than an enhancement becausse the current way it works is
          very confusing.

          Show
          tware added a comment - Forgot to set to NEW This is a bug rather than an enhancement becausse the current way it works is very confusing.

            People

            • Assignee:
              tware
              Reporter:
              tware
            • Votes:
              4 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated: