glassfish
  1. glassfish
  2. GLASSFISH-11797

OSGi/HHTP Service incorrectly populates initParams in ServletConfig

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: v3.0.1
    • Fix Version/s: v3.0.1
    • Component/s: OSGi-JavaEE
    • Labels:
      None
    • Environment:

      Operating System: All
      Platform: All

    • Issuezilla Id:
      11,797

      Description

      The following patch pretty much explains the bug:

      Index:
      /home/ss141213/WS/gf/v3/osgi-javaee/osgi-http/src/main/java/org/glassfish/osgihttp/OSGiServletConfig.java
      ===================================================================

      /home/ss141213/WS/gf/v3/osgi-javaee/osgi-http/src/main/java/org/glassfish/osgihttp/OSGiServletConfig.java
      (revision 36452)
      +++
      /home/ss141213/WS/gf/v3/osgi-javaee/osgi-http/src/main/java/org/glassfish/osgihttp/OSGiServletConfig.java
      (working copy)
      @@ -61,8 +61,9 @@
      if (initParams != null) {
      Enumeration e = initParams.keys();
      while (e.hasMoreElements())

      { - this.initParams.put((String) e.nextElement(), - (String) initParams.get(e)); + final Object key = e.nextElement(); + this.initParams.put((String) key, + (String) initParams.get(key)); }

      }
      }

      We need this to be fixed in 3.0.1. I came across this while helping a vaadin
      user use GlassFish [1].

      [1]
      http://vaadin.com/forum/-/message_boards/message/137711;jsessionid=4ED5C6E6085E81A459A5D4831A2475DF#_19_message_137981

        Activity

        Hide
        Sanjeeb Sahoo added a comment -

        Fixing it in trunk:
        Sending
        home/ss141213/WS/gf/v3/osgi-javaee/osgi-http/src/main/java/org/glassfish/osgihttp/OSGiServletConfig.java
        Transmitting file data .
        Committed revision 36472.

        Will wait for approval from Abhijit before commiting in 3.0.1.

        Show
        Sanjeeb Sahoo added a comment - Fixing it in trunk: Sending home/ss141213/WS/gf/v3/osgi-javaee/osgi-http/src/main/java/org/glassfish/osgihttp/OSGiServletConfig.java Transmitting file data . Committed revision 36472. Will wait for approval from Abhijit before commiting in 3.0.1.
        Hide
        Sanjeeb Sahoo added a comment -

        Now fixing in 3.0.1 branch:
        Sending osgi-http/src/main/java/org/glassfish/osgihttp/OSGiServletConfig.java
        Transmitting file data .
        Committed revision 36483.

        Show
        Sanjeeb Sahoo added a comment - Now fixing in 3.0.1 branch: Sending osgi-http/src/main/java/org/glassfish/osgihttp/OSGiServletConfig.java Transmitting file data . Committed revision 36483.

          People

          • Assignee:
            Sanjeeb Sahoo
            Reporter:
            Sanjeeb Sahoo
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: