glassfish
  1. glassfish
  2. GLASSFISH-12023

CONFIG-008: cluster config without cluster software

    Details

    • Type: New Feature New Feature
    • Status: Resolved
    • Priority: Blocker Blocker
    • Resolution: Fixed
    • Affects Version/s: 3.1
    • Fix Version/s: 3.1_ms04
    • Component/s: admin
    • Labels:
      None
    • Environment:

      Operating System: All
      Platform: All

    • Issuezilla Id:
      12,023

      Description

      See: http://wiki.glassfish.java.net/Wiki.jsp?page=3.1Config

      This feature is for making sure that even if the cluster software is not
      installed, any cluster config information that might be in the domain.xml file
      is still handled. This is essentially a testing feature. The following scenario
      must work:

      1. Install Glassfish (with the clustering software)
      2. Create some clusters and instances
      3. Delete the clustering software
      4. Ensure that the DAS can still start and operate normally
      5. Ensure that the instances cannot be started and the cluster configuration
      cannot be changed (because the commands are not there).

        Issue Links

          Activity

          Hide
          Bhakti Mehta added a comment -

          I have tried the following
          1.Created 2 clusters and 1 instance
          2.removed the following jars
          cluster-admin.jar cluster-cli.jar cluster-common.jar console-cluster-plugin.jar
          3.restarted domain
          4.DAS comes up fine
          For commands which have been created using the config api like create/delete
          cluster, delete-nodes-ssh , list-nodes decorators the command fails and spits
          the usage, for commands which implement Admin command it will fail with command
          not found)

          5./asadmin create-cluster bar (It spits up the usage and fails even though I am
          using the right usage)
          remote failure: Usage: create-cluster [--properties=properties]
          [--systemproperties=systemproperties] [--multicastport=multicastport]
          [--multicastaddress=multicastaddress] [--config=config] name

          Command create-cluster failed.
          6../asadmin list-nodes
          remote failure: Usage: list-nodes

          Command list-nodes failed.
          7../asadmin start-instance qq
          Command start-instance not found
          Command start-instance failed.
          8../asadmin list-clusters
          Command list-clusters not found
          Command list-clusters failed.

          Show
          Bhakti Mehta added a comment - I have tried the following 1.Created 2 clusters and 1 instance 2.removed the following jars cluster-admin.jar cluster-cli.jar cluster-common.jar console-cluster-plugin.jar 3.restarted domain 4.DAS comes up fine For commands which have been created using the config api like create/delete cluster, delete-nodes-ssh , list-nodes decorators the command fails and spits the usage, for commands which implement Admin command it will fail with command not found) 5./asadmin create-cluster bar (It spits up the usage and fails even though I am using the right usage) remote failure: Usage: create-cluster [--properties=properties] [--systemproperties=systemproperties] [--multicastport=multicastport] [--multicastaddress=multicastaddress] [--config=config] name Command create-cluster failed. 6../asadmin list-nodes remote failure: Usage: list-nodes Command list-nodes failed. 7../asadmin start-instance qq Command start-instance not found Command start-instance failed. 8../asadmin list-clusters Command list-clusters not found Command list-clusters failed.
          Hide
          Tom Mueller added a comment -

          It seems that giving a usage error for those commands is not the right behavior,
          because it doesn't give the user any clue that the software isn't actually
          installed. What is probably happening is that the remote command is failing
          because of an exception in resolving the dependencies that the command has. The
          command framework should be catching that exception and returning that information
          back to asadmin, which should then report a message saying that the software
          needed to run this command is not installed.

          Show
          Tom Mueller added a comment - It seems that giving a usage error for those commands is not the right behavior, because it doesn't give the user any clue that the software isn't actually installed. What is probably happening is that the remote command is failing because of an exception in resolving the dependencies that the command has. The command framework should be catching that exception and returning that information back to asadmin, which should then report a message saying that the software needed to run this command is not installed.
          Hide
          Bhakti Mehta added a comment -

          I have committed the following changes. This will fix the NPE in the response
          for commands also now create-cluster will fail since it relies on copy-config
          and that cannot be found

          Discussed with Jerome and there will a possibility we will be making more
          changes like profile or moving over config api

          Author: bhaktimehta
          Date: 2010-08-12 21:01:56+0000
          New Revision: 39655

          Modified:

          trunk/v3/admin/config-api/src/main/java/com/sun/enterprise/config/serverbeans/Cluster.java

          trunk/v3/admin/config-api/src/main/java/com/sun/enterprise/config/serverbeans/LocalStrings.properties

          trunk/v3/core/kernel/src/main/java/com/sun/enterprise/v3/admin/CommandRunnerImpl.java

          Show
          Bhakti Mehta added a comment - I have committed the following changes. This will fix the NPE in the response for commands also now create-cluster will fail since it relies on copy-config and that cannot be found Discussed with Jerome and there will a possibility we will be making more changes like profile or moving over config api Author: bhaktimehta Date: 2010-08-12 21:01:56+0000 New Revision: 39655 Modified: trunk/v3/admin/config-api/src/main/java/com/sun/enterprise/config/serverbeans/Cluster.java trunk/v3/admin/config-api/src/main/java/com/sun/enterprise/config/serverbeans/LocalStrings.properties trunk/v3/core/kernel/src/main/java/com/sun/enterprise/v3/admin/CommandRunnerImpl.java
          Hide
          Bhakti Mehta added a comment -

          Also made the delete commands fail if the cluster software is not installed,
          will be revisted either by profiles or moving the code to cluster jars as part
          of issue 12900
          svn rev 39805

          Show
          Bhakti Mehta added a comment - Also made the delete commands fail if the cluster software is not installed, will be revisted either by profiles or moving the code to cluster jars as part of issue 12900 svn rev 39805
          Hide
          Bhakti Mehta added a comment -

          Marking as fixed resolved. The cluster commands show up in list commands and
          that will be addressed with issue 12900

          Show
          Bhakti Mehta added a comment - Marking as fixed resolved. The cluster commands show up in list commands and that will be addressed with issue 12900

            People

            • Assignee:
              Bhakti Mehta
              Reporter:
              Tom Mueller
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: