Issue Details (XML | Word | Printable)

Key: GLASSFISH-12052
Type: New Feature New Feature
Status: Resolved Resolved
Resolution: Fixed
Priority: Critical Critical
Assignee: Byron Nevins
Reporter: Tom Mueller
Votes: 0
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
glassfish

Resolve issue with delete-instance/delete-local-instance

Created: 26/May/10 02:45 PM   Updated: 01/Jun/10 04:08 PM   Resolved: 01/Jun/10 04:08 PM
Component/s: admin
Affects Version/s: 3.1
Fix Version/s: 3.1_ms02

Time Tracking:
Not Specified

Environment:

Operating System: All
Platform: All


Issuezilla Id: 12,052
Tags:
Participants: Byron Nevins and Tom Mueller


 Description  « Hide

As of MS1, delete-instance and delete-local-instance are implemented as synonyms.

This issue is to confirm whether or not this is the right behavior and once it
is decided what the right behavior is, implement it.

Proposal 1: leave it as it is. delete-instance and delete-local-instance do the
same thing when the identified instance is on the local host. If you run
delete-instance on an instance that is not local, it fails.

Proposal 2 (from Bill):
I expected delete-local-instance to work like create-local-instance -
do the local filesystem part and contact the DAS to do the config part.

Similarly, delete-instance would be like create-instance - a remote
command that asks DAS to do the config part and (eventually) contact
the remote node to do the filesystem part.

Here "eventually" would be via the ssh feature that will be provided later.



Byron Nevins added a comment - 01/Jun/10 02:19 PM

Proposal 2 has been chosen.


Byron Nevins added a comment - 01/Jun/10 02:29 PM

here is how it works:

1) asadmin delete-instance
– CLI calls DAS to run the command. Currently DAS removes the instance from
the config. Sometime in the not too distant future DAS will call asadmin on the
remote machine like so "asadmin delete-local-instance --filesystemonly"

2) asadmin delete-local-instance
It makes sure the instance isn't running. Then it deletes all the files
belonging to the instance. If --filesysytemonly is true it is finished.
Otherwise it calls 'delete-instance' on DAS to wipe out the instance from the
config.


Byron Nevins added a comment - 01/Jun/10 04:08 PM

C:\gf\v3\cluster\cli>svn commit
Deleting
cli\src\main\java\com\sun\enterprise\admin\cli\cluster\DeleteInstanceCommand.java

Committed revision 37390.