glassfish
  1. glassfish
  2. GLASSFISH-12264

[Release Note]Samples. at ant all output was seen URL for samples that don't have a web client

    Details

    • Type: Bug Bug
    • Status: Open
    • Priority: Major Major
    • Resolution: Unresolved
    • Affects Version/s: v3.0.1
    • Fix Version/s: not determined
    • Component/s: sample_apps
    • Labels:
      None
    • Environment:

      Operating System: Windows Vista
      Platform: All

      Description

      OS: Solaris Sparc, build: SDK build 21. Samples.
      At the output from "ant all" for many apps that don't have a web client at all,
      for example criteriaQuery or hello-jaxws2.2, was seen URL under deploy-url-
      message. i.e. "Application deployed at htt://localhost:8080/... "

      I think that users should not see such misleading messages

        Activity

        Hide
        scatari added a comment -

        The top level app-server-ant.xml that does the "deploy" of applications blindly calls this target that
        displays the message "Application deployed at <URL>".

        The fix would be to display this message only when the sample has an accessible web client URL. This
        would require identifying such samples as part of the individual sample build system through setting a
        flag, something like "hasWebURL=true/false".

        Better yet do not display anything for now even for the applications that can be accessed through web.
        Anyhow, the URLs are part of the sample docs.

        Show
        scatari added a comment - The top level app-server-ant.xml that does the "deploy" of applications blindly calls this target that displays the message "Application deployed at <URL>". The fix would be to display this message only when the sample has an accessible web client URL. This would require identifying such samples as part of the individual sample build system through setting a flag, something like "hasWebURL=true/false". Better yet do not display anything for now even for the applications that can be accessed through web. Anyhow, the URLs are part of the sample docs.
        Hide
        scatari added a comment -

        <exec executable="$

        {asadmin}

        " failonerror="$

        {failonerror}

        ">
        <arg line=" deploy "/>
        <arg line=" --user $

        {javaee.server.username}

        " />
        <arg line=" --passwordfile '$

        {javaee.server.passwordfile}

        '" />
        <arg line=" --host $

        {javaee.server.name}

        " />
        <arg line=" --port $

        {javaee.adminserver.port}

        " />
        <arg line=" --name $

        {module.name}

        "/>
        <arg line=" --force=true "/>
        <arg line=" --upload=true "/>
        <arg line=" --dbvendorname $

        {db.vendorname}

        "/>
        <arg line=" --property compatibility=v2"/>
        <arg line="$

        {app.module}

        " />
        </exec>
        <antcall target="deploy-url-message"/>
        </target>

        <target name="deploy-url-message" if="app.url">
        <echo message="Application Deployed at: $

        {app.url}

        "/>
        </target>

        Show
        scatari added a comment - <exec executable="$ {asadmin} " failonerror="$ {failonerror} "> <arg line=" deploy "/> <arg line=" --user $ {javaee.server.username} " /> <arg line=" --passwordfile '$ {javaee.server.passwordfile} '" /> <arg line=" --host $ {javaee.server.name} " /> <arg line=" --port $ {javaee.adminserver.port} " /> <arg line=" --name $ {module.name} "/> <arg line=" --force=true "/> <arg line=" --upload=true "/> <arg line=" --dbvendorname $ {db.vendorname} "/> <arg line=" --property compatibility=v2"/> <arg line="$ {app.module} " /> </exec> <antcall target="deploy-url-message"/> </target> <target name="deploy-url-message" if="app.url"> <echo message="Application Deployed at: $ {app.url} "/> </target>
        Hide
        scatari added a comment -

        This would need fix across samples, targeting for 3.2. Will have to Release Note considering the less
        impact on users, transferring to Doc.

        Scott,
        Please assign as appropriate.

        Show
        scatari added a comment - This would need fix across samples, targeting for 3.2. Will have to Release Note considering the less impact on users, transferring to Doc. Scott, Please assign as appropriate.
        Hide
        Paul Davies added a comment -

        Added 3.1-release-notes to indicate the issue should be documented in the
        Release Notes.

        Reset the subcomponent to sample_apps to enable any possible future code fix to
        be tracked.

        Show
        Paul Davies added a comment - Added 3.1-release-notes to indicate the issue should be documented in the Release Notes. Reset the subcomponent to sample_apps to enable any possible future code fix to be tracked.
        Hide
        Paul Davies added a comment -

        Reassigned to owner of selected subcomponent. No need to assign it to the RN
        writer, as the 3.1-release-notes keyword indicates that this issue is to be
        documented in the RN.

        Show
        Paul Davies added a comment - Reassigned to owner of selected subcomponent. No need to assign it to the RN writer, as the 3.1-release-notes keyword indicates that this issue is to be documented in the RN.
        Hide
        Nazrul added a comment -

        Will be release noted by documentation team. Excluding from 3.1 bug count.

        Show
        Nazrul added a comment - Will be release noted by documentation team. Excluding from 3.1 bug count.
        Hide
        Scott Fordin added a comment -

        Need more info to add issue to 3.1 Release Notes.

        Show
        Scott Fordin added a comment - Need more info to add issue to 3.1 Release Notes.
        Hide
        easarina added a comment -

        I did not try to run this test against latest builds. But the general idea, for apps that don't have a web client, users have to ignore this message and don't use the URL.

        Show
        easarina added a comment - I did not try to run this test against latest builds. But the general idea, for apps that don't have a web client, users have to ignore this message and don't use the URL.
        Hide
        Scott Fordin added a comment -

        Added issue to 3.1 Release Notes.

        Show
        Scott Fordin added a comment - Added issue to 3.1 Release Notes.
        Hide
        Tom Mueller added a comment -

        Bulk update to change fix version to "not determined" for all issues still open but with a fix version for a released version.

        Show
        Tom Mueller added a comment - Bulk update to change fix version to "not determined" for all issues still open but with a fix version for a released version.

          People

          • Assignee:
            scatari
            Reporter:
            easarina
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated: