glassfish
  1. glassfish
  2. GLASSFISH-12568

JDBC resource need to allow system property for pool name

    Details

    • Type: Improvement Improvement
    • Status: Open
    • Priority: Critical Critical
    • Resolution: Unresolved
    • Affects Version/s: 3.1
    • Fix Version/s: None
    • Component/s: jdbc
    • Labels:
      None
    • Environment:

      Operating System: All
      Platform: All

    • Issuezilla Id:
      12,568

      Description

      In the JDBC resource screen, the connection pool is a drop down list.
      This means user cannot use system properties ie, token to specify a pool name. eg $

      {PoolName}

      To support such use case, the dropdown needs to be a 'combo box', allowing user to select from
      dropdown or enter the pool name. Client side validation should ensure that it starts with "${"

      Currently, CLI allows that.
      This will be JDBC enhancement.

        Activity

        Hide
        Shalini added a comment -

        This needs to be done for Connector Connection pools also.

        Show
        Shalini added a comment - This needs to be done for Connector Connection pools also.
        Hide
        sumasri added a comment -

        Added the target milestone.

        Show
        sumasri added a comment - Added the target milestone.
        Hide
        sumasri added a comment -

        -> MS7

        Show
        sumasri added a comment - -> MS7
        Hide
        sumasri added a comment -

        In V2.1 also, There is no way to add a system property as pool name through GUI.
        Steps to do it in CLI is,
        1)Create a node agent na.
        2)Create a cluster(c1).
        3)Create an instance(i1) under cluster c1 with the node agent na.
        4)start the node agent(na).
        5)Create a system property(Ex: poolname=DerbyPool) with the target as c1.
        6)Create a jdbc resource using the target c1 and pool name as "$

        {poolname}".
        command : asadmin create-jdbc-resource --connectionpoolid "\${poolname}

        " --target c1 jdbc1.

        But, In v3.1, there is no support for start-node-agent. Through CLI, it is not supporting system property for jdbc resource creation.
        Steps to reproduce the issue.
        1)Create a cluster
        2)Create an instance(i1) under cluster c1 with the node agent localhost.
        3)Start the cluster
        4)Create a system property(Ex: poolname=DerbyPool) with the target as c1.
        5)./bin/asadmin create-jdbc-resource --connectionpoolid "\$

        {poolname}" --target c1 j1
        org.glassfish.api.admin.CommandException: remote failure: Attribute value (pool-name = ${poolname}

        ) is not found in list of jdbc connection pools.
        Command create-jdbc-resource failed.

        Transferring it to the backend team to look into the issue. Please transfer it to me for GUI support once you are done with the backend changes.

        Show
        sumasri added a comment - In V2.1 also, There is no way to add a system property as pool name through GUI. Steps to do it in CLI is, 1)Create a node agent na. 2)Create a cluster(c1). 3)Create an instance(i1) under cluster c1 with the node agent na. 4)start the node agent(na). 5)Create a system property(Ex: poolname=DerbyPool) with the target as c1. 6)Create a jdbc resource using the target c1 and pool name as "$ {poolname}". command : asadmin create-jdbc-resource --connectionpoolid "\${poolname} " --target c1 jdbc1. But, In v3.1, there is no support for start-node-agent. Through CLI, it is not supporting system property for jdbc resource creation. Steps to reproduce the issue. 1)Create a cluster 2)Create an instance(i1) under cluster c1 with the node agent localhost. 3)Start the cluster 4)Create a system property(Ex: poolname=DerbyPool) with the target as c1. 5)./bin/asadmin create-jdbc-resource --connectionpoolid "\$ {poolname}" --target c1 j1 org.glassfish.api.admin.CommandException: remote failure: Attribute value (pool-name = ${poolname} ) is not found in list of jdbc connection pools. Command create-jdbc-resource failed. Transferring it to the backend team to look into the issue. Please transfer it to me for GUI support once you are done with the backend changes.

          People

          • Assignee:
            Shalini
            Reporter:
            Anissa Lam
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated: