glassfish
  1. glassfish
  2. GLASSFISH-12817

provide --target support for set command

    Details

    • Type: New Feature New Feature
    • Status: Resolved
    • Priority: Blocker Blocker
    • Resolution: Fixed
    • Affects Version/s: 3.1
    • Fix Version/s: 3.1_ms04
    • Component/s: admin
    • Labels:
      None
    • Environment:

      Operating System: All
      Platform: All

    • Issuezilla Id:
      12,817

      Description

      This issue is for implementing command replication support for the set command.

      The problem is the set command does not have a target. The target is derived
      from the operands of the command and the replication framework will not be aware
      of the targets. So there is no way for the framework to know where to send the
      commands to. So just as deploy command, set also is a special case. It should be
      executed only on DAS and once it is done on DAS, the command impl itself should
      decide on replication targets and invoke some hidden command in the instances to
      do the set there.

      Because of this special treatment for set, Bill and Jerome want to be sure that
      things will work - just as we did for deployment special case.

        Issue Links

          Activity

          Hide
          vijaysr added a comment -

          Taking ownership

          Show
          vijaysr added a comment - Taking ownership
          Hide
          Hong Zhang added a comment -

          One additional note: we need to decide what we will do for the set commands
          with the top level elements. For example, setting the enabled attribute of the
          application element to false in v2 will disable the application in all
          referenced targets. Does that mean we should replicate the set command to all
          instances which have the reference of this application?

          Show
          Hong Zhang added a comment - One additional note: we need to decide what we will do for the set commands with the top level elements. For example, setting the enabled attribute of the application element to false in v2 will disable the application in all referenced targets. Does that mean we should replicate the set command to all instances which have the reference of this application?
          Hide
          vijaysr added a comment -

          asadmin set commands are replicated as applicable / required depending on the name value pair.

          If an attribute for some resource is changed, then it is broadcast to all instances.

          If an attribute for an application is changed, then it is replicated to all instances where the

          Show
          vijaysr added a comment - asadmin set commands are replicated as applicable / required depending on the name value pair. If an attribute for some resource is changed, then it is broadcast to all instances. If an attribute for an application is changed, then it is replicated to all instances where the
          Hide
          vijaysr added a comment -

          asadmin set commands are replicated as applicable / required depending on the name value pair.

          If an attribute for some resource is changed, then it is broadcast to all instances.

          If an attribute for an application is changed, then it is replicated to all instances where the app has a ref

          For all other attributes (configs.config.x-config or servers.server.y or nodes.node.z), the target is
          derived from and replicated as applicable.

          As for all commands, the command is executed on DAS and, if that succeeds, only then it is replicated
          (if required).

          Show
          vijaysr added a comment - asadmin set commands are replicated as applicable / required depending on the name value pair. If an attribute for some resource is changed, then it is broadcast to all instances. If an attribute for an application is changed, then it is replicated to all instances where the app has a ref For all other attributes (configs.config.x-config or servers.server.y or nodes.node.z), the target is derived from and replicated as applicable. As for all commands, the command is executed on DAS and, if that succeeds, only then it is replicated (if required).

            People

            • Assignee:
              vijaysr
              Reporter:
              Tom Mueller
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: