glassfish
  1. glassfish
  2. GLASSFISH-13632

Deployment - location cleared on any error

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 3.1
    • Fix Version/s: 3.1_ms07
    • Component/s: admin_gui
    • Labels:
      None
    • Environment:

      Operating System: All
      Platform: All

      Description

      build: glassfish-3.1-b22-09_27_2010.zip

      1. Go to applications node, click on Deploy.
      2. Select "Local Packaged File or Directory That Is Accessible from the 3.
      Enterprise Server" for location and choose an expanded application on server.
      Click OK, even though the type has not been selected - there is no popup
      warning, only Type is displayed in red now (there should be a consistent
      behaviour across Admin Console for incorrectly filled up forms - i.e. we should
      always display a popup or an error messsage on the page).
      3. Select Type and click OK - this time a popup informs that Location cannot be
      blank. All the application details are still filled in, only location has been
      cleared. We should not clear the application location.
      4. Click ok on the popup - the Browse Files and Browse Folders buttons are
      grayed out, so user cannot select the location directory. One has to select the
      other radio button first and then click radio button next to "Local Packaged
      File or Directory That Is Accessible from the Enterprise Server" again to get
      those buttons active again.
      5. Select the deployment directory again - now Type got reset again...

      I was able to do directory deployment to server and standalone instance, while
      that fails in v2 with the following error:

      Trying to create reference for application in target sin1 failed; Directory
      deployment is not supported for non-DAS target. Directory deployment is not
      supported for non-DAS target.

      Not sure if we now support it in V3.1.

      1. deploy-directory1.JPG
        71 kB
      2. deploy-directory2.JPG
        52 kB
      3. deploy-directory3.JPG
        79 kB
      4. deploy-directory3.JPG
        79 kB

        Activity

        Hide
        lidiam added a comment -

        Created an attachment (id=4970)
        screenshot

        Show
        lidiam added a comment - Created an attachment (id=4970) screenshot
        Hide
        lidiam added a comment -

        Created an attachment (id=4971)
        screenshot

        Show
        lidiam added a comment - Created an attachment (id=4971) screenshot
        Hide
        lidiam added a comment -

        Created an attachment (id=4972)
        screenshot

        Show
        lidiam added a comment - Created an attachment (id=4972) screenshot
        Hide
        lidiam added a comment -

        Created an attachment (id=4973)
        screenshot

        Show
        lidiam added a comment - Created an attachment (id=4973) screenshot
        Hide
        Anissa Lam added a comment -

        I have cleaned up deployment client side validation. It testes for

        • specifying location
        • specifying Type
        • Application Name
        • No target specified in an cluster env.

        in the above order.

        All the above will be validated before submitted to deployment. So, hopefully it is less chance for
        the page to clear out like you seeing now.

        However, if there is error in the actual deployment, like file not found, already deployed etc. The
        page will be refreshed with location field cleared out. The (text field and browse button) is actually
        one component, there is no way to just fill that value back in. This is limitation in Woodstock,
        probably due to security reasons.

        We have to leave it like this for the location clear out.

        Fix should be available on 11/7 nightly.

        Show
        Anissa Lam added a comment - I have cleaned up deployment client side validation. It testes for specifying location specifying Type Application Name No target specified in an cluster env. in the above order. All the above will be validated before submitted to deployment. So, hopefully it is less chance for the page to clear out like you seeing now. However, if there is error in the actual deployment, like file not found, already deployed etc. The page will be refreshed with location field cleared out. The (text field and browse button) is actually one component, there is no way to just fill that value back in. This is limitation in Woodstock, probably due to security reasons. We have to leave it like this for the location clear out. Fix should be available on 11/7 nightly.
        Hide
        lidiam added a comment -

        Verified in promoted build b43 on Mac.

        Show
        lidiam added a comment - Verified in promoted build b43 on Mac.

          People

          • Assignee:
            Anissa Lam
            Reporter:
            lidiam
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: