glassfish
  1. glassfish
  2. GLASSFISH-13653

exceptions during cluster upgrade of non-DAS config

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 3.1
    • Fix Version/s: 3.1_ms07
    • Component/s: admin_gui
    • Labels:
      None
    • Environment:

      Operating System: All
      Platform: All

      Description

      The fix for issue 13443 produces exceptions during upgrade when handling config
      elements besides <server-config>. Root cause is that it fails for any config
      that does not contain an admin listener. So I think I should skip these configs,
      but am checking to make sure that's the case.

      Proposed patch in core/kernel:

      hostname% svn diff
      Index: src/main/java/com/sun/enterprise/v3/admin/AdminConsoleConfigUpgrade.java
      ===================================================================
      — src/main/java/com/sun/enterprise/v3/admin/AdminConsoleConfigUpgrade.java
      (revision 41183)
      +++ src/main/java/com/sun/enterprise/v3/admin/AdminConsoleConfigUpgrade.java
      (working copy)
      @@ -86,6 +86,27 @@
      @Override
      public void postConstruct() {
      for (Config config : configs.getConfig()) {
      + // we only want to handle configs that have an admin listener
      + try {
      + if (config.getAdminListener() == null)

      { + EarlyLogger.add(Level.FINE, String.format( + "Skipping config %s. No admin listener.", + config.getName())); + continue; + }

      + } catch (IllegalStateException ise)

      { + /* + * I've only seen the exception rather than + * getAdminListener returning null. This should + * typically happen for any config besides + * <server-config>, but we'll proceed if any + * config has an admin listener. + */ + EarlyLogger.add(Level.FINE, String.format( + "Skipping config %s. getAdminListener threw: %s", + config.getName(), ise.getLocalizedMessage())); + continue; + }

      SecurityService s = config.getSecurityService();
      if (s == null) {
      continue;

      Sure, the check for null above never happens, but that doesn't mean it never
      will.....

        Activity

        Hide
        Bobby Bissett added a comment -

        Adding some people to the CC list who probably have better things to do....

        Show
        Bobby Bissett added a comment - Adding some people to the CC list who probably have better things to do....
        Hide
        kenpaulsen added a comment -

        Looks good! Thanks for catching this. -Ken

        Show
        kenpaulsen added a comment - Looks good! Thanks for catching this. -Ken
        Hide
        Bobby Bissett added a comment -

        Fixed in revision 41196. Thanks for the quick review.

        Show
        Bobby Bissett added a comment - Fixed in revision 41196. Thanks for the quick review.
        Hide
        adf59 added a comment -

        Created an attachment (id=5522)
        server.log from GlassFish 3.1 b30 showing exception

        Show
        adf59 added a comment - Created an attachment (id=5522) server.log from GlassFish 3.1 b30 showing exception
        Hide
        adf59 added a comment -

        Disregard previous attachment (wrong issue #) ...

        Show
        adf59 added a comment - Disregard previous attachment (wrong issue #) ...

          People

          • Assignee:
            Bobby Bissett
            Reporter:
            Bobby Bissett
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: