glassfish
  1. glassfish
  2. GLASSFISH-13760

hardcode string for command 'create-iiop-listener' and 'delete-iiop-listener'

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Incomplete
    • Affects Version/s: 3.1
    • Fix Version/s: 3.1_ms07
    • Component/s: orb
    • Labels:
      None
    • Environment:

      Operating System: All
      Platform: All

    • Issuezilla Id:
      13,760

      Description

      There have some hardcoded strings for command 'create-iiop-listener' and
      'delete-iiop-listener':

      asadmin> create-iiop-listener --listeneraddress 0.0.0.0 --iiopport 1401
      iiop_listener_2
      IIOP Listener iiop_listener_2 created.

      -hard coded in
      orb/orb-connector/src/main/java/org/glassfish/orb/admin/cli/CreateIiopListener.java

      asadmin> delete-iiop-listener iiop_listener_2
      IIOP Listener iiop_listener_2 deleted.

      -hard coded in
      orb/orb-connector/src/main/java/org/glassfish/orb/admin/cli/DeleteIiopListener.java

        Activity

        Hide
        Tom Mueller added a comment -

        Note that according to the new command output guidelines, commands should not
        output confirmation messages in addition to the one output by asadmin unless they
        add additional information, which these messages do not. So the fix should be to
        omit the messages.

        See: http://wikis.sun.com/display/GlassFish/Asadmin+Command+Output+Guidelines

        Show
        Tom Mueller added a comment - Note that according to the new command output guidelines, commands should not output confirmation messages in addition to the one output by asadmin unless they add additional information, which these messages do not. So the fix should be to omit the messages. See: http://wikis.sun.com/display/GlassFish/Asadmin+Command+Output+Guidelines
        Hide
        Ken Cavanaugh added a comment -

        All that I see currently in the create/delete commands is the
        default "Command xxx executed successfully.". I am closing this.

        Show
        Ken Cavanaugh added a comment - All that I see currently in the create/delete commands is the default "Command xxx executed successfully.". I am closing this.
        Hide
        Ken Cavanaugh added a comment -

        Moving to ORB component.

        Show
        Ken Cavanaugh added a comment - Moving to ORB component.

          People

          • Assignee:
            Ken Cavanaugh
            Reporter:
            leonfan
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: