glassfish
  1. glassfish
  2. GLASSFISH-13996

[PERF] Copyobject fails on long linked structures

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Blocker Blocker
    • Resolution: Works as designed
    • Affects Version/s: 3.1
    • Fix Version/s: 4.0_b61
    • Component/s: orb
    • Labels:
      None
    • Environment:

      Operating System: All
      Platform: Sun

      Description

      The copyobject implementation currently has problems with LinkedLists and
      similar data structures. The recursive traversal of such objects can cause
      stack overflows if the linked lists are long enough (generally a few thousand
      elements will cause this problem).

      This issue proposes an enhancement to fix this behavior by moving to a
      non-recursive worklist algorithm for traversing all object graphs.

        Issue Links

          Activity

          Hide
          Scott Oaks added a comment -

          The current handling of linked lists is also quite a performance penalty.

          Show
          Scott Oaks added a comment - The current handling of linked lists is also quite a performance penalty.
          Hide
          Scott Oaks added a comment -

          ...

          Show
          Scott Oaks added a comment - ...
          Hide
          Nazrul added a comment -

          This is an important performance fix needed for this release. Refer to 13573.

          Show
          Nazrul added a comment - This is an important performance fix needed for this release. Refer to 13573.
          Hide
          Ken Cavanaugh added a comment -

          Assuming that this issue is fixed in the current build (which I believe it is)
          by using the Map copier on LinkedHashMap, I am changing this to an
          enhancement and moving it to the next release. There is not enough time
          remaining to do this for 3.1.

          Show
          Ken Cavanaugh added a comment - Assuming that this issue is fixed in the current build (which I believe it is) by using the Map copier on LinkedHashMap, I am changing this to an enhancement and moving it to the next release. There is not enough time remaining to do this for 3.1.
          Hide
          Harshad Vilekar added a comment -

          I believe this issue is already resolved, since the dependent issue 13573 is closed. No further action is planned on this issue.

          Show
          Harshad Vilekar added a comment - I believe this issue is already resolved, since the dependent issue 13573 is closed. No further action is planned on this issue.

            People

            • Assignee:
              Harshad Vilekar
              Reporter:
              Ken Cavanaugh
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: