glassfish
  1. glassfish
  2. GLASSFISH-1400

CMP codegen should allow mediated writes

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 9.1pe
    • Fix Version/s: 9.1pe_dev
    • Component/s: cmp
    • Labels:
      None
    • Environment:

      Operating System: All
      Platform: All

    • Issuezilla Id:
      1,400

      Description

      CMP will often have better performance if mediated writes are used for the fields.

        Activity

        Hide
        mf125085 added a comment -

        The runtime changes have been checked in:

        http://fisheye5.cenqua.com/changelog/glassfish/?cs=MAIN:mf125085:20061106204053

        Now, we need to change CMP code-gen.

        Show
        mf125085 added a comment - The runtime changes have been checked in: http://fisheye5.cenqua.com/changelog/glassfish/?cs=MAIN:mf125085:20061106204053 Now, we need to change CMP code-gen.
        Hide
        marina vatkina added a comment -

        To do mediate write for fields in DFG in CMP generated _JDOState instances,
        added support for -DAllowMediatedWriteInDefaultFetchGroup flag. When set to true
        in the domain.xml the EJBMetaDataModelImpl will return true for CHECK_READ |
        MEDIATE_WRITE for fields in DFG, and the existing logic will generate the
        correct code.

        An outstanding question of making the same changes in the generic class
        JDOMetaDataPropertyImpl can be resolved separately, so checking in the current
        fix, but not yet marking the issue as fixed.

        Checking in
        support/ejb/src/com/sun/jdo/spi/persistence/support/ejb/enhancer/meta/EJBMetaDataModelImpl.java;
        /cvs/glassfish/cmp/support/ejb/src/com/sun/jdo/spi/persistence/support/ejb/enhancer/meta/EJBMetaDataModelImpl.java,v
        <-- EJBMetaDataModelImpl.java
        new revision: 1.3; previous revision: 1.2
        done

        Show
        marina vatkina added a comment - To do mediate write for fields in DFG in CMP generated _JDOState instances, added support for -DAllowMediatedWriteInDefaultFetchGroup flag. When set to true in the domain.xml the EJBMetaDataModelImpl will return true for CHECK_READ | MEDIATE_WRITE for fields in DFG, and the existing logic will generate the correct code. An outstanding question of making the same changes in the generic class JDOMetaDataPropertyImpl can be resolved separately, so checking in the current fix, but not yet marking the issue as fixed. Checking in support/ejb/src/com/sun/jdo/spi/persistence/support/ejb/enhancer/meta/EJBMetaDataModelImpl.java; /cvs/glassfish/cmp/support/ejb/src/com/sun/jdo/spi/persistence/support/ejb/enhancer/meta/EJBMetaDataModelImpl.java,v <-- EJBMetaDataModelImpl.java new revision: 1.3; previous revision: 1.2 done
        Hide
        marina vatkina added a comment -

        Submitted a separate issue for the changes in the base class:
        https://glassfish.dev.java.net/issues/show_bug.cgi?id=1477

        Show
        marina vatkina added a comment - Submitted a separate issue for the changes in the base class: https://glassfish.dev.java.net/issues/show_bug.cgi?id=1477

          People

          • Assignee:
            marina vatkina
            Reporter:
            Scott Oaks
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: