glassfish
  1. glassfish
  2. GLASSFISH-14059

list-components, list-applications and list-application-refs output could be more user friendly

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 3.1
    • Fix Version/s: 4.0_b59
    • Component/s: deployment
    • Labels:
      None
    • Environment:

      Operating System: All
      Platform: Macintosh

    • Issuezilla Id:
      14,059

      Description

      Used latest 3.1 nightly b24 dated Oct 16th, 2010

      To reproduce,
      1. Start domain
      2. create a cluster of two or more instances, and start it.
      3. deploy any application to the cluster (in my example I used clusterjsp with availabilityenabled=true)
      4. asadmin list-applications - shows Nothing to list
      5. asadmin list-application-refs - shows Nothing to list

      Sample output from my deployment :
      dhcp-santaclara22-1fl-west-10-132-181-151:bin shreed$ ./asadmin deploy –
      availabilityenabled=true --target shreedhar-cluster
      ~/glassfish/samples/quickstart/clusterjsp/clusterjsp.ear
      Application deployed with name clusterjsp.

      Command deploy executed successfully.
      dhcp-santaclara22-1fl-west-10-132-181-151:bin shreed$ ./asadmin list-applications
      Nothing to list.

      Command list-applications executed successfully.
      dhcp-santaclara22-1fl-west-10-132-181-151:bin shreed$ ./asadmin list-application-refs
      Nothing to list.

      Command list-application-refs executed successfully.
      dhcp-santaclara22-1fl-west-10-132-181-151:bin shreed$

        Activity

        Hide
        shreedhar_ganapathy added a comment -

        Created an attachment (id=5161)
        Domain xml attached for reference

        Show
        shreedhar_ganapathy added a comment - Created an attachment (id=5161) Domain xml attached for reference
        Hide
        Tom Mueller added a comment -

        The default target for the list-applications command is the DAS, i.e., "server".
        Did you try:

        asadmin list-applications shreedhar-cluster

        ?

        Show
        Tom Mueller added a comment - The default target for the list-applications command is the DAS, i.e., "server". Did you try: asadmin list-applications shreedhar-cluster ?
        Hide
        shreedhar_ganapathy added a comment -

        I tried
        ./asadmin list-applications --target shreedhar-cluster
        assuming that the --target would be more consistent with commands involving targets
        That obviously failed but I just tried what you've suggested :
        ./asadmin list-applications shreedhar-cluster
        That worked :

        dhcp-santaclara22-1fl-west-10-132-181-151:bin shreed$ ./asadmin list-applications shreedhar-
        cluster
        ShoppingCart <web>
        clusterjsp <ear, web>

        Seems like a usability gap in that there is no obvious information from the command when executed as
        is. Aren't all applications deployed to the domain regardless of what target they are ultimately deployed
        to? It'd be nice to have this command show deployed apps with their targets

        Aside, I expected list application refs to provide references to the app in the domain.

        Show
        shreedhar_ganapathy added a comment - I tried ./asadmin list-applications --target shreedhar-cluster assuming that the --target would be more consistent with commands involving targets That obviously failed but I just tried what you've suggested : ./asadmin list-applications shreedhar-cluster That worked : dhcp-santaclara22-1fl-west-10-132-181-151:bin shreed$ ./asadmin list-applications shreedhar- cluster ShoppingCart <web> clusterjsp <ear, web> Seems like a usability gap in that there is no obvious information from the command when executed as is. Aren't all applications deployed to the domain regardless of what target they are ultimately deployed to? It'd be nice to have this command show deployed apps with their targets Aside, I expected list application refs to provide references to the app in the domain.
        Hide
        Hong Zhang added a comment -

        If you want to list all the applications deployed to this domain, you need to
        use the "domain" target:

        asadmin list-components domain

        As Tom said, the default target is DAS (the DAS target means the default server
        instance, not the domain).

        This syntax is used in v2 and the previous releases.

        Show
        Hong Zhang added a comment - If you want to list all the applications deployed to this domain, you need to use the "domain" target: asadmin list-components domain As Tom said, the default target is DAS (the DAS target means the default server instance, not the domain). This syntax is used in v2 and the previous releases.
        Hide
        shreedhar_ganapathy added a comment -

        Hong, Tom
        Based on your feedback I have marked this as an enhancement. IMO the command output could give a bit
        more specific info that there is no app deployed 'to the domain' or perhaps a hint that components/apps
        could be found on other targets.

        Show
        shreedhar_ganapathy added a comment - Hong, Tom Based on your feedback I have marked this as an enhancement. IMO the command output could give a bit more specific info that there is no app deployed 'to the domain' or perhaps a hint that components/apps could be found on other targets.
        Hide
        Hong Zhang added a comment -

        target for 3.2

        Show
        Hong Zhang added a comment - target for 3.2
        Hide
        Tom Mueller added a comment -

        Marking the fix version field as "future-release". This is based on an evaluation by John, Michael, and Tom WRT to the PRD for the Java EE 7 RI/SDK. This issues was deemed to not be a P1 for that release. If this is in error or there are other reasons why this RFE should be targeted for the Java EE 7 RI/SDK release, then change the fix version field back to an appropriate build.

        Show
        Tom Mueller added a comment - Marking the fix version field as "future-release". This is based on an evaluation by John, Michael, and Tom WRT to the PRD for the Java EE 7 RI/SDK. This issues was deemed to not be a P1 for that release. If this is in error or there are other reasons why this RFE should be targeted for the Java EE 7 RI/SDK release, then change the fix version field back to an appropriate build.
        Hide
        Jeremy_Lv added a comment -

        Hong:

        Hong, Tom
        Based on your feedback I have marked this as an enhancement. IMO the command output could give a bit
        more specific info that there is no app deployed 'to the domain' or perhaps a hint that components/apps
        could be found on other targets.

        shall we add some infos about this phenomenon in the latest trunk?

        for example:
        >asadmin list-applications
        There is no applications REF by server
        Nothing to list
        Command list-applications executed successfully

        BTW, I will look into it if it is needed to be add some infos.
        IMO, I think it is no need to mark it as an enhancement in JIRA but add some description in the document about deployment to let the user know the default target value is server in the version of GFV4.

        Show
        Jeremy_Lv added a comment - Hong: Hong, Tom Based on your feedback I have marked this as an enhancement. IMO the command output could give a bit more specific info that there is no app deployed 'to the domain' or perhaps a hint that components/apps could be found on other targets. shall we add some infos about this phenomenon in the latest trunk? for example: >asadmin list-applications There is no applications REF by server Nothing to list Command list-applications executed successfully BTW, I will look into it if it is needed to be add some infos. IMO, I think it is no need to mark it as an enhancement in JIRA but add some description in the document about deployment to let the user know the default target value is server in the version of GFV4.
        Hide
        Hong Zhang added a comment -

        It's already in the documentation that the default target is server, but I guess users don't always read documentation.

        I guess the additional message will help "No applications are deployed to this target <target name>".

        Show
        Hong Zhang added a comment - It's already in the documentation that the default target is server, but I guess users don't always read documentation. I guess the additional message will help "No applications are deployed to this target <target name>".
        Hide
        Jeremy_Lv added a comment -

        try to add some messages about some related list commands and have attached my revised source to the JIRA. pls check it.

        Show
        Jeremy_Lv added a comment - try to add some messages about some related list commands and have attached my revised source to the JIRA. pls check it.
        Hide
        Hong Zhang added a comment -

        Changes look pretty good. Please go ahead and check in after running the usual set of the tests.

        Show
        Hong Zhang added a comment - Changes look pretty good. Please go ahead and check in after running the usual set of the tests.
        Hide
        Jeremy_Lv added a comment -

        Run all of the QL tests and dev tests and all of them have passed.
        Sending E:\GF_MAIN\SOURCE_1017\nucleus\deployment\admin\src\main\java\org\glassfish\deployment\admin\ListApplicationRefsCommand.java
        Sending E:\GF_MAIN\SOURCE_1017\nucleus\deployment\admin\src\main\java\org\glassfish\deployment\admin\ListComponentsCommand.java
        Sending E:\GF_MAIN\SOURCE_1017\nucleus\deployment\admin\src\main\java\org\glassfish\deployment\admin\LocalStrings.property
        Transmitting file data .
        Committed revision 56684.

        Show
        Jeremy_Lv added a comment - Run all of the QL tests and dev tests and all of them have passed. Sending E:\GF_MAIN\SOURCE_1017\nucleus\deployment\admin\src\main\java\org\glassfish\deployment\admin\ListApplicationRefsCommand.java Sending E:\GF_MAIN\SOURCE_1017\nucleus\deployment\admin\src\main\java\org\glassfish\deployment\admin\ListComponentsCommand.java Sending E:\GF_MAIN\SOURCE_1017\nucleus\deployment\admin\src\main\java\org\glassfish\deployment\admin\LocalStrings.property Transmitting file data . Committed revision 56684.

          People

          • Assignee:
            Jeremy_Lv
            Reporter:
            shreedhar_ganapathy
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: