glassfish
  1. glassfish
  2. GLASSFISH-14515

[UB]Restart not required for changes in resources

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 3.1
    • Fix Version/s: 3.1_ms08
    • Component/s: docs
    • Labels:
      None
    • Environment:

      Operating System: All
      Platform: All

    • Issuezilla Id:
      14,515

      Description

      build: ogs-3.1-b28-11_08_2010.zip

      According to http://docs.sun.com/app/docs/doc/821-1751/gitzw, restart will be
      required if the following are modified for a JDBC connection pool:

      datasource-classname
      associate-with-thread
      lazy-connection-association
      lazy-connection-enlistment
      JDBC driver vendor-specific properties

      I changed the first 3 entries in Admin Console for Derby connection pool and
      restart was not indicated as required by neither Admin Console nor CLI
      (list-domains). I checked domain.xml and the entries were there. The vendor
      specific properties are listed under Additional Properties and making changes to
      those does not trigger restart required either.

      Hence it looks like documentation should be changed, cc'ing Jagadish and Anissa
      to be sure.

        Activity

        Hide
        lidiam added a comment -

        I just changed resource adapter in a connector connection pool I created and
        again restart is not required and changes make it to the domain.xml.
        Documentation claims that changes to the following properties of connector
        connection pool should require restart:

        resource-adapter-name
        connection-definition-name
        transaction-support
        associate-with-thread
        lazy-connection-association
        lazy-connection-enlistment
        Vendor-specific properties

        Show
        lidiam added a comment - I just changed resource adapter in a connector connection pool I created and again restart is not required and changes make it to the domain.xml. Documentation claims that changes to the following properties of connector connection pool should require restart: resource-adapter-name connection-definition-name transaction-support associate-with-thread lazy-connection-association lazy-connection-enlistment Vendor-specific properties
        Hide
        lidiam added a comment -

        None of the connector connection pool changes seem to require restart from testing.

        Show
        lidiam added a comment - None of the connector connection pool changes seem to require restart from testing.
        Hide
        Anissa Lam added a comment -

        I think Jagadish should review the doc and gives feedback.
        It shouldn't be relying on what the user see to update the doc. We don't know what we observe is
        correct or if thats what backend intended.

        Show
        Anissa Lam added a comment - I think Jagadish should review the doc and gives feedback. It shouldn't be relying on what the user see to update the doc. We don't know what we observe is correct or if thats what backend intended.
        Hide
        lidiam added a comment -

        Reassigning to Jagadish for evaluation.

        Show
        lidiam added a comment - Reassigning to Jagadish for evaluation.
        Hide
        Jagadish added a comment -

        I guess, the text was written in the context of multiple applications using a
        connection pool.

        Any one of the following options should work after changing the "properties"
        (any of the properties of pool) and few "attributes" of connection-pool (jdbc as
        well connector) as listed in the current docs.
        http://docs.sun.com/app/docs/doc/821-1751/gitzw

        1) Disable and Enable application that is using the resource/pool
        2) Redeploy the application that is using the resource/pool.
        3) Restart the server if multiple applications are using the pool (If its
        difficult to enable and disable each application).

        Probably, we need another section in "Impact of Configuration Changes"
        (administration guide)
        to explain about "re-enabling" / "re-deploying" the applications referring the
        pool and resource.

        Show
        Jagadish added a comment - I guess, the text was written in the context of multiple applications using a connection pool. Any one of the following options should work after changing the "properties" (any of the properties of pool) and few "attributes" of connection-pool (jdbc as well connector) as listed in the current docs. http://docs.sun.com/app/docs/doc/821-1751/gitzw 1) Disable and Enable application that is using the resource/pool 2) Redeploy the application that is using the resource/pool. 3) Restart the server if multiple applications are using the pool (If its difficult to enable and disable each application). Probably, we need another section in "Impact of Configuration Changes" (administration guide) to explain about "re-enabling" / "re-deploying" the applications referring the pool and resource.
        Hide
        Paul Davies added a comment -

        [UB]: Affects unbundled documentation.

        Reassigned to oncered, who owns the connectors documentation.

        Show
        Paul Davies added a comment - [UB] : Affects unbundled documentation. Reassigned to oncered, who owns the connectors documentation.
        Hide
        Scott Fordin added a comment -

        Added topic under "Restart Required" umbrella issue (http://java.net/jira/browse/GLASSFISH-16040) in 3.1 Release Notes.

        Show
        Scott Fordin added a comment - Added topic under "Restart Required" umbrella issue ( http://java.net/jira/browse/GLASSFISH-16040 ) in 3.1 Release Notes.
        Hide
        Mike Fitch added a comment -

        Resolving as fixed due to this issue's inclusion in the Release Notes, as per Scott Fordin's comment of 18/Mar/11 01:27 PM.

        Show
        Mike Fitch added a comment - Resolving as fixed due to this issue's inclusion in the Release Notes, as per Scott Fordin's comment of 18/Mar/11 01:27 PM.
        Hide
        lidiam added a comment -
        Show
        lidiam added a comment - Documented in 3.1.1 Release Notes ( http://download.oracle.com/docs/cd/E18930_01/html/821-2434/ggrvi.html#gkusy ).

          People

          • Assignee:
            Mike Fitch
            Reporter:
            lidiam
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: