glassfish
  1. glassfish
  2. GLASSFISH-14737

Node port number: indicate required fields for ssh node creation

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 3.1
    • Fix Version/s: 3.1_ms07
    • Component/s: admin
    • Labels:
      None
    • Environment:

      Operating System: All
      Platform: All

      Description

      build: ogs-3.1-b30-11_16_2010.zip

      Tried to create an SSH node. Since the only required fields seem to be node
      name and node host, erased all other entries. Got the following error after
      hitting OK to save:

      An error has occurred
      Warning: some parameters appear to be invalid. SSH node not created. To force
      creation of the node with these parameters rerun the command using the --force
      option. Invalid port number .

      Thus it seems that at least port number is a required field and should be marked
      in GUI as such.

        Activity

        Hide
        lidiam added a comment -

        Btw, the way the error message is displayed, it is easy to miss the actual
        reason for failure. Could it be printed on a separate line?

        Also, GUI should check that the value in this field is a positive integer before
        sending it off to backend.

        Show
        lidiam added a comment - Btw, the way the error message is displayed, it is easy to miss the actual reason for failure. Could it be printed on a separate line? Also, GUI should check that the value in this field is a positive integer before sending it off to backend.
        Hide
        Anissa Lam added a comment -

        The sshport is an optional parameter, thats the case for CLI as well.

        Usage: asadmin [asadmin-utility-options] create-node-ssh --nodehost <nodehost>
        [--installdir <installdir(default:$

        {com.sun.aas.productRoot}

        )>]
        [--nodedir <nodedir>] [--sshport <sshport(default:22)>]
        [--sshuser <sshuser(default:$

        {user.name}

        )>] [--sshkeyfile <sshkeyfile>]
        [-force[=<force(default:false)>]] [?|--help[=<help(default:false)>]]
        name

        I think the admin code should use the default when it is not specified.
        transferring to Joe.

        admin code should validate the port # as well if it is illegal char. Yes, GUI can check that on client
        side, but admin should do that as well, and user will see the error either way.

        Show
        Anissa Lam added a comment - The sshport is an optional parameter, thats the case for CLI as well. Usage: asadmin [asadmin-utility-options] create-node-ssh --nodehost <nodehost> [--installdir <installdir(default:$ {com.sun.aas.productRoot} )>] [--nodedir <nodedir>] [--sshport <sshport(default:22)>] [--sshuser <sshuser(default:$ {user.name} )>] [--sshkeyfile <sshkeyfile>] [- force [=<force(default:false)>] ] [ ?|--help [=<help(default:false)>] ] name I think the admin code should use the default when it is not specified. transferring to Joe. admin code should validate the port # as well if it is illegal char. Yes, GUI can check that on client side, but admin should do that as well, and user will see the error either way.
        Hide
        Joe Di Pol added a comment -

        I'm guessing this is a case where the GUI is sending a blank or null string for
        the port number when the field is erased. I can change create-node-ssh so that
        it detects this and uses the default.

        Show
        Joe Di Pol added a comment - I'm guessing this is a case where the GUI is sending a blank or null string for the port number when the field is erased. I can change create-node-ssh so that it detects this and uses the default.
        Hide
        Joe Di Pol added a comment -

        The port number, user name, and installation directory should now default
        correctly if the fields are cleared in the console.

        Author: jfdipol
        Date: 2010-11-18 23:59:42+0000
        New Revision: 42954

        Modified:

        trunk/v3/cluster/admin/src/main/java/com/sun/enterprise/v3/admin/cluster/CreateNodeSshCommand.java

        Log:
        14737 Node port number: indicate required fields for ssh node creation
        create-node-ssh now detects when an empty string is passed as a
        parameter and uses the default value in that case.

        Show
        Joe Di Pol added a comment - The port number, user name, and installation directory should now default correctly if the fields are cleared in the console. Author: jfdipol Date: 2010-11-18 23:59:42+0000 New Revision: 42954 Modified: trunk/v3/cluster/admin/src/main/java/com/sun/enterprise/v3/admin/cluster/CreateNodeSshCommand.java Log: 14737 Node port number: indicate required fields for ssh node creation create-node-ssh now detects when an empty string is passed as a parameter and uses the default value in that case.
        Hide
        lidiam added a comment -

        Verified in promoted build b43.

        Show
        lidiam added a comment - Verified in promoted build b43.

          People

          • Assignee:
            Joe Di Pol
            Reporter:
            lidiam
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: