glassfish
  1. glassfish
  2. GLASSFISH-15289

Regression in create instance and a better error message needed

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Cannot Reproduce
    • Affects Version/s: 3.1_b33
    • Fix Version/s: 4.1
    • Component/s: admin
    • Labels:
      None
    • Environment:

      build: ogs-3.1-b34-12_20_2010.zip

      Description

      In Admin Console create a CONFIG type node filling out the required fields only. Go to Standalone Instances page and click new. Attempt to create an instance using the newly created node and the following error is displayed:

      An error has occurred
      Node conf-node does not have the nodehost attribute set and therefore create-instance can not be used with this node. You must either add the nodehost attribute using the update-node-config command, or create the instance by running create-local-instance directly on the instance host.

      The above used to work in earlier builds. If this regression cannot be fixed, we should at least tailor the error message towards the Admin Console users, since that's where it is displayed and tell them how to fix the problem in Admin Console alone (CLI information can be present additionally, if desired).

        Activity

        Hide
        carlavmott added a comment -

        Yes, things have changed and some changes were a result of Arch review and some were because validation was added for the offline scenario case.

        I take Joe's response to mean that we are not changing the back end because it is too risky but he doesn't see an issue with leaving the GUI screen as it is. Right now both nodehost and installdir are required but the underlying code even though in some cases it really is not necessary because we can figure out the value.

        I'm going to exclude this bug from 3.1 because we will not change the backend code.

        Show
        carlavmott added a comment - Yes, things have changed and some changes were a result of Arch review and some were because validation was added for the offline scenario case. I take Joe's response to mean that we are not changing the back end because it is too risky but he doesn't see an issue with leaving the GUI screen as it is. Right now both nodehost and installdir are required but the underlying code even though in some cases it really is not necessary because we can figure out the value. I'm going to exclude this bug from 3.1 because we will not change the backend code.
        Hide
        carlavmott added a comment -

        The scenario in this test was really not handled in 3.1. For 3.2 release I have added support to allow create-instance to create the instance config element when the node element doesn't have the nodehost or the installdir specified. The user will have to run create-local-instance to create the instance file system and that will also update the node element with the nodehost and installdir information. All other references to that node will also inherit the nodehost and installdir.

        This scenario is closest to what was supported in GlassFish v2 where the node agent provided the information at instance creation time if it didn't exist. See scenario 8 on the Instance Lifecycle Scenarios wiki page http://wikis.sun.com/display/GlassFish/3.1SSHScenarios

        Show
        carlavmott added a comment - The scenario in this test was really not handled in 3.1. For 3.2 release I have added support to allow create-instance to create the instance config element when the node element doesn't have the nodehost or the installdir specified. The user will have to run create-local-instance to create the instance file system and that will also update the node element with the nodehost and installdir information. All other references to that node will also inherit the nodehost and installdir. This scenario is closest to what was supported in GlassFish v2 where the node agent provided the information at instance creation time if it didn't exist. See scenario 8 on the Instance Lifecycle Scenarios wiki page http://wikis.sun.com/display/GlassFish/3.1SSHScenarios
        Hide
        carlavmott added a comment -

        nodehost and installdir no longer required when creating a config node

        Committed revision 44848.

        Still need to work on error message

        Show
        carlavmott added a comment - nodehost and installdir no longer required when creating a config node Committed revision 44848. Still need to work on error message
        Hide
        carlavmott added a comment -

        O plan to fix this for EE7 release. The only thing to do is to update the error message to include information on how to proceed in the GUI and don't plan on removing the instructions for the CLI. This fix will impact testing since they will need to verify.

        Show
        carlavmott added a comment - O plan to fix this for EE7 release. The only thing to do is to update the error message to include information on how to proceed in the GUI and don't plan on removing the instructions for the CLI. This fix will impact testing since they will need to verify.
        Hide
        carlavmott added a comment -

        I can not recreate this error condition as behavior has changed and the error message that was in question is no longer printed. Therefore I have nothing to change.

        Show
        carlavmott added a comment - I can not recreate this error condition as behavior has changed and the error message that was in question is no longer printed. Therefore I have nothing to change.

          People

          • Assignee:
            carlavmott
            Reporter:
            lidiam
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: