glassfish
  1. glassfish
  2. GLASSFISH-15458

Rewrite asadmin set, get, list subcommands with devtests

    Details

    • Type: Improvement Improvement
    • Status: Open
    • Priority: Critical Critical
    • Resolution: Unresolved
    • Affects Version/s: 3.1
    • Fix Version/s: future release
    • Component/s: admin
    • Labels:
      None

      Description

      During the 3.1 release, many bugs have been filed against the set, get, and list asadmin subcommands, especially the set command. There isn't any comprehensive developer test suite that tests the functionality of these commands. The manual page documentation doesn't specify the complete behavior of the commands. For example, for any particular attribute, there are two ways to specify the attribute, e.g.:

      configs.config.server-config.java-config.java-home

      or

      server-config.java-config.java-home

      but the dotted-name manual page doesn't mention this.

      One problem within the code is that the data structures that are manipulated by the commands are not precisely defined. For example, there is a method called V2DottedNameSupport.getAliasedParent, that returns a TreeNode array with name and relativeName members. However, the meaning of "name" and "relativeName" within that structure are not defined clearly, and depending on different situations, different values are returned.

      This enhancement request is meant to be an umbrella feature to request the rewriting of these commands and to identify specific bugs that need to be fixed as part of the rewrite. This work must also include developing a comprehensive developer test suite for list, get and set.

        Issue Links

          Activity

          Tom Mueller created issue -
          Tom Mueller made changes -
          Field Original Value New Value
          Link This issue depends on GLASSFISH-9489 [ GLASSFISH-9489 ]
          Tom Mueller made changes -
          Link This issue depends on GLASSFISH-15418 [ GLASSFISH-15418 ]
          Hide
          Tom Mueller added a comment -

          The DottedNamesObjectNames.htm file contains information from the AS8 release about the definition of dotted names. This should be helpful in reimplementing the set/get/list commands.

          Show
          Tom Mueller added a comment - The DottedNamesObjectNames.htm file contains information from the AS8 release about the definition of dotted names. This should be helpful in reimplementing the set/get/list commands.
          Tom Mueller made changes -
          Attachment Dotted Names and Object Names.htm [ 27527 ]
          Jennifer Chou made changes -
          Link This issue depends on GLASSFISH-6310 [ GLASSFISH-6310 ]
          Tom Mueller made changes -
          Link This issue blocks GLASSFISH-16165 [ GLASSFISH-16165 ]
          Jason Lee made changes -
          Link This issue blocks GLASSFISH-15731 [ GLASSFISH-15731 ]
          Tom Mueller made changes -
          Fix Version/s 3.2_ms05 [ 14747 ]
          Fix Version/s 3.2 [ 10969 ]
          Tom Mueller made changes -
          Fix Version/s 4.0 [ 10970 ]
          Tom Mueller made changes -
          Fix Version/s 3.2_ms05 [ 14747 ]
          Tom Mueller made changes -
          Assignee Tom Mueller [ tmueller ] zhouronghui [ zhouronghui ]
          Hide
          Tom Mueller added a comment -

          Marking the fix version field as "future-release". This is based on an evaluation by John, Michael, and Tom WRT to the PRD for the Java EE 7 RI/SDK. This issues was deemed to not be a P1 for that release. If this is in error or there are other reasons why this RFE should be targeted for the Java EE 7 RI/SDK release, then change the fix version field back to an appropriate build.

          Show
          Tom Mueller added a comment - Marking the fix version field as "future-release". This is based on an evaluation by John, Michael, and Tom WRT to the PRD for the Java EE 7 RI/SDK. This issues was deemed to not be a P1 for that release. If this is in error or there are other reasons why this RFE should be targeted for the Java EE 7 RI/SDK release, then change the fix version field back to an appropriate build.
          Tom Mueller made changes -
          Tags ee7ri_cleanup_deferred
          Fix Version/s future release [ 11148 ]
          Fix Version/s 4.0 [ 10970 ]

            People

            • Assignee:
              zhouronghui
              Reporter:
              Tom Mueller
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated: