glassfish
  1. glassfish
  2. GLASSFISH-15458

Rewrite asadmin set, get, list subcommands with devtests

    Details

    • Type: Improvement Improvement
    • Status: Open
    • Priority: Critical Critical
    • Resolution: Unresolved
    • Affects Version/s: 3.1
    • Fix Version/s: future release
    • Component/s: admin
    • Labels:
      None

      Description

      During the 3.1 release, many bugs have been filed against the set, get, and list asadmin subcommands, especially the set command. There isn't any comprehensive developer test suite that tests the functionality of these commands. The manual page documentation doesn't specify the complete behavior of the commands. For example, for any particular attribute, there are two ways to specify the attribute, e.g.:

      configs.config.server-config.java-config.java-home

      or

      server-config.java-config.java-home

      but the dotted-name manual page doesn't mention this.

      One problem within the code is that the data structures that are manipulated by the commands are not precisely defined. For example, there is a method called V2DottedNameSupport.getAliasedParent, that returns a TreeNode array with name and relativeName members. However, the meaning of "name" and "relativeName" within that structure are not defined clearly, and depending on different situations, different values are returned.

      This enhancement request is meant to be an umbrella feature to request the rewriting of these commands and to identify specific bugs that need to be fixed as part of the rewrite. This work must also include developing a comprehensive developer test suite for list, get and set.

        Issue Links

          Activity

          No work has yet been logged on this issue.

            People

            • Assignee:
              zhouronghui
              Reporter:
              Tom Mueller
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated: