glassfish
  1. glassfish
  2. GLASSFISH-15467

Recently added SDK sample (clusterjsp) is not complete. Missing ant targets to compile, package, run and cleanup

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 3.1_dev
    • Fix Version/s: 3.1.2_dev
    • Component/s: sample_apps
    • Labels:
      None
    • Environment:

      SDK build 35/36. Glassfish distribution

      Description

      Recently a new sample was added to the SDK distributions - clusterjsp, however, the contents of this sample are not consistent with the other samples. Clusterjsp is missing targets to compile, package, run and cleanup in build.xml.

      Given the timing of this release, the suggestion is that we remove this sample from the GF3.1 SDK distributions.

        Activity

        Hide
        Alex Pineda added a comment -

        Because you've added targets to this sample, I believe you need to update the Clusterjsp instructions located for example at /export/test/glassfish3/glassfish/samples/javaee/ha/clusterjsp/docs/index.html, and list the sequence of ant targets that showcase this sample. The current instructions are all manual and the point to the pre-compiled version of the sample (clusterjsp.ear).

        Show
        Alex Pineda added a comment - Because you've added targets to this sample, I believe you need to update the Clusterjsp instructions located for example at /export/test/glassfish3/glassfish/samples/javaee/ha/clusterjsp/docs/index.html, and list the sequence of ant targets that showcase this sample. The current instructions are all manual and the point to the pre-compiled version of the sample (clusterjsp.ear).
        Hide
        Romain Grécourt added a comment -

        What is the impact on the customer of the bug?

        User following instructions will not be able to run the sample.

        What is the cost/risk of fixing the bug?
        The fix is very simple: documenting the steps.

        Is there an impact on documentation or message strings?
        No.

        Which tests should QA (re)run to verify the fix did not destabilize GlassFish?
        Try to run the sample again.

        Which is the targeted build of 3.1.2 for this fix?
        b20.

        Show
        Romain Grécourt added a comment - What is the impact on the customer of the bug? User following instructions will not be able to run the sample. What is the cost/risk of fixing the bug? The fix is very simple: documenting the steps. Is there an impact on documentation or message strings? No. Which tests should QA (re)run to verify the fix did not destabilize GlassFish? Try to run the sample again. Which is the targeted build of 3.1.2 for this fix? b20.
        Hide
        Rebecca Parks added a comment -

        This issue has been removed from the list of 3.1.2 Release Note issues. I have no objection, I'm just curious why.

        Show
        Rebecca Parks added a comment - This issue has been removed from the list of 3.1.2 Release Note issues. I have no objection, I'm just curious why.
        Hide
        Romain Grécourt added a comment -

        I removed the release note tags because I thought that the fix will remove the need of a release note. Please feel free to put the tags back if you think it would still need a release note.

        Show
        Romain Grécourt added a comment - I removed the release note tags because I thought that the fix will remove the need of a release note. Please feel free to put the tags back if you think it would still need a release note.
        Hide
        Alex Pineda added a comment -

        A few of points

        1. We should remove this issue from the Release Notes, because the initial problem reported by me is now fixed.

        2. In the justification section, it says no impact to documentation, but that is not true. I pointed out that we need to update/edit the samples/javaee/ha/clusterjsp/docs/index.html and I believe this constitutes a change in the product and adds some risk if mistakes are made.

        3. It's not quite true that all QA has to do is run the sample again. The change will require that QA verify the instructions of how to build/compile/deploy the sample. So, there's a bit more impact on QA than stated.

        Show
        Alex Pineda added a comment - A few of points 1. We should remove this issue from the Release Notes, because the initial problem reported by me is now fixed. 2. In the justification section, it says no impact to documentation, but that is not true. I pointed out that we need to update/edit the samples/javaee/ha/clusterjsp/docs/index.html and I believe this constitutes a change in the product and adds some risk if mistakes are made. 3. It's not quite true that all QA has to do is run the sample again. The change will require that QA verify the instructions of how to build/compile/deploy the sample. So, there's a bit more impact on QA than stated.

          People

          • Assignee:
            Romain Grécourt
            Reporter:
            Alex Pineda
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: