Issue Details (XML | Word | Printable)

Key: GLASSFISH-15590
Type: Bug Bug
Status: Open Open
Priority: Major Major
Assignee: Byron Nevins
Reporter: Byron Nevins
Votes: 0
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
glassfish

Regular Expression Checking not working for calculated values

Created: 17/Jan/11 06:26 PM   Updated: 18/Feb/13 06:18 PM
Component/s: monitoring
Affects Version/s: 3.1
Fix Version/s: future release

Time Tracking:
Not Specified

Tags: 3_1_1-exclude 3_1_1-scrubbed 3_1_x-exclude
Participants: Byron Nevins and scatari


 Description  « Hide

D:\gf\v3\core\kernel>asadmin get -m server.applications.x.y\.z.server.jsp.servicetime-coun*
No monitoring data to report.

D:\gf\v3\core\kernel>asadmin get -m server.applications.x.y\.z.server.jsp.servicetime-count
server.applications.x\.y\.z.server.jsp.servicetime-count = 0

=======
The first command ought to work.



Byron Nevins added a comment - 17/Jan/11 06:28 PM

Another example:
========================
D:\gf\v3\core\kernel>asadmin get -m server.applications.x.y.z.server.jsp.servicetime*

server.applications.x\.y\.z.server.jsp.dotted-name =
// lots of output removed //

============
D:\gf\v3\core\kernel>asadmin get m server.applications.x.y.z.server.jsp.servicetime*
No monitoring data to report.


Byron Nevins added a comment - 22/Mar/11 09:37 AM

As you can see – the internal code is NOT looking at things as final strings and thus misses stuff.

Another Example

D:\>asadmin get -m server.applications.x\.y.server.jsp.servicetime*
server.applications.x\.y.server.jsp.dotted-name = server.applications.x\.y.server.jsp
server.applications.x\.y.server.jsp.servicetime-count = 0
server.applications.x\.y.server.jsp.servicetime-description = Aggregate response time
server.applications.x\.y.server.jsp.servicetime-lastsampletime = 1300811411960
server.applications.x\.y.server.jsp.servicetime-name = ServiceTime
server.applications.x\.y.server.jsp.servicetime-starttime = 1300811252183
server.applications.x\.y.server.jsp.servicetime-unit = millisecond

D:\>asadmin get m server.applications.x\.y.server.jsp.servicetime*
No monitoring data to report.


Byron Nevins added a comment - 14/Apr/11 10:56 AM
  • Why fix this issue in 3.1.1?
    Just piping output to grep with a regular expression works. Meanwhile giving the same regular expression to the monitoring framework gets no matches at all – this reflects badly on the product.
  • Which is the targeted build of 3.1.1 for this fix?
    I have no list of builds to pick from ?!?
  • Do regression tests exist for this issue?
    Yes. There are many unit tests, dev tests and QE tests
  • Which tests should QA (re)run to verify the fix did not destabilize GlassFish?
    Homer should re-run the QE 3.1 monitoring tests

scatari added a comment - 14/Apr/11 04:15 PM

Approved.


Byron Nevins added a comment - 24/May/11 10:38 AM

Excluding from 3.1.1

I spent an hour looking at this. The code has "high resistance to change". It is too risky and time-consuming for 3.1.1

Also there is a very very easy work-around which is to move the star upstream.

E.g. this does not work because the "-count" is a calculated thing. There is no "real" monitoring data with that name ending in a hyphen

server.applications.HelloWeb.server.sessionstotal-*

But this works fine:

server.applications.HelloWeb.server.sessionstotal*