glassfish
  1. glassfish
  2. GLASSFISH-15590

Regular Expression Checking not working for calculated values

    Details

    • Type: Bug Bug
    • Status: Open
    • Priority: Major Major
    • Resolution: Unresolved
    • Affects Version/s: 3.1
    • Fix Version/s: future release
    • Component/s: monitoring
    • Labels:
      None

      Description

      D:\gf\v3\core\kernel>asadmin get -m server.applications.x.y\.z.server.jsp.servicetime-coun*
      No monitoring data to report.

      D:\gf\v3\core\kernel>asadmin get -m server.applications.x.y\.z.server.jsp.servicetime-count
      server.applications.x\.y\.z.server.jsp.servicetime-count = 0

      =======
      The first command ought to work.

        Activity

        Byron Nevins created issue -
        Hide
        Byron Nevins added a comment -

        Another example:
        ========================
        D:\gf\v3\core\kernel>asadmin get -m server.applications.x.y.z.server.jsp.servicetime*

        server.applications.x\.y\.z.server.jsp.dotted-name =
        // lots of output removed //

        ============
        D:\gf\v3\core\kernel>asadmin get m server.applications.x.y.z.server.jsp.servicetime*
        No monitoring data to report.

        Show
        Byron Nevins added a comment - Another example: ======================== D:\gf\v3\core\kernel>asadmin get -m server.applications.x.y.z.server.jsp.servicetime* server.applications.x\.y\.z.server.jsp.dotted-name = // lots of output removed // ============ D:\gf\v3\core\kernel>asadmin get m server.applications.x.y.z.server.jsp.servicetime * No monitoring data to report.
        Jennifer Chou made changes -
        Field Original Value New Value
        Fix Version/s 3.2 [ 10969 ]
        Affects Version/s 3.1 [ 10968 ]
        Affects Version/s 3.2 [ 10969 ]
        Hide
        Byron Nevins added a comment -

        As you can see – the internal code is NOT looking at things as final strings and thus misses stuff.

        Another Example

        D:\>asadmin get -m server.applications.x\.y.server.jsp.servicetime*
        server.applications.x\.y.server.jsp.dotted-name = server.applications.x\.y.server.jsp
        server.applications.x\.y.server.jsp.servicetime-count = 0
        server.applications.x\.y.server.jsp.servicetime-description = Aggregate response time
        server.applications.x\.y.server.jsp.servicetime-lastsampletime = 1300811411960
        server.applications.x\.y.server.jsp.servicetime-name = ServiceTime
        server.applications.x\.y.server.jsp.servicetime-starttime = 1300811252183
        server.applications.x\.y.server.jsp.servicetime-unit = millisecond

        D:\>asadmin get m server.applications.x\.y.server.jsp.servicetime*
        No monitoring data to report.

        Show
        Byron Nevins added a comment - As you can see – the internal code is NOT looking at things as final strings and thus misses stuff. Another Example D:\>asadmin get -m server.applications.x\.y.server.jsp.servicetime* server.applications.x\.y.server.jsp.dotted-name = server.applications.x\.y.server.jsp server.applications.x\.y.server.jsp.servicetime-count = 0 server.applications.x\.y.server.jsp.servicetime-description = Aggregate response time server.applications.x\.y.server.jsp.servicetime-lastsampletime = 1300811411960 server.applications.x\.y.server.jsp.servicetime-name = ServiceTime server.applications.x\.y.server.jsp.servicetime-starttime = 1300811252183 server.applications.x\.y.server.jsp.servicetime-unit = millisecond D:\>asadmin get m server.applications.x\.y.server.jsp.servicetime * No monitoring data to report.
        Byron Nevins made changes -
        Tags 3_1-exclude 3_1-exclude 3_1_1-review
        Byron Nevins made changes -
        Tags 3_1-exclude 3_1_1-review 3_1_1-review
        Byron Nevins made changes -
        Tags 3_1_1-review
        Byron Nevins made changes -
        Tags 3_1_1-review
        Hide
        Byron Nevins added a comment -
        • Why fix this issue in 3.1.1?
          Just piping output to grep with a regular expression works. Meanwhile giving the same regular expression to the monitoring framework gets no matches at all – this reflects badly on the product.
        • Which is the targeted build of 3.1.1 for this fix?
          I have no list of builds to pick from ?!?
        • Do regression tests exist for this issue?
          Yes. There are many unit tests, dev tests and QE tests
        • Which tests should QA (re)run to verify the fix did not destabilize GlassFish?
          Homer should re-run the QE 3.1 monitoring tests
        Show
        Byron Nevins added a comment - Why fix this issue in 3.1.1? Just piping output to grep with a regular expression works. Meanwhile giving the same regular expression to the monitoring framework gets no matches at all – this reflects badly on the product. Which is the targeted build of 3.1.1 for this fix? I have no list of builds to pick from ?!? Do regression tests exist for this issue? Yes. There are many unit tests, dev tests and QE tests Which tests should QA (re)run to verify the fix did not destabilize GlassFish? Homer should re-run the QE 3.1 monitoring tests
        scatari made changes -
        Tags 3_1_1-review
        scatari made changes -
        Tags 3_1_1-approved
        Hide
        scatari added a comment -

        Approved.

        Show
        scatari added a comment - Approved.
        Byron Nevins made changes -
        Tags 3_1_1-approved 3_1_1-approved 3_1_1-exclude
        Byron Nevins made changes -
        Tags 3_1_1-approved 3_1_1-exclude 3_1_1-exclude
        Byron Nevins made changes -
        Tags 3_1_1-exclude
        Byron Nevins made changes -
        Tags 3_1_1-exclude
        Hide
        Byron Nevins added a comment -

        Excluding from 3.1.1

        I spent an hour looking at this. The code has "high resistance to change". It is too risky and time-consuming for 3.1.1

        Also there is a very very easy work-around which is to move the star upstream.

        E.g. this does not work because the "-count" is a calculated thing. There is no "real" monitoring data with that name ending in a hyphen

        server.applications.HelloWeb.server.sessionstotal-*

        But this works fine:

        server.applications.HelloWeb.server.sessionstotal*

        Show
        Byron Nevins added a comment - Excluding from 3.1.1 I spent an hour looking at this. The code has "high resistance to change". It is too risky and time-consuming for 3.1.1 Also there is a very very easy work-around which is to move the star upstream. E.g. this does not work because the "-count" is a calculated thing. There is no "real" monitoring data with that name ending in a hyphen server.applications.HelloWeb.server.sessionstotal-* But this works fine: server.applications.HelloWeb.server.sessionstotal*
        scatari made changes -
        Tags 3_1_1-exclude 3_1_1-exclude 3_1_1-scrubbed
        Byron Nevins made changes -
        Tags 3_1_1-exclude 3_1_1-scrubbed 3_1_1-exclude 3_1_1-scrubbed 3_1_x-exclude
        Jill Sato made changes -
        Fix Version/s 4.0 [ 10970 ]
        Fix Version/s 3.2 [ 10969 ]
        Byron Nevins made changes -
        Fix Version/s future release [ 11148 ]
        Fix Version/s 4.0 [ 10970 ]

          People

          • Assignee:
            Byron Nevins
            Reporter:
            Byron Nevins
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated: