glassfish
  1. glassfish
  2. GLASSFISH-15619

[UB]show "restart required" status when connector connection pool properties are changed

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 3.1_b38
    • Fix Version/s: 3.1_ms08
    • Component/s: docs
    • Labels:
      None

      Description

      Similar to: http://java.net/jira/browse/GLASSFISH-15516

      Per admin guide, domain restart is required when following connector connection pool properties are modified:

      ----------------------------
      1. resource-adapter-name
      2. connection-definition-name
      3. transaction-support
      4. associate-with-thread
      5. lazy-connection-association
      6. lazy-connection-enlistment
      7. Vendor-specific properties
      ----------------------------

      Updating any of these properties doesn't show "restart-required" on Admin Console / CLI.

      $ asadmin list-domains
      domain1 running

      Example Steps:

      1. Create new connector connection pool on Admin Console:

      Resources - Connector - Connector Connection Pool - New :

      Pool Name : myConnectionPool
      Resource Adapter : jmsra (select from pull down menu)
      Connection Definition: javax.jms.ConnectionFactory (select from pull down menu)

      click Next

      Leave everything else default, click Finish

      2. Edit myConnectionPool General Properties

      • Click on myConnecitonPool
      • General Tab:

      Connection Definition: javax.jms.QueueConnectionFactory

      Transaction Support: XATransaction

      • Click Save

      Expected: "restart required" is shown
      ===================

        Activity

        Hide
        Jagadish added a comment - - edited

        There was a docs issue to change the description for the reconfiguration of these attributes.
        "Restart required" is a hard requirement and is not always necessary.

        Any of the following actions will also work.

        1) Applications that refer the resource/pool can be re-deployed
        2) Applications that refer the resource/pool can be disabled and then enabled (re-enabled)
        3) Only when some-one does not know which applications are using the resource, restart is required so that the applications can start using re-configured resource/pool.

        I have requested for the above docs changes and is made available now :
        http://wikis.sun.com/display/GlassFish/GlassFishV3.1DeploymentDocReview

        Show
        Jagadish added a comment - - edited There was a docs issue to change the description for the reconfiguration of these attributes. "Restart required" is a hard requirement and is not always necessary. Any of the following actions will also work. 1) Applications that refer the resource/pool can be re-deployed 2) Applications that refer the resource/pool can be disabled and then enabled (re-enabled) 3) Only when some-one does not know which applications are using the resource, restart is required so that the applications can start using re-configured resource/pool. I have requested for the above docs changes and is made available now : http://wikis.sun.com/display/GlassFish/GlassFishV3.1DeploymentDocReview
        Hide
        Jagadish added a comment -

        Marking this as not an issue as "Restart required" is not always needed.

        Show
        Jagadish added a comment - Marking this as not an issue as "Restart required" is not always needed.
        Hide
        Harshad Vilekar added a comment -

        It's important to show "restart required" indication, when listed connector connection pool properties are changed - so that the user is aware that the changes are not yet effective.

        Updated Deployment Guide, Page 130 says: "Changing the following attributes (listed in a table c-36) 'requires a server restart' or the redeployment or disabling and re-enabling of applications... "

        Admin Guide also says that the server must be restarted for changes in listed connector connection pool properties to take effect.

        Reopening the issue - Approved by Nazrul.

        Show
        Harshad Vilekar added a comment - It's important to show "restart required" indication, when listed connector connection pool properties are changed - so that the user is aware that the changes are not yet effective. Updated Deployment Guide, Page 130 says: "Changing the following attributes (listed in a table c-36) 'requires a server restart' or the redeployment or disabling and re-enabling of applications... " Admin Guide also says that the server must be restarted for changes in listed connector connection pool properties to take effect. Reopening the issue - Approved by Nazrul.
        Hide
        Jagadish added a comment -

        Docs changes in "deployment guide" is in-place.
        http://wikis.sun.com/display/GlassFish/GlassFishV3.1DeploymentDocReview
        Refer the comment by id "jagadish-7"

        Docs changes are needed in "Administration Guide" > "Configuration changes that require restart".

        Sub-section :
        "Modifying the following connector connection pool properties"

        We need to add a foot-note :

        It is not always required to restart the server for changing any of these connection pool attributes or properties.
        After re-configuring of the pool, user can disable and enable application(s) that use the pool or redeploy the application(s) that use the pool.
        Only when application(s) that refer the pool is not known to the administrator or user, server restart is needed so that application(s) can use the re-configured pool.

        Transferring to docs category for required changes.

        Show
        Jagadish added a comment - Docs changes in "deployment guide" is in-place. http://wikis.sun.com/display/GlassFish/GlassFishV3.1DeploymentDocReview Refer the comment by id "jagadish-7" Docs changes are needed in "Administration Guide" > "Configuration changes that require restart". Sub-section : "Modifying the following connector connection pool properties" We need to add a foot-note : It is not always required to restart the server for changing any of these connection pool attributes or properties. After re-configuring of the pool, user can disable and enable application(s) that use the pool or redeploy the application(s) that use the pool. Only when application(s) that refer the pool is not known to the administrator or user, server restart is needed so that application(s) can use the re-configured pool. Transferring to docs category for required changes.
        Hide
        Scott Fordin added a comment -

        Added topic under "Restart Required" umbrella issue (http://java.net/jira/browse/GLASSFISH-16040) in 3.1 Release Notes.

        Show
        Scott Fordin added a comment - Added topic under "Restart Required" umbrella issue ( http://java.net/jira/browse/GLASSFISH-16040 ) in 3.1 Release Notes.
        Hide
        Paul Davies added a comment -

        To verify the fix, see the attachment to GLASSFISH-15635

        Show
        Paul Davies added a comment - To verify the fix, see the attachment to GLASSFISH-15635
        Hide
        Harshad Vilekar added a comment -

        Verified the updated doc attachment.

        Show
        Harshad Vilekar added a comment - Verified the updated doc attachment.

          People

          • Assignee:
            Paul Davies
            Reporter:
            Harshad Vilekar
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: