glassfish
  1. glassfish
  2. GLASSFISH-15684

MQ configure-jms-cluster is not supported by the GUI

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 3.1_dev
    • Fix Version/s: 3.1_dev
    • Component/s: admin_gui
    • Labels:
      None

      Description

      Steps:

      1. Start the domain

      cd $AS_HOME/bin
      asadmin start-domain

      2. Create appserver cluster

      Clusters - New - cluster1 - OK

      3. Set JMS integration mode to LOCAL

      Configurations - Cluster1-config - Java Message Service - Type - LOCAL - Save

      4. Use CLI to Configure Message Queue cluster. This configuration is currently not supported by the Admin GUI.

      Example:

      Specify DB password in a file using the key AS_ADMIN_JMSDBPASSWORD

      $ more /tmp/as_passfile
      AS_ADMIN_JMSDBPASSWORD=mypassword

      Configure Message Queue cluster
      $ asadmin --passwordfile /tmp/as_passfile configure-jms-cluster --clustertype=enhanced --dbvendor=mysql dbuser=root --dburl="jdbc:mysql://hostname.us.oracle.com:5000/mqdb" cluster1

      domain.xml:
      <jms-availability availability-enabled="true" db-password="mypassword" db-url="jdbc:mysql://hostname.us.oracle.com:5000/mqdb" message-store-type="jdbc" db-vendor="mysql" db-username="root"></jms-availability>

      Details of additional options and properties supported by the CLI are available: "asadmin configure-jms-cluster --help"

      5. Check out JMS availability tab. Various JMS cluster configuration parameters are not available on the GUI screen. JMS cluster configuration in domain.xml (set by CLI) gets overwritten when "Save" button is pressed.

      Configurations - Cluster1-config - Availability Service - JMS Availability- Availability Service - check "Enabled" - Save

      Result:

      domain.xml:
      <jms-availability availability-enabled="true"></jms-availability>

        Issue Links

          Activity

          Hide
          Anissa Lam added a comment -

          #1: GUI can be enhanced to disable the dropdown for better user experience, but backend is taking that value fine. ActionReport returns SUCCESS. The element is preserved to domain.xml. According to the man page, The default value is masterbroker. This option is ignored if clustertype is set to enhanced.
          Please file an issue against 'ha' if it shouldn't take 'masterborker' as the input. They should return FAILURE and NOT persist that in domain.xml

          #2. "Message Store Type" field should be disabled when "Availability Enabled" service is checked.
          Please file an enhancement.

          #3. What is the purpose of "MQ Store Pool Name" ? CLI doesn't have this option.
          This attribute is carried over from v2. I will remove that.

          #4. Online Help is incorrect, it doesn't match the "JMS Availability" screen.
          I just filed GLASSFISH-15806 against doc.

          #5. "i18njms.availability.UserName"
          Will fix properties file.

          #6. There are other typos on the screen. Example, tool tip for "Database Password:" says "availabilyenabled"
          Will fix properties file.

          #7. Server log prints message: "VariableResolver was unable to find key (availability.UserName) in ResourceBundle (i18njms)"
          This is due to #5 above.

          As a summary, I see that GUI needs to remove the MQ Store Pool name, and fix the Strings.properties file.
          This is very minor issue.

          Show
          Anissa Lam added a comment - #1: GUI can be enhanced to disable the dropdown for better user experience, but backend is taking that value fine. ActionReport returns SUCCESS. The element is preserved to domain.xml. According to the man page, The default value is masterbroker. This option is ignored if clustertype is set to enhanced. Please file an issue against 'ha' if it shouldn't take 'masterborker' as the input. They should return FAILURE and NOT persist that in domain.xml #2. "Message Store Type" field should be disabled when "Availability Enabled" service is checked. Please file an enhancement. #3. What is the purpose of "MQ Store Pool Name" ? CLI doesn't have this option. This attribute is carried over from v2. I will remove that. #4. Online Help is incorrect, it doesn't match the "JMS Availability" screen. I just filed GLASSFISH-15806 against doc. #5. "i18njms.availability.UserName" Will fix properties file. #6. There are other typos on the screen. Example, tool tip for "Database Password:" says "availabilyenabled" Will fix properties file. #7. Server log prints message: "VariableResolver was unable to find key (availability.UserName) in ResourceBundle (i18njms)" This is due to #5 above. As a summary, I see that GUI needs to remove the MQ Store Pool name, and fix the Strings.properties file. This is very minor issue.
          Hide
          Anissa Lam added a comment -

          How bad is its impact? (Severity)
          Pretty minor. We are showing a depreciated attribute, and a String property key instead of the String itself.

          How often does it happen? (Frequency)
          Every time when the JMS Availability page shows up

          How much effort is required to fix it? (Cost)
          1 hour.

          What is the risk of fixing it? (Risk)
          Extremely low.

          Does a work around for the issue exist? Can the workaround be reasonably employed by the end user?
          No.

          If the issue is not fixed should the issue and its workaround (if applicable) be described in the Release Notes?
          No.

          How long has the bug existed in the product?
          This is a new page that was integrated last week.

          Do regression tests exist for this issue?
          Yes, there is dev test for this screen, I have updated that now to reflect the removal of depreciated attribute.

          Which tests should QA (re)run to verify the fix did not destabilize GlassFish?
          GUI Dev Tests

          When will a tested fix be ready for integration?
          The diff is attached, which also contains the updated devtest.

          Summary of what has been changed:

          • remove the depreciated attribute MQ Store Name which was from v2.
          • notice that that allowed value for Config Store Type (masterbroker, sharedb) and Message Store Type (file, jdbc) is put in the properties file for localization. This shouldn't be. So, modify that also.
          • fix properties file.
          Show
          Anissa Lam added a comment - How bad is its impact? (Severity) Pretty minor. We are showing a depreciated attribute, and a String property key instead of the String itself. How often does it happen? (Frequency) Every time when the JMS Availability page shows up How much effort is required to fix it? (Cost) 1 hour. What is the risk of fixing it? (Risk) Extremely low. Does a work around for the issue exist? Can the workaround be reasonably employed by the end user? No. If the issue is not fixed should the issue and its workaround (if applicable) be described in the Release Notes? No. How long has the bug existed in the product? This is a new page that was integrated last week. Do regression tests exist for this issue? Yes, there is dev test for this screen, I have updated that now to reflect the removal of depreciated attribute. Which tests should QA (re)run to verify the fix did not destabilize GlassFish? GUI Dev Tests When will a tested fix be ready for integration? The diff is attached, which also contains the updated devtest. Summary of what has been changed: remove the depreciated attribute MQ Store Name which was from v2. notice that that allowed value for Config Store Type (masterbroker, sharedb) and Message Store Type (file, jdbc) is put in the properties file for localization. This shouldn't be. So, modify that also. fix properties file.
          Hide
          Anissa Lam added a comment -

          Please refer to the last comment. This is by no means a blocker issue.

          Show
          Anissa Lam added a comment - Please refer to the last comment. This is by no means a blocker issue.
          Hide
          Chris Kasso added a comment -

          Approved for RC2.

          Show
          Chris Kasso added a comment - Approved for RC2.
          Hide
          Anissa Lam added a comment -

          Fix checked into both Trunk and 3.1 branch.
          Trunk: rev# 44873
          3.1 Branch: rev# 44874

          =================

          Project: glassfish
          Repository: svn
          Revision: 44874
          Author: anilam
          Date: 2011-02-03 18:48:12 UTC
          Link:

          Log Message:
          ------------
          Issue: GLASSFISH-15684 Fix JMS Availability screen.
          Summary of what has been changed:

          • remove the depreciated attribute MQ Store Name which was from v2.
          • notice that that allowed value for Config Store Type (masterbroker, sharedb) and Message Store Type (file, jdbc) is put in the properties file for localization. This shouldn't be. So, modify that also.
          • fix properties file.

          Fix is in the trunk as rev# 44873

          Reviewed by Suma, Srini
          Approved by Chris Kaaso

          Revisions:
          ----------
          44874

          Modified Paths:
          ---------------
          branches/3.1/admingui/jms-plugin/src/main/resources/jmsAvailabilityService.jsf
          branches/3.1/admingui/devtests/src/test/java/org/glassfish/admingui/devtests/AvailabilityServiceTest.java
          branches/3.1/admingui/jms-plugin/src/main/resources/org/glassfish/jms/admingui/Strings.properties

          Show
          Anissa Lam added a comment - Fix checked into both Trunk and 3.1 branch. Trunk: rev# 44873 3.1 Branch: rev# 44874 ================= Project: glassfish Repository: svn Revision: 44874 Author: anilam Date: 2011-02-03 18:48:12 UTC Link: Log Message: ------------ Issue: GLASSFISH-15684 Fix JMS Availability screen. Summary of what has been changed: remove the depreciated attribute MQ Store Name which was from v2. notice that that allowed value for Config Store Type (masterbroker, sharedb) and Message Store Type (file, jdbc) is put in the properties file for localization. This shouldn't be. So, modify that also. fix properties file. Fix is in the trunk as rev# 44873 Reviewed by Suma, Srini Approved by Chris Kaaso Revisions: ---------- 44874 Modified Paths: --------------- branches/3.1/admingui/jms-plugin/src/main/resources/jmsAvailabilityService.jsf branches/3.1/admingui/devtests/src/test/java/org/glassfish/admingui/devtests/AvailabilityServiceTest.java branches/3.1/admingui/jms-plugin/src/main/resources/org/glassfish/jms/admingui/Strings.properties

            People

            • Assignee:
              Anissa Lam
              Reporter:
              Harshad Vilekar
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Due:
                Created:
                Updated:
                Resolved: