glassfish
  1. glassfish
  2. GLASSFISH-15801

create-file-user is missing --target in the usage message

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Critical Critical
    • Resolution: Fixed
    • Affects Version/s: 3.1_b40
    • Fix Version/s: None
    • Component/s: security
    • Labels:
      None

      Description

      Here is the usage message from create-file-user:

      $ asadmin create-file-user -x
      Invalid option: -x
      Usage: asadmin [asadmin-utility-options] create-file-user
      [--groups user_groups[:user_groups]*] [--authrealmname <authrealm_name>]
      [?|-help[=<help(default:false)>]] username
      Command create-file-user failed.

      Note that the --target option is missing even though the command does actually accept a --target option.

        Activity

        Hide
        kumarjayanti added a comment -

        there was another bug filed for this. I cannot recollect the bug number though. Should i mark this for release-notes ?.

        Show
        kumarjayanti added a comment - there was another bug filed for this. I cannot recollect the bug number though. Should i mark this for release-notes ?.
        Hide
        Tom Mueller added a comment -

        I would recommend "no" since the man page is correct.

        Show
        Tom Mueller added a comment - I would recommend "no" since the man page is correct.
        Hide
        Nazrul added a comment -

        Assuming this is a one line change, please fix this.

        Show
        Nazrul added a comment - Assuming this is a one line change, please fix this.
        Hide
        kumarjayanti added a comment -

        Trunk :
        -------
        Sending Users/vbkumarjayanti/Documents/workspace/glassfish/v3/v3/security/core/src/main/java/com/sun/enterprise/security/cli/LocalStrings.properties
        Transmitting file data .
        Committed revision 44893.

        Revision: 44893
        Author : kumarjayanti
        Date : Feb 4, 2011 11:48:56 AM
        Fix for 15801

        V3.1 Branch
        -----------
        Sending Users/vbkumarjayanti/Documents/workspace/glassfish/v3.1/3.1/security/core/src/main/java/com/sun/enterprise/security/cli/LocalStrings.properties
        Transmitting file data .
        Committed revision 44894.

        Revision: 44894
        Author : kumarjayanti
        Date : Feb 4, 2011 11:52:56 AM
        Fix for 15801, approved by nazrul, output after fix :

        ./asadmin create-file-user -x
        Invalid option: -x
        Usage: asadmin [asadmin-utility-options] create-file-user
        [--authrealmname <authrealm_name>] [--target target]
        [--groups user_groups[:user_groups]*]
        [?|-help[=<help(default:false)>]] username

        SVN diff of the Fix :
        ---------------

        Index: LocalStrings.properties
        ===================================================================
        — LocalStrings.properties (revision 44845)
        +++ LocalStrings.properties (working copy)
        @@ -39,7 +39,7 @@
        #

        file.realm.keyfilenonexistent=The specified physical file

        {0} associated with the file realm {1} does not exist.
        create.file.user.usagetext=create-file-user\n\t[groups user_groups[:user_groups]*] [--authrealmname <authrealm_name>]\n\t[?|--help[=<help(default:false)>]] username
        +create.file.user.usagetext=create-file-user\n\t[--authrealmname <authrealm_name>] [--target target] \n\t[-groups user_groups[:user_groups]*] \n\t[?|--help[=<help(default:false)>]] username
        create.file.user.filerealmnotfound=File realm {0}

        does not exist
        create.file.user.keyfilenotfound=No physical file is associated with file realm

        {0}

        .

        Show
        kumarjayanti added a comment - Trunk : ------- Sending Users/vbkumarjayanti/Documents/workspace/glassfish/v3/v3/security/core/src/main/java/com/sun/enterprise/security/cli/LocalStrings.properties Transmitting file data . Committed revision 44893. Revision: 44893 Author : kumarjayanti Date : Feb 4, 2011 11:48:56 AM Fix for 15801 V3.1 Branch ----------- Sending Users/vbkumarjayanti/Documents/workspace/glassfish/v3.1/3.1/security/core/src/main/java/com/sun/enterprise/security/cli/LocalStrings.properties Transmitting file data . Committed revision 44894. Revision: 44894 Author : kumarjayanti Date : Feb 4, 2011 11:52:56 AM Fix for 15801, approved by nazrul, output after fix : ./asadmin create-file-user -x Invalid option: -x Usage: asadmin [asadmin-utility-options] create-file-user [--authrealmname <authrealm_name>] [--target target] [--groups user_groups [:user_groups] *] [ ?| -help [=<help(default:false)>] ] username SVN diff of the Fix : --------------- Index: LocalStrings.properties =================================================================== — LocalStrings.properties (revision 44845) +++ LocalStrings.properties (working copy) @@ -39,7 +39,7 @@ # file.realm.keyfilenonexistent=The specified physical file {0} associated with the file realm {1} does not exist. create.file.user.usagetext=create-file-user\n\t[ groups user_groups [:user_groups] *] [--authrealmname <authrealm_name>] \n\t[ ?|--help [=<help(default:false)>] ] username +create.file.user.usagetext=create-file-user\n\t [--authrealmname <authrealm_name>] [--target target] \n\t[- groups user_groups [:user_groups] *] \n\t[ ?|--help [=<help(default:false)>] ] username create.file.user.filerealmnotfound=File realm {0} does not exist create.file.user.keyfilenotfound=No physical file is associated with file realm {0} .
        Hide
        kumarjayanti added a comment -

        fixed

        Show
        kumarjayanti added a comment - fixed

          People

          • Assignee:
            kumarjayanti
            Reporter:
            Tom Mueller
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: