glassfish
  1. glassfish
  2. GLASSFISH-15851

remove --upgrade option from start-local-instance

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Blocker Blocker
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: admin
    • Labels:
      None

      Description

      We seem to have --upgrade option in start-local-instance in the usage. Please get rid of it.

      Usage: asadmin [asadmin-utility-options] start-local-instance
      [--verbose[=<verbose(default:false)>]]
      [--debug[=<debug(default:false)>]]
      [--upgrade[=<upgrade(default:false)>]] [--sync <sync(default:normal)>]
      [--nodedir <nodedir>] [--node <node>]
      [?|-help[=<help(default:false)>]] [instance_name]

        Issue Links

          Activity

          Hide
          Byron Nevins added a comment -

          I have the following proposed fix out for code review:
          Index: src/main/java/com/sun/enterprise/admin/cli/cluster/StartLocalInstanceCommand.java
          ===================================================================
          — src/main/java/com/sun/enterprise/admin/cli/cluster/StartLocalInstanceCommand.java (revision 44883)
          +++ src/main/java/com/sun/enterprise/admin/cli/cluster/StartLocalInstanceCommand.java (working copy)
          @@ -74,9 +74,6 @@
          @Param(optional = true, defaultValue = "false")
          private boolean debug;

          • @Param(optional = true, defaultValue = "false")
          • private boolean upgrade;
            -
            // handled by superclass
            //@Param(name = "instance_name", primary = true, optional = false)
            //private String instanceName0;
            @@ -147,7 +144,7 @@

          launcher.launch();

          • if (verbose || upgrade) { // we can potentially loop forever here...
            + if (verbose) { // we can potentially loop forever here...
            while (true) {
            int returnValue = launcher.getExitValue();

          @@ -197,10 +194,8 @@
          info = launcher.getInfo();
          info.setInstanceName(instanceName);
          info.setInstanceRootDir(instanceDir);

          • info.setVerbose(verbose || upgrade);
            + info.setVerbose(verbose);
            info.setDebug(debug);
          • info.setUpgrade(upgrade);
            -
            info.setRespawnInfo(programOpts.getClassName(),
            programOpts.getClassPath(),
            respawnArgs());
          Show
          Byron Nevins added a comment - I have the following proposed fix out for code review: Index: src/main/java/com/sun/enterprise/admin/cli/cluster/StartLocalInstanceCommand.java =================================================================== — src/main/java/com/sun/enterprise/admin/cli/cluster/StartLocalInstanceCommand.java (revision 44883) +++ src/main/java/com/sun/enterprise/admin/cli/cluster/StartLocalInstanceCommand.java (working copy) @@ -74,9 +74,6 @@ @Param(optional = true, defaultValue = "false") private boolean debug; @Param(optional = true, defaultValue = "false") private boolean upgrade; - // handled by superclass //@Param(name = "instance_name", primary = true, optional = false) //private String instanceName0; @@ -147,7 +144,7 @@ launcher.launch(); if (verbose || upgrade) { // we can potentially loop forever here... + if (verbose) { // we can potentially loop forever here... while (true) { int returnValue = launcher.getExitValue(); @@ -197,10 +194,8 @@ info = launcher.getInfo(); info.setInstanceName(instanceName); info.setInstanceRootDir(instanceDir); info.setVerbose(verbose || upgrade); + info.setVerbose(verbose); info.setDebug(debug); info.setUpgrade(upgrade); - info.setRespawnInfo(programOpts.getClassName(), programOpts.getClassPath(), respawnArgs());
          Hide
          Byron Nevins added a comment -

          Reviewer: Tom Mueller
          Approver: Nazrul Islam
          Ran QL tests for completeness

          ========================
          trunk:
          D:\gf\v3\cluster\cli>svn commit
          Sending cli\src\main\java\com\sun\enterprise\admin\cli\cluster\StartLocalInstanceCommand.java
          Transmitting file data .
          Committed revision 44909.

          ========================
          3.1 branch:

          D:\gf\v3\cluster\cli\3.1\cli>svn commit -F commit.txt
          Sending src\main\java\com\sun\enterprise\admin\cli\cluster\StartLocalInstanceCommand.java
          Transmitting file data .
          Committed revision 44910.

          Show
          Byron Nevins added a comment - Reviewer: Tom Mueller Approver: Nazrul Islam Ran QL tests for completeness ======================== trunk: D:\gf\v3\cluster\cli>svn commit Sending cli\src\main\java\com\sun\enterprise\admin\cli\cluster\StartLocalInstanceCommand.java Transmitting file data . Committed revision 44909. ======================== 3.1 branch: D:\gf\v3\cluster\cli\3.1\cli>svn commit -F commit.txt Sending src\main\java\com\sun\enterprise\admin\cli\cluster\StartLocalInstanceCommand.java Transmitting file data . Committed revision 44910.
          Hide
          Nazrul added a comment -

          %asadmin start-local-instance --help shows --upgrade option. Please release note that this is incorrect.

          Show
          Nazrul added a comment - %asadmin start-local-instance --help shows --upgrade option. Please release note that this is incorrect.

            People

            • Assignee:
              Byron Nevins
              Reporter:
              Nazrul
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: