glassfish
  1. glassfish
  2. GLASSFISH-15931

web profile: New Resource Adapter Config screen shows 'jmsra' and causes error shown on screen

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Critical Critical
    • Resolution: Fixed
    • Affects Version/s: 3.1_b41
    • Fix Version/s: 3.1_b42
    • Component/s: admin_gui
    • Labels:
      None

      Description

      When running in web profile, 'jmsra' is added to the Resource adapter list in the create Resource Adapter Config screen. 'jmsra' is not present in web profile, thus causing an error msg on screen when first get there.

      User can still use the screen to create the RA Config for the adapter they have deployed.
      No lost in functionality.
      If i can't find a trivial fix tomorrow, we will have to exclude this and release note it.

      1. jmsra.diff
        12 kB
        Anissa Lam
      1. error.jpg
        239 kB

        Issue Links

          Activity

          Hide
          Anissa Lam added a comment -

          The web profile doesn't have the buildin resource adapter "jmsra", thus resulting in exception when trying to get more info about this resource adapter.

          The following screen is affected because of this bug: Admin Object Resource, Work Security Maps and Resource Adapter Config. There should be API for GUI to obtain the system resources adapter, instead of always adding "jmsra" since GUI will not know if it is running in web profile or glassfish profile.

          And then the already existed command _get-system-rars-allowing-pool-creation() returns the wrong info. It returns "jmsra" and "jaxr-ra" even in web profile, thus causing the problem in Connector Connection Pool.

          As a 'quick' fix for this, we can add a session attribute "_jms_plugin_exist" in the JMS tree node, so all the affected screen can check this value and decide if "jmsra" should be added or not.

          This fix is very low risk and local to these 4 screens.

          Show
          Anissa Lam added a comment - The web profile doesn't have the buildin resource adapter "jmsra", thus resulting in exception when trying to get more info about this resource adapter. The following screen is affected because of this bug: Admin Object Resource, Work Security Maps and Resource Adapter Config. There should be API for GUI to obtain the system resources adapter, instead of always adding "jmsra" since GUI will not know if it is running in web profile or glassfish profile. And then the already existed command _get-system-rars-allowing-pool-creation() returns the wrong info. It returns "jmsra" and "jaxr-ra" even in web profile, thus causing the problem in Connector Connection Pool. As a 'quick' fix for this, we can add a session attribute "_jms_plugin_exist" in the JMS tree node, so all the affected screen can check this value and decide if "jmsra" should be added or not. This fix is very low risk and local to these 4 screens.
          Hide
          Anissa Lam added a comment -

          considering the # of pages affected by this, raising this to critical.

          Show
          Anissa Lam added a comment - considering the # of pages affected by this, raising this to critical.
          Hide
          Anissa Lam added a comment -

          1. How bad is its impact? (Severity)
          The impact is pretty bad. There are 4 resources page affected by this which are pretty common functions that GUI user performs.

          2. How often does it happen? (Frequency)
          100%

          3. How much effort is required to fix it? (Cost)
          Take me sometimes to track down the issue, and then figuring out how to fix this with min. code change. There are better fix available, but those require additional hidden command from Jagadish, and then REST needs to expose it. Too late at this point.
          The fix now is to 'blockcast' to the world that 'I exist' from the JMS plugin, and then let those screens to decide whether to include "jmsra" and "jaxr-ra" in the resource adapter dropdown list or not.

          4. What is the risk of fixing it? (Risk)
          The risk is pretty low.

          5. Does a work around for the issue exist? Can the workaround be reasonably employed by the end user?
          For RA config, work security map and connector connection pool, user has to ignore the error when they first visit the screen. For Admin Object Resource, there is no workaround. The page just doesn't function with exception shown on screen.

          6. If the issue is not fixed should the issue and its workaround (if applicable) be described in the Release Notes?
          Definitely.

          7. How long has the bug existed in the product?
          Since we support web profile.

          8. Do regression tests exist for this issue?
          Yes, but we don't run those test in web profile. Should start setting up hudson job for this profile.

          9. Which tests should QA (re)run to verify the fix did not destabilize GlassFish?
          The usual test they run. If this change causes any regression, it can be caught right away.

          10. When will a tested fix be ready for integration?
          I am testing my changes now. Should be available for review in a couple hours.

          Show
          Anissa Lam added a comment - 1. How bad is its impact? (Severity) The impact is pretty bad. There are 4 resources page affected by this which are pretty common functions that GUI user performs. 2. How often does it happen? (Frequency) 100% 3. How much effort is required to fix it? (Cost) Take me sometimes to track down the issue, and then figuring out how to fix this with min. code change. There are better fix available, but those require additional hidden command from Jagadish, and then REST needs to expose it. Too late at this point. The fix now is to 'blockcast' to the world that 'I exist' from the JMS plugin, and then let those screens to decide whether to include "jmsra" and "jaxr-ra" in the resource adapter dropdown list or not. 4. What is the risk of fixing it? (Risk) The risk is pretty low. 5. Does a work around for the issue exist? Can the workaround be reasonably employed by the end user? For RA config, work security map and connector connection pool, user has to ignore the error when they first visit the screen. For Admin Object Resource, there is no workaround. The page just doesn't function with exception shown on screen. 6. If the issue is not fixed should the issue and its workaround (if applicable) be described in the Release Notes? Definitely. 7. How long has the bug existed in the product? Since we support web profile. 8. Do regression tests exist for this issue? Yes, but we don't run those test in web profile. Should start setting up hudson job for this profile. 9. Which tests should QA (re)run to verify the fix did not destabilize GlassFish? The usual test they run. If this change causes any regression, it can be caught right away. 10. When will a tested fix be ready for integration? I am testing my changes now. Should be available for review in a couple hours.
          Hide
          Anissa Lam added a comment - - edited

          Patch attached.
          I have tested the following cases manually.

          • web profile
            No RAR deployed. – There will not be any Resource Adapter available on the screens to select from, there won't be any error on screen. User can't create any Connector Connection Pool, Admin Object Resource, Connector Security Map and Resource Adapter Config.
            With RAR deployed. – This deployed rar will show up as expected, and user can create all the above objects with the deployed RAR. (except for Admin Object Resource, refer to GLASSFISH-15949)/
          • glassfish profile
            NO RAR deployed – the default 'jmsra' shows up correctly. for Connector Connection Pool, both 'jmsra' and 'jasx-ra' shows up correctly.

          with RAR deployed – shows up besides the default build in one (jmsra).

          I am running the dev test for the glassfish profile to make sure no regression. I cannot run the devtest on web profile yet, because lots of the test is using 'jmsra' as the adapter. This all needs to be cleaned up.

          Show
          Anissa Lam added a comment - - edited Patch attached. I have tested the following cases manually. web profile No RAR deployed. – There will not be any Resource Adapter available on the screens to select from, there won't be any error on screen. User can't create any Connector Connection Pool, Admin Object Resource, Connector Security Map and Resource Adapter Config. With RAR deployed. – This deployed rar will show up as expected, and user can create all the above objects with the deployed RAR. (except for Admin Object Resource, refer to GLASSFISH-15949 )/ glassfish profile NO RAR deployed – the default 'jmsra' shows up correctly. for Connector Connection Pool, both 'jmsra' and 'jasx-ra' shows up correctly. with RAR deployed – shows up besides the default build in one (jmsra). I am running the dev test for the glassfish profile to make sure no regression. I cannot run the devtest on web profile yet, because lots of the test is using 'jmsra' as the adapter. This all needs to be cleaned up.
          Hide
          Chris Kasso added a comment -

          Approved for RC3.

          Show
          Chris Kasso added a comment - Approved for RC3.
          Hide
          Jason Lee added a comment -

          Changes look fine.

          Show
          Jason Lee added a comment - Changes look fine.
          Hide
          Anissa Lam added a comment -

          Fix checked into both trunk & 3.1 branch.

          3.1 branch: rev# 45053
          trunk: rev# 45054

          Project: glassfish
          Repository: svn
          Revision: 45053
          Author: anilam
          Date: 2011-02-11 05:18:03 UTC
          Link:

          Log Message:
          ------------
          GLASSFISH-15931. Fixes for web profile NOT to refer to jmsra and jaxs-ra which is not available in web profile. This is by setting a session attribute in the JMS plugin and all screens should check that attribute before showing these 2 build-in adapter.

          Reviewed by Jason
          Approved by Chris

          Revisions:
          ----------
          45053

          Modified Paths:
          ---------------
          branches/3.1/admingui/jms-plugin/src/main/resources/resourcesNodes.jsf
          branches/3.1/admingui/jca/src/main/resources/resourceAdapterConfigAttr.inc
          branches/3.1/admingui/jca/src/main/resources/adminObjectAttr.inc
          branches/3.1/admingui/jca/src/main/java/org/glassfish/jca/admingui/handlers/ConnectorsHandlers.java
          branches/3.1/admingui/jca/src/main/resources/adminObjectNew.jsf
          branches/3.1/admingui/jca/src/main/resources/resourceAdapterConfigNew.jsf
          branches/3.1/admingui/jca/src/main/resources/workSecurityMapAttr.inc
          branches/3.1/admingui/jca/src/main/resources/connectorConnectionPoolNew1.jsf
          branches/3.1/admingui/jca/src/main/resources/connectorConnectionPoolEdit.jsf

          Show
          Anissa Lam added a comment - Fix checked into both trunk & 3.1 branch. 3.1 branch: rev# 45053 trunk: rev# 45054 Project: glassfish Repository: svn Revision: 45053 Author: anilam Date: 2011-02-11 05:18:03 UTC Link: Log Message: ------------ GLASSFISH-15931 . Fixes for web profile NOT to refer to jmsra and jaxs-ra which is not available in web profile. This is by setting a session attribute in the JMS plugin and all screens should check that attribute before showing these 2 build-in adapter. Reviewed by Jason Approved by Chris Revisions: ---------- 45053 Modified Paths: --------------- branches/3.1/admingui/jms-plugin/src/main/resources/resourcesNodes.jsf branches/3.1/admingui/jca/src/main/resources/resourceAdapterConfigAttr.inc branches/3.1/admingui/jca/src/main/resources/adminObjectAttr.inc branches/3.1/admingui/jca/src/main/java/org/glassfish/jca/admingui/handlers/ConnectorsHandlers.java branches/3.1/admingui/jca/src/main/resources/adminObjectNew.jsf branches/3.1/admingui/jca/src/main/resources/resourceAdapterConfigNew.jsf branches/3.1/admingui/jca/src/main/resources/workSecurityMapAttr.inc branches/3.1/admingui/jca/src/main/resources/connectorConnectionPoolNew1.jsf branches/3.1/admingui/jca/src/main/resources/connectorConnectionPoolEdit.jsf

            People

            • Assignee:
              Anissa Lam
              Reporter:
              Anissa Lam
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Due:
                Created:
                Updated:
                Resolved: