glassfish
  1. glassfish
  2. GLASSFISH-15975

lazy-init attribute missing from admin console Edit IIOP Listener page

    Details

    • Type: Bug Bug
    • Status: Open
    • Priority: Major Major
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: 4.1
    • Component/s: orb
    • Labels:
      None

      Description

      There isn't any way to view or edit the lazy-init setting for the IIOP listener from the admin console.

        Activity

        Hide
        Anissa Lam added a comment -

        This sounds like a new attribute added in iiop-listener, not sure if this is since 3.0 or 3.1.
        The module owner should have contacted GUI regarding this change so that it can be incorporated in the GUI page.

        When looking at config-api, I see that there is only get() method, but not set() for this attribute
        @Attribute(defaultValue="false", dataType=Boolean.class)
        String getLazyInit();

        Is this a read-only attribute ?
        Please confirm or fix this. Transfer to 'orb'.

        Show
        Anissa Lam added a comment - This sounds like a new attribute added in iiop-listener, not sure if this is since 3.0 or 3.1. The module owner should have contacted GUI regarding this change so that it can be incorporated in the GUI page. When looking at config-api, I see that there is only get() method, but not set() for this attribute @Attribute(defaultValue="false", dataType=Boolean.class) String getLazyInit(); Is this a read-only attribute ? Please confirm or fix this. Transfer to 'orb'.
        Hide
        Tom Mueller added a comment -

        The IiopListener config bean has the following code:

        /**

        • Sets the value of lazyInit property
          *
        • Specify is this listener should be started as part of server startup or not
          *
        • @param value true if the listener is to be started lazily; false otherwise
          */
          void String(boolean value);

        It looks like this "String" method was supposed to be a "setLazyInit" method - maybe a typo?

        Show
        Tom Mueller added a comment - The IiopListener config bean has the following code: /** Sets the value of lazyInit property * Specify is this listener should be started as part of server startup or not * @param value true if the listener is to be started lazily; false otherwise */ void String(boolean value); It looks like this "String" method was supposed to be a "setLazyInit" method - maybe a typo?
        Hide
        Ken Cavanaugh added a comment -

        This was added in 3.0. I'm not sure who was working on the IiopListener class at that
        point, but it belongs to the orb now. I think Tom's comment is correct, and
        the method should be

        void setLazyInit( boolean value )

        This is probably not worth fixing this late in 3.1. I'm marking this issue for inclusion
        in the release notes.

        I think it's probably OK for 3.1, because I don't think there is much need to change the default
        value.

        Show
        Ken Cavanaugh added a comment - This was added in 3.0. I'm not sure who was working on the IiopListener class at that point, but it belongs to the orb now. I think Tom's comment is correct, and the method should be void setLazyInit( boolean value ) This is probably not worth fixing this late in 3.1. I'm marking this issue for inclusion in the release notes. I think it's probably OK for 3.1, because I don't think there is much need to change the default value.
        Hide
        Anissa Lam added a comment -

        >> I think it's probably OK for 3.1, because I don't think there is much need to change the default
        value.

        Do you mean the default value or out-of-box value ? They are different.
        And is there a reason why default value is different than out-of-box value ? This is always very confusing to user when this happen.

        Show
        Anissa Lam added a comment - >> I think it's probably OK for 3.1, because I don't think there is much need to change the default value. Do you mean the default value or out-of-box value ? They are different. And is there a reason why default value is different than out-of-box value ? This is always very confusing to user when this happen.
        Hide
        Ken Cavanaugh added a comment -

        I don't know what the difference is between default and out-of-the-box.
        I just know that I always see lazy-init="true" for the orb-listener-1
        IIOP listener in the config.xml file.

        Show
        Ken Cavanaugh added a comment - I don't know what the difference is between default and out-of-the-box. I just know that I always see lazy-init="true" for the orb-listener-1 IIOP listener in the config.xml file.
        Hide
        Tom Mueller added a comment -

        Default is the value that is in the config bean Java source code, in this case "false".

        Out-of-the-box is the value that is in the domain.xml template file, in this case "true" for orb-listener-1 and "false" for SSL and SSL_MULTIAUTH.

        If a user clicks "New" in the admin console or runs the create-iiop-listener command (which also doesn't provide any way to set lazy-init), the user gets the default value, i.e., "false".

        Show
        Tom Mueller added a comment - Default is the value that is in the config bean Java source code, in this case "false". Out-of-the-box is the value that is in the domain.xml template file, in this case "true" for orb-listener-1 and "false" for SSL and SSL_MULTIAUTH. If a user clicks "New" in the admin console or runs the create-iiop-listener command (which also doesn't provide any way to set lazy-init), the user gets the default value, i.e., "false".
        Hide
        Scott Fordin added a comment -

        Need more info to add issue to 3.1 Release Notes.

        Show
        Scott Fordin added a comment - Need more info to add issue to 3.1 Release Notes.
        Hide
        Tom Mueller added a comment -

        For the release notes:

        The problem is that a user cannot set the lazy-init value for an IIOP listener from either the console or the CLI. Note that even the asadmin "set" command cannot be used to change the value. The only way to workaround this issue is to edit the domain.xml file directly. The domain.xml file may have:

        <iiop-listener port="3700" id="orb-listener-1" address="0.0.0.0" lazy-init="true"></iiop-listener>

        In this case, the lazy-init value can be changed to false.

        Or, the domain.xml file may have:

        <iiop-listener port="3700" id="orb-listener-1" address="0.0.0.0"></iiop-listener>

        Here, the default value of false is in effect. To change it to true, add:

        lazy-init="true"

        to the iiop-listener element.

        Show
        Tom Mueller added a comment - For the release notes: The problem is that a user cannot set the lazy-init value for an IIOP listener from either the console or the CLI. Note that even the asadmin "set" command cannot be used to change the value. The only way to workaround this issue is to edit the domain.xml file directly. The domain.xml file may have: <iiop-listener port="3700" id="orb-listener-1" address="0.0.0.0" lazy-init="true"></iiop-listener> In this case, the lazy-init value can be changed to false. Or, the domain.xml file may have: <iiop-listener port="3700" id="orb-listener-1" address="0.0.0.0"></iiop-listener> Here, the default value of false is in effect. To change it to true, add: lazy-init="true" to the iiop-listener element.
        Hide
        Scott Fordin added a comment -

        Added topic to 3.1 Release Notes. Removed "need more info" tag, added "release note added" tag.

        Show
        Scott Fordin added a comment - Added topic to 3.1 Release Notes. Removed "need more info" tag, added "release note added" tag.
        Hide
        Nazrul added a comment -

        Given that there is no way to manage lazy-init attribute using CLI and GUI, it would be useful to consider fixing this issue during 3.1.1

        Show
        Nazrul added a comment - Given that there is no way to manage lazy-init attribute using CLI and GUI, it would be useful to consider fixing this issue during 3.1.1
        Hide
        scatari added a comment -

        Any GUI change in 3.1.1 requires recertification for 508 compliance that is too late to consider. Marking for next release.

        Show
        scatari added a comment - Any GUI change in 3.1.1 requires recertification for 508 compliance that is too late to consider. Marking for next release.
        Hide
        Anissa Lam added a comment -

        Before it gets to GUI, the backend needs to be fixed first.
        No one has fixed the config bean code to allow setting of the value. I still see:

          /**
             * Sets the value of lazyInit property
             *
             * Specify is this listener should be started as part of server startup or not
             *
             * @param value true if the listener is to be started lazily; false otherwise
             */
            void String(boolean value);
        

        Until this is fixed, GUI can't do anything.
        When the above is fixed, then this can be assigned to GUI to add the UI.

        Show
        Anissa Lam added a comment - Before it gets to GUI, the backend needs to be fixed first. No one has fixed the config bean code to allow setting of the value. I still see: /** * Sets the value of lazyInit property * * Specify is this listener should be started as part of server startup or not * * @param value true if the listener is to be started lazily; false otherwise */ void String ( boolean value); Until this is fixed, GUI can't do anything. When the above is fixed, then this can be assigned to GUI to add the UI.
        Hide
        Tom Mueller added a comment -

        Targeting for 4.0.1 as bugs related to the orb do not need to be fixed for the RI/SDK.

        Show
        Tom Mueller added a comment - Targeting for 4.0.1 as bugs related to the orb do not need to be fixed for the RI/SDK.

          People

          • Assignee:
            Harshad Vilekar
            Reporter:
            Tom Mueller
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated: