glassfish
  1. glassfish
  2. GLASSFISH-16013

RestartRequired: changing http port does not trigger restart required message for a standalone instance

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 3.1_b43
    • Fix Version/s: 3.1.1_b05
    • Component/s: web_container
    • Labels:
      None
    • Environment:

      promoted build b43

      Description

      Steps to reproduce:

      1. Create a standalone instance and start it.
      2. Go to instance's configuration, System Properties page and click on Instance Values link for HTTP port.
      5. On the next page change the port to a new value, e.g. 28880, and save.
      6. Go to instance's page and notice it's still running and does not report requiring restart. CLI reports instance as running as well:

      1. a list-instances
        in1 running

      Attempting to access server on the newly specified port fails (28880), while it still responds on the old, default port 28080, hence restart is clearly required for the changes to take effect. The General tab for the instance lists new http port, even though the server is not listening on that port. This is misleading.

        Activity

        Hide
        Amy Roh added a comment -

        Why fix this issue in 3.1.1?

        
A partial fix (svn 45700) for issue 16013 went into the 3.1.1 branch because the 3.1.1 branch was created after the partial patch went in. Since the branch was created, the complete fix (svn 45965) was committed to the trunk to ignore unrelated events. The same should apply to the branch.

        Which is the targeted build of 3.1.1 for this fix?

        Build 5.

        Do regression tests exist for this issue?
        
No.

        Which tests should QA (re)run to verify the fix did not destabilize GlassFish?

        SQE webtier tests

        Show
        Amy Roh added a comment - Why fix this issue in 3.1.1? 
A partial fix (svn 45700) for issue 16013 went into the 3.1.1 branch because the 3.1.1 branch was created after the partial patch went in. Since the branch was created, the complete fix (svn 45965) was committed to the trunk to ignore unrelated events. The same should apply to the branch. Which is the targeted build of 3.1.1 for this fix?
 Build 5. Do regression tests exist for this issue? 
No. Which tests should QA (re)run to verify the fix did not destabilize GlassFish?
 SQE webtier tests
        Hide
        scatari added a comment -

        Approved.

        Show
        scatari added a comment - Approved.
        Hide
        lidiam added a comment -

        Tested on ogs-3.1.1-b11-07_04_2011-aix.zip and the issue is still present. Changed HTTP_LISTENER_PORT of standalone instance, in1, to 85 but there is no restart required message:

        /export/sqe/lidia/glassfish3/glassfish % asadmin list-instances
        in1 running
        cl1in1 running
        cl1in2 running
        Command list-instances executed successfully.

        However, the fix may have affected a different issue just logged: http://java.net/jira/browse/GLASSFISH-16976.

        Show
        lidiam added a comment - Tested on ogs-3.1.1-b11-07_04_2011-aix.zip and the issue is still present. Changed HTTP_LISTENER_PORT of standalone instance, in1, to 85 but there is no restart required message: /export/sqe/lidia/glassfish3/glassfish % asadmin list-instances in1 running cl1in1 running cl1in2 running Command list-instances executed successfully. However, the fix may have affected a different issue just logged: http://java.net/jira/browse/GLASSFISH-16976 .
        Hide
        lidiam added a comment -

        Attaching screenshot of changed http port.

        Show
        lidiam added a comment - Attaching screenshot of changed http port.
        Hide
        Amy Roh added a comment -

        There is no restart required message because restart is not required.

        After changing the instance's HTTP_LISTENER_PORT, accessing server on the newly specified port should succeed.

        Show
        Amy Roh added a comment - There is no restart required message because restart is not required. After changing the instance's HTTP_LISTENER_PORT, accessing server on the newly specified port should succeed.

          People

          • Assignee:
            Amy Roh
            Reporter:
            lidiam
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: