glassfish
  1. glassfish
  2. GLASSFISH-16131

creating-local-instance should gracefully deal with the trailing "/" for the installation directory.

    Details

      Description

      When creating a CONFIG node using Admin console, for the Installation Directory field, It suggest the following help text.

      The full path to the parent of the base installation directory of the GlassFish Server software on the host, for example, /export/glassfish3/.

      When I try to create local instance on remote host, I get an error because of the mismatch with trailing /.

      ./asadmin --host shepherd create-local-instance --cluster cluster1 --node node1 instance1^C
      [labrador]$ export AS_DEBUG=false
      [labrador]$ ./asadmin --host shepherd create-local-instance --cluster cluster1 --node node1 instance1
      remote failure: Attribute mismatch for node 'node1': the value for the 'installdir' attribute from the command (/home/oracle/glassfish3) does not match the value in the DAS configuration (/home/oracle/glassfish3/)
      Command create-local-instance failed.

        Activity

        Hide
        Jennifer Chou added a comment -

        ==[IDE]== May 1, 2011 11:07:29 AM Committing...
        commit -m "GLASSFISH-16206, GLASSFISH-16288, GLASSFISH-16313..." C:/gf/3.1.1/cluster/admin/src/main/java/com/sun/enterprise/v3/admin/cluster/ValidateNodeCommand.java
        Sending C:/gf/3.1.1/cluster/admin/src/main/java/com/sun/enterprise/v3/admin/cluster/ValidateNodeCommand.java
        Transmitting file data ...
        Committed revision 46568.
        Revision: 46568
        Author : jc129909
        Date : May 1, 2011 11:07:30 AM
        GLASSFISH-16206, GLASSFISH-16288, GLASSFISH-16313
        Fix _validate-node to be less strict and recognizing when the nodedir or installdir from the command and the config are equal, even if

        • one directory has a trailing '/'
        • one directory uses forward slash and the other uses backward slash (windows)
        • one directory is relative and the other is absolute

        Reviewed by: Joe Di Pol

        ==[IDE]== May 1, 2011 11:07:38 AM Committing... finished.

        ==[IDE]== May 1, 2011 11:09:10 AM Committing...
        commit -m "GLASSFISH-16206, GLASSFISH-16288, GLASSFISH-16313..." C:/gf/v3/cluster/admin/src/main/java/com/sun/enterprise/v3/admin/cluster/ValidateNodeCommand.java
        Sending C:/gf/v3/cluster/admin/src/main/java/com/sun/enterprise/v3/admin/cluster/ValidateNodeCommand.java
        Transmitting file data ...
        Committed revision 46569.
        Revision: 46569
        Author : jc129909
        Date : May 1, 2011 11:09:13 AM
        GLASSFISH-16206, GLASSFISH-16288, GLASSFISH-16313
        Fix _validate-node to be less strict and recognizing when the nodedir or installdir from the command and the config are equal, even if

        • one directory has a trailing '/'
        • one directory uses forward slash and the other uses backward slash (windows)
        • one directory is relative and the other is absolute

        Reviewed by: Joe Di Pol

        ==[IDE]== May 1, 2011 11:09:22 AM Committing... finished.

        Show
        Jennifer Chou added a comment - == [IDE] == May 1, 2011 11:07:29 AM Committing... commit -m " GLASSFISH-16206 , GLASSFISH-16288 , GLASSFISH-16313 ..." C:/gf/3.1.1/cluster/admin/src/main/java/com/sun/enterprise/v3/admin/cluster/ValidateNodeCommand.java Sending C:/gf/3.1.1/cluster/admin/src/main/java/com/sun/enterprise/v3/admin/cluster/ValidateNodeCommand.java Transmitting file data ... Committed revision 46568. Revision: 46568 Author : jc129909 Date : May 1, 2011 11:07:30 AM GLASSFISH-16206 , GLASSFISH-16288 , GLASSFISH-16313 Fix _validate-node to be less strict and recognizing when the nodedir or installdir from the command and the config are equal, even if one directory has a trailing '/' one directory uses forward slash and the other uses backward slash (windows) one directory is relative and the other is absolute Reviewed by: Joe Di Pol == [IDE] == May 1, 2011 11:07:38 AM Committing... finished. == [IDE] == May 1, 2011 11:09:10 AM Committing... commit -m " GLASSFISH-16206 , GLASSFISH-16288 , GLASSFISH-16313 ..." C:/gf/v3/cluster/admin/src/main/java/com/sun/enterprise/v3/admin/cluster/ValidateNodeCommand.java Sending C:/gf/v3/cluster/admin/src/main/java/com/sun/enterprise/v3/admin/cluster/ValidateNodeCommand.java Transmitting file data ... Committed revision 46569. Revision: 46569 Author : jc129909 Date : May 1, 2011 11:09:13 AM GLASSFISH-16206 , GLASSFISH-16288 , GLASSFISH-16313 Fix _validate-node to be less strict and recognizing when the nodedir or installdir from the command and the config are equal, even if one directory has a trailing '/' one directory uses forward slash and the other uses backward slash (windows) one directory is relative and the other is absolute Reviewed by: Joe Di Pol == [IDE] == May 1, 2011 11:09:22 AM Committing... finished.
        Hide
        scatari added a comment -

        Approved.

        Show
        scatari added a comment - Approved.

          People

          • Assignee:
            Jennifer Chou
            Reporter:
            ramapulavarthi
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: