glassfish
  1. glassfish
  2. GLASSFISH-16167

glassfish-naming module hard dependency on corba

    Details

    • Type: Improvement Improvement
    • Status: Open
    • Priority: Critical Critical
    • Resolution: Unresolved
    • Affects Version/s: 3.1
    • Fix Version/s: future release
    • Component/s: naming
    • Labels:
      None

      Description

      I was looking at the use-case to see if we can reduce GlassFish Web Profile to a Tomcat like distribution.

      I had the following packages (plus pkg/updatetool packages):

      NAME (PUBLISHER) VERSION STATE UFIX
      felix 3.0.8-0 installed ----
      glassfish-common 3.1-43 installed ----
      glassfish-grizzly 1.9.31-1 installed ----
      glassfish-grizzly-full 1.9.31-1 installed ----
      glassfish-hk2 3.1-43 installed ----
      glassfish-jcdi 3.1-43 installed ----
      glassfish-nucleus 3.1-43 installed ----
      glassfish-web 3.1-43 installed ----

      Packages I would have liked to remove:
      glassfish-corba-base 3.1.0-27 installed ----

      When I try to remove glassfish-corba-base package, I see dependency from glassfish-commons to glassfish-corba-base package.

      [nazrul-islams-macbook-pro:~/3.1-web/glassfish3/bin] nazrul% ./pkg uninstall glassfish-corba-base
      Creating Plan -pkg: Cannot remove 'pkg:/glassfish-corba-base@3.1.0,0-27:20110215T070738Z' due to the following packages that depend on it:
      pkg:/glassfish-common@3.1,0-43:20110215T074007Z

      For running servlet/JSP, I don't see the reason why we need glassfish-corba-base package. Dependency from glassfish-commons seems wrong. Please investigate how we can fix this runtime dependency.

      <ken>
      ...
      I'm not sure that glassfish-naming needs to depend on omgapi. glassfish-naming does depend on a number of org.omg
      APIs, but these should all be present in the JDK. JTS is the main reason that there is a dependency from the web distribution to glassfish-corba-omgapi.

      As far as web container dependencies on CORBA bundles I deliver to GlassFish, the following are required:

      • glassfish-corba-omgapi, which provides the enterprise versions of the org.omg.* APIs, and it needed for JTS.
      • glassfish-corba-internal-api, which provides the IIOP failover APIs needed in naming (and this one is just 7K)
      • glassfish-corba-codegen, which is needed for remote EJB wrapper class generation
        o dependency: glassfish-corba-orbgeneric, which provides some basic library code
        o dependency: glassfish-corba-asm, the ORB's renamed version of ASM (this could be elminated)

      glassfish-corba-orb (the largest ORB bundle), glassfish-corba-csiv2-idl, and glassfish-corba-newtimer (I think)
      are only used in the glassfish distribution.

      </ken>

        Activity

        Nazrul created issue -
        Hide
        Snjezana Sevo-Zenzerovic added a comment -

        Adjusting description and moving to naming subcategory. At this point packaging is behaving correctly. If this dependency needs to be removed on IPS level, glassfish-naming module needs to introduce optional dependency on corba modules. Snippet of relevant e-mail discussion:

        If glassfish-naming references orb classes only when EJBs are actually used, glassfish-naming needs to specify optional dependency on glassfish-corba-omgapi and glassfish-corba-internal-api (and this needs to happen on both maven level and OSGi import level). If you remove glassfish-corba-base content from the distribution right now, Felix runtime will report unsatisfied dependency as soon as glassfish-naming module gets activated, so that IPS dependency is valid and needs to be defined.

        Show
        Snjezana Sevo-Zenzerovic added a comment - Adjusting description and moving to naming subcategory. At this point packaging is behaving correctly. If this dependency needs to be removed on IPS level, glassfish-naming module needs to introduce optional dependency on corba modules. Snippet of relevant e-mail discussion: If glassfish-naming references orb classes only when EJBs are actually used, glassfish-naming needs to specify optional dependency on glassfish-corba-omgapi and glassfish-corba-internal-api (and this needs to happen on both maven level and OSGi import level). If you remove glassfish-corba-base content from the distribution right now, Felix runtime will report unsatisfied dependency as soon as glassfish-naming module gets activated, so that IPS dependency is valid and needs to be defined.
        Snjezana Sevo-Zenzerovic made changes -
        Field Original Value New Value
        Summary glassfish-corba-base dependency on glassfish-common glassfish-naming module hard dependency on corba
        Assignee Snjezana Sevo-Zenzerovic [ snjezana ] Cheng [ cf126330 ]
        Component/s naming [ 10636 ]
        Component/s packaging [ 10612 ]
        scatari made changes -
        Tags 3_1-next 3_1_1-scrubbed
        Hide
        scatari added a comment -

        One of the nice to have fixes, does not impose any impact on product functionality. Targeting to be considered for next release.

        Show
        scatari added a comment - One of the nice to have fixes, does not impose any impact on product functionality. Targeting to be considered for next release.
        Jill Sato made changes -
        Fix Version/s 4.0 [ 10970 ]
        Fix Version/s 3.2 [ 10969 ]
        Cheng Fang made changes -
        Tags 3_1-next 3_1_1-scrubbed 3_1-next 3_1_1-scrubbed 3_1_x-exclude
        michael.y.chen made changes -
        Assignee Cheng Fang [ cf126330 ] guojun.shan [ guojun.shan ]
        Fix Version/s 4.0.1 [ 16061 ]
        Fix Version/s 4.0 [ 10970 ]
        guojun.shan made changes -
        Issue Type Bug [ 1 ] Improvement [ 4 ]
        guojun.shan made changes -
        Fix Version/s future release [ 11148 ]
        Fix Version/s 4.0.1 [ 16061 ]

          People

          • Assignee:
            guojun.shan
            Reporter:
            Nazrul
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated: