Issue Details (XML | Word | Printable)

Key: GLASSFISH-16212
Type: Bug Bug
Status: Resolved Resolved
Resolution: Fixed
Priority: Critical Critical
Assignee: Hong Zhang
Reporter: hmalphettes
Votes: 0
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
glassfish

some dtds and schemas don't have the CDDL+GPL license header

Created: 15/Mar/11 12:23 AM   Updated: 07/Apr/11 03:24 PM   Resolved: 16/Mar/11 06:14 PM
Component/s: other
Affects Version/s: 3.1_b43
Fix Version/s: 3.1.1_b01

Time Tracking:
Not Specified

Tags: 3_1-next
Participants: hmalphettes and Hong Zhang


 Description  « Hide

I am working on packaging some j2ee bundles for eclipse orbit and noticed that some headers of the dtd and xsd files distributed with glassfish carry no license, a sun license or a proprietary license.

This is preventing us from adopting the java EE jars at eclipse.
We could re-use the apache ones but would favor the ones provided by gl;assfish as it is the reference implementation for java EE.

I apologize for this very unexciting and tedious request: is it possible to fix those headers or clarify under which license those files are distributed?

In case this helps here is the list. We don't need all of those at this point.

http://java.net/projects/glassfish/sources/svn/show/trunk/v3/deployment/schemas/src/main/resources/glassfish/lib/schemas?rev=45563
XMLSchema.dtd
no license

application-client_1_4.xsd
Sun's proprietary license 2002

application-client_5.xsd
Sun's proprietary license 2003

application-client_6.xsd
CDDL+GPL

application_1_4.xsd
Sun's proprietary license 2003

application_5.xsd
Sun's proprietary license 2003

application_6.xsd
CDDL+GPL

beans_1_0.xsd
JBoss copyright, ASL-20

datatypes.dtd
no license

ejb-jar_2_1.xsd
Sun's proprietary license 2003

ejb-jar_3_0.xsd
Sun's proprietary license 2003

ejb-jar_3_1.xsd
Sun's proprietary license 2003

j2ee_1_4.xsd
Sun's proprietary license 2003

j2ee_jaxrpc_mapping_1_1.xsd
Sun's proprietary license 2003

j2ee_web_services_1_1.xsd
Sun's proprietary license 2003

j2ee_web_services_client_1_1.xsd
Sun's proprietary license 2003

javaee_5.xsd
Sun's proprietary license 2003

javaee_6.xsd
CDDL+GPL

javaee_web_services_1_2.xsd
Sun's proprietary license 2003

javaee_web_services_1_3.xsd
CDDL+GPL

javaee_web_services_client_1_2.xsd
Sun's proprietary license 2003

javaee_web_services_client_1_3.xsd
CDDL+GPL

jax-rpc-ri-config.xsd
no license

jdbc-data-source.xsd
no license

jsp_2_0.xsd
CDDL+GPL

jsp_2_1.xsd
CDDL+GPL

jsp_2_2.xsd
CDDL+GPL

orm_1_0.xsd
no license

persistence_1_0.xsd
no license

web-app_*.xsd
web-common_3_0.xsd
web-facelettaglibrary_2_0.xsd
web-facesconfig_1_2.xsd
web-facesconfig_2_0.xsd
web-fragment_3_0.xsd
CDDL+GPL

web-jsptaglibrary_2_0.xsd
web-jsptaglibrary_2_1.xsd
Sun's proprietary license 2003

weblogic-application-client.xsd
weblogic-application.xsd
weblogic-connector.xsd
weblogic-ejb-jar.xsd
weblogic-javaee.xsd
weblogic-jms.xsd
weblogic-web-app.xsd
weblogic-webservices.xsd
no license

xml.xsd
no license

And for the dtd folder:
http://java.net/projects/glassfish/sources/svn/show/trunk/v3/deployment/dtds/src/main/resources/glassfish/lib/dtds?rev=45563
application-client_1_2.dtd
Sun's proprietary license 1999

application-client_1_3.dtd
Sun's proprietary license 2000

application_1_2.dtd
Sun's proprietary license 1999

application_1_3.dtd
Sun's proprietary license 2000

ejb-jar_1_1.dtd
Sun's proprietary license 1999

ejb-jar_2_0.dtd
Sun's proprietary license 2000

glassfish-*
CDDL+GPL

sun-application-*.dtd
sun-cmp-*.dtd
no license

sun-domain-1_0.dtd
CDDL
sun-domain-1_1.dtd
no license
sun-domain-1_2.dtd
sun-domain-1_3.dtd
CDDL

sun-ejb-jar_3_1-0.dtd
no license

sun-loadbalancer_*.dtd
CDDL

sun-server_1_0.dtd
no license

sun-web-app_*.dtd
no license

web-app_2_2.dtd
Sun's proprietary license 1999

web-app_2_3.dtd
Sun's proprietary license 2000

web-jsptaglibrary_1_1.dtd
Sun's proprietary license 1999

web-jsptaglibrary_1_2.dtd
no license



hmalphettes added a comment - 15/Mar/11 08:50 PM - edited

Here are the alternative sources with CDDL-GPL headers I have found for the xsds and dtds necessary for servlet-api:
http://java.sun.com/xml/ns/javaee/application-client_5.xsd
http://java.sun.com/xml/ns/j2ee/j2ee_1_4.xsd
http://java.sun.com/xml/ns/javaee/javaee_5.xsd
http://java.sun.com/xml/ns/javaee/javaee_web_services_1_2.xsd
http://java.sun.com/xml/ns/javaee/javaee_web_services_client_1_2.xsd

This should confirm that the corresponding files packaged with glassfish are not up to date.

I was able to find
j2ee_web_services_1_1.xsd and j2ee_web_services_client_1_1.xsd
in glassfish-v2 (appserver-common/schema) with CDDL+GPL

That is enough to complete servlet-api-3.0 with CDDL+GPL.


Hong Zhang added a comment - 16/Mar/11 06:51 AM

Thanks for catching this! We forgot to update the old schemas/dtds when the license header was updated. I am working on them right now and should be able to check in the changes into the v3 trunk workspace today.


Hong Zhang added a comment - 16/Mar/11 11:06 AM

I am having some discussions with Bill (EE spec lead) on what license header we should have and he was wondering if Eclipse were using these files before, and if so, what has changed recently to prompt this request? Thanks.


hmalphettes added a comment - 16/Mar/11 05:35 PM

Thanks for your attention.

Those older files were distributed with the servlet-api-2.5 bundle; in the javax.servlet.resources package and in the jsp-api-2.1 bundle in the javax.servlet.jsp.resources package.

  • servlet-api-2.5 was coming from apache and all files contain the ASl-2.0 header.
  • jsp-api-2.1 was coming from java.net/jsp. We had the same issue with missing license headers; reported it to Sun (kchung) at the time. Gave more work to the lawyers who review the pedigree of the files and were able to put that bundle together.

The jetty core developers want to stick to the reference implementation for the providers of servlet-api-3.0 and all other java-ee bundles.
So they got the servlet-api-3.0 and jsp-api-2.1 approved by the IP review at eclipse.
We found out once the review was approved that those jars don't package javax.servlet.resources and javax.servlet.jsp.resources

For the IP review the lawyers favor that all files are found in a single location.
In glassfish v2, all jars have the CDDL+GPL header.
In glassfish v3 which is still distributed as a whole as CDDL+GPL, some files have the wrong header.
On the http://java.sun.com/xml/ns urls all the files have the CDDL+GPL header.
In fact if we were to copy and override the files from v2 into v3 we would have the expected headers everywhere.

Strictly speaking we don't need at the moment all those files.
However it seems that glassfish license distribution is not consistent with the license of the files that it contains. And that is why I listed all the files.


Hong Zhang added a comment - 16/Mar/11 06:14 PM

Thanks for the clarifications. Yes, for some reason some of the files in the v3 workspace were out of synch from the ones posted on the java.sun.com. I have updated the license headers of the schemas/dtds that are owned by Sun/Oracle now. For the ones that we don't own, we should not change. You can get from them (W3C, JBoss etc) if needed. Please let me know if I missed anything in the schemas/dtds that owned by Sun/Oracle.
The changes were checked into v3 trunk:
https://svn.java.net/svn/glassfish~svn/trunk/v3


hmalphettes added a comment - 16/Mar/11 06:32 PM

Thanks a lot!
Sorry about listing the jboss and w3c files in there: it is clear that they should remain the way they were at jboss and w3c.