glassfish
  1. glassfish
  2. GLASSFISH-16512

Unable to restart glassfish bootstrapping bundle (glassfish.jar)

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 3.1
    • Fix Version/s: 3.1.1_b04 , 4.0
    • Component/s: OSGi
    • Labels:
      None

      Description

      GlassFishMainActivator.start() always calls GlassFishRuntime.boostrap() and hence is failing upon second or subsequent activation of glassfish.jar bundle.
      To reproduce:

      Start Felix
      start file:/space/ss141213/WS/gf/v3.1.1/publish/glassfish3/glassfish/modules/glassfish.jar
      stop 5
      start 5
      You shall the following exception:

      org.glassfish.embeddable.GlassFishException: Already bootstrapped
      at org.glassfish.embeddable.GlassFishRuntime._bootstrap(GlassFishRuntime.java:150)
      at org.glassfish.embeddable.GlassFishRuntime.bootstrap(GlassFishRuntime.java:106)
      at com.sun.enterprise.glassfish.bootstrap.GlassFishMainActivator.start(GlassFishMainActivator.java:75)
      at org.apache.felix.framework.util.SecureAction.startActivator(SecureAction.java:633)
      at org.apache.felix.framework.Felix.activateBundle(Felix.java:1822)

        Activity

        Hide
        Sanjeeb Sahoo added a comment -

        ss141213@Sahoo:/space/ss141213/WS/gf/v3$ svn commit -m "GLASSFISH-16512: Don't bootstrap during subsequent activation." core/bootstrap/
        Sending core/bootstrap/src/main/java/com/sun/enterprise/glassfish/bootstrap/GlassFishMainActivator.java
        Transmitting file data .
        Committed revision 46573.

        Show
        Sanjeeb Sahoo added a comment - ss141213@Sahoo:/space/ss141213/WS/gf/v3$ svn commit -m " GLASSFISH-16512 : Don't bootstrap during subsequent activation." core/bootstrap/ Sending core/bootstrap/src/main/java/com/sun/enterprise/glassfish/bootstrap/GlassFishMainActivator.java Transmitting file data . Committed revision 46573.
        Hide
        Sanjeeb Sahoo added a comment -

        Why fix this issue in 3.1.1?
        Additional use case support

        Which is the targeted build of 3.1.1 for this fix?
        Build 4 or 5 depending on when I get the approval.

        Do regression tests exist for this issue?
        Yes, our dev test suite.

        Which tests should QA (re)run to verify the fix did not destabilize GlassFish?
        Fix can't destabilize GlassFish, because it does not affect regular code path of GlassFish. This code path is only exercised when someone embeds GlassFish in an OSGi environment.

        Show
        Sanjeeb Sahoo added a comment - Why fix this issue in 3.1.1? Additional use case support Which is the targeted build of 3.1.1 for this fix? Build 4 or 5 depending on when I get the approval. Do regression tests exist for this issue? Yes, our dev test suite. Which tests should QA (re)run to verify the fix did not destabilize GlassFish? Fix can't destabilize GlassFish, because it does not affect regular code path of GlassFish. This code path is only exercised when someone embeds GlassFish in an OSGi environment.
        Hide
        scatari added a comment -

        Approved.

        Show
        scatari added a comment - Approved.
        Hide
        Sanjeeb Sahoo added a comment -

        3.1.1 Branch:
        -------------
        Sending core/bootstrap/src/main/java/com/sun/enterprise/glassfish/bootstrap/GlassFishMainActivator.java
        Transmitting file data .
        Committed revision 46642.

        Show
        Sanjeeb Sahoo added a comment - 3.1.1 Branch: ------------- Sending core/bootstrap/src/main/java/com/sun/enterprise/glassfish/bootstrap/GlassFishMainActivator.java Transmitting file data . Committed revision 46642.

          People

          • Assignee:
            Sanjeeb Sahoo
            Reporter:
            Sanjeeb Sahoo
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: