glassfish
  1. glassfish
  2. GLASSFISH-16849

Messages containing EJB jndi names are duplicated in key-value pairs

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 4.0
    • Fix Version/s: 4.0_b43
    • Component/s: logging
    • Labels:
      None

      Description

      EJB jndi names are duplicated as key-value pairs, in addition to the jndi names already contained in log messages, probably because : is used as delimiter?

      [#|2011-06-13T11:31:30.192-0400|INFO|glassfish3.2|javax.enterprise.system.container.ejb.com.sun.ejb.containers|_ThreadID=14;_ThreadName=Thread-1;java:global/test-ejb/TestBean;java:global/test-ejb/TestBean!test.TestIF;|EJB5181:Portable JNDI names for EJB TestBean: [java:global/test-ejb/TestBean, java:global/test-ejb/TestBean!test.TestIF]|#]

      [#|2011-06-13T11:31:30.192-0400|INFO|glassfish3.2|javax.enterprise.system.container.ejb.com.sun.ejb.containers|_ThreadID=14;_ThreadName=Thread-1;test.TestIF#test.TestIF;test.TestIF;|EJB5182:Glassfish-specific (Non-portable) JNDI names for EJB TestBean: test.TestIF#test.TestIF, test.TestIF|#]

      The ejb container code that logs the above message:

      _logger.log(Level.INFO, "ejb.portable_jndi_names",
      new Object[]

      {this.ejbDescriptor.getName(), publishedPortableGlobalJndiNames}

      );

      1. 1.gif
        15 kB
      2. 2.gif
        14 kB

        Activity

        Hide
        Cheng Fang added a comment -

        This issue is against 3.2 (the trunk), not 3.1.1.

        In 3.1.1, hard-coded strings were logged directly, so it came out correct.

        In 3.2, the message is taken from resource bundles, along with Object[] params. The second param is a Set. In the log entry in server.log, the content of the Set appears twice: one as part of the key-value pairs, after thread-id & thread-name, and the other as the regular log content.

        The essence of this issue is, the first occurence should not be there.

        ...|_ThreadID=12;_ThreadName=Thread-2;java:global/Sfulejb/SfulBean;java:global/Sfulejb/SfulBean!ejb30.Sful;|EJB5181:Portable JNDI names for EJB SfulBean: [java:global/Sfulejb/SfulBean, java:global/Sfulejb/SfulBean!ejb30.Sful]|#]

        Show
        Cheng Fang added a comment - This issue is against 3.2 (the trunk), not 3.1.1. In 3.1.1, hard-coded strings were logged directly, so it came out correct. In 3.2, the message is taken from resource bundles, along with Object[] params. The second param is a Set. In the log entry in server.log, the content of the Set appears twice: one as part of the key-value pairs, after thread-id & thread-name, and the other as the regular log content. The essence of this issue is, the first occurence should not be there. ...|_ThreadID=12;_ThreadName=Thread-2; java:global/Sfulejb/SfulBean;java:global/Sfulejb/SfulBean!ejb30.Sful; |EJB5181:Portable JNDI names for EJB SfulBean: [java:global/Sfulejb/SfulBean, java:global/Sfulejb/SfulBean!ejb30.Sful] |#]
        Hide
        naman_mehta added a comment -

        Fixed as per the v3 logging message format.

        http://wikis.sun.com/display/glassfish/GlassFishV3LoggingMessageFormat

        Name value pair is thread id and thread name.

        Show
        naman_mehta added a comment - Fixed as per the v3 logging message format. http://wikis.sun.com/display/glassfish/GlassFishV3LoggingMessageFormat Name value pair is thread id and thread name.
        Hide
        shreedhar_ganapathy added a comment -

        Naman, based on explanation above, I presume this fix need not be ported into 3.1.2 branch. If it needs to be ported, please reopen the issue and check in to 3.1.2 branch.

        Show
        shreedhar_ganapathy added a comment - Naman, based on explanation above, I presume this fix need not be ported into 3.1.2 branch. If it needs to be ported, please reopen the issue and check in to 3.1.2 branch.
        Hide
        naman_mehta added a comment -

        Not applicable for 3.1.2 so re-opening and closing the same.

        Show
        naman_mehta added a comment - Not applicable for 3.1.2 so re-opening and closing the same.
        Hide
        naman_mehta added a comment -

        Not applicable for 3.1.2 and alredady fixed on trunk.

        Show
        naman_mehta added a comment - Not applicable for 3.1.2 and alredady fixed on trunk.

          People

          • Assignee:
            naman_mehta
            Reporter:
            Cheng Fang
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: