Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 3.1.1_b08
    • Fix Version/s: 3.1.1_b10, 4.0_b08
    • Component/s: admin_gui
    • Labels:
      None
    • Environment:

      IE 7 on Windows XP, ogs-3.1.1-b08.zip

      Description

      I am unable to select a target for deployment in IE7 on Windows XP. I have a standalone instance and a cluster with 2 instances. When I select e.g. server as target and click Add it appears for a second in Selected Targets but then the page is reloaded and the selected target is back in Available Targets and a red asterisk is displayed next to application Type (see attached screenshot). It does not matter what target I pick.

      I can deploy fine in Firefox.

        Activity

        Hide
        Anissa Lam added a comment -

        ok, I am seeing the issue now, and I can confirm that this is indeed a regression introduced with the new woodstock jar. We try to fix the support for FF4, but introduce a regression on IE7. IE8, Chrome, Safari all works fine in both version.

        6/2 nightly build, 4.0.2.6 version, IE7 works fine, FF4 is broken.
        6/3 nightly build, 4.0.2.7 version, IE7 is broken, FF4 works fine.

        I will check with Jason to see what has been modified, and found a way to support both FF4 and IE7.

        Show
        Anissa Lam added a comment - ok, I am seeing the issue now, and I can confirm that this is indeed a regression introduced with the new woodstock jar. We try to fix the support for FF4, but introduce a regression on IE7. IE8, Chrome, Safari all works fine in both version. 6/2 nightly build, 4.0.2.6 version, IE7 works fine, FF4 is broken. 6/3 nightly build, 4.0.2.7 version, IE7 is broken, FF4 works fine. I will check with Jason to see what has been modified, and found a way to support both FF4 and IE7.
        Hide
        Anissa Lam added a comment - - edited

        IE7 and FF5 expects different value when setting a value in JS.
        We have to test which browser GUI is running in order to fix this bug.
        The fix is in Woodstock, we will have to put in the fix and integrate a new version of Woodstock to GF.

        Why fix this issue in 3.1.1?
        GUI is required to support both IE7 and FF5.

        Which is the targeted build of 3.1.1 for this fix?
        b10

        Do regression tests exist for this issue?
        will add one.

        Which tests should QA (re)run to verify the fix did not destabilize GlassFish?
        verify this bug, and also do testing on page where the Add Remove target component is showing.

        
        ~/Awork/Woodstock/402_Branch/Woodstock_402_Branch 48)  svn diff
        Index: themes/javascript/addRemove.js
        ===================================================================
        --- themes/javascript/addRemove.js	(revision 1593)
        +++ themes/javascript/addRemove.js	(working copy)
        @@ -525,14 +525,22 @@
                     ++ cntr;
                 }
         
        +	//need to test IE browser, refer go GLASSFISH-16903
                 cntr = 0;
        -
        -            while(cntr < newOptions.length) {
        -                this.selectedValues.add(newOptions[cntr], null);
        -//                this.selectedValues.children[this.selectedValues.children.length-1] = newOptions[cntr];
        -                ++cntr;
        -            }
        -
        +	var ua = navigator.userAgent;;
        +	var ie = false ;
        +	if (ua.indexOf("MSIE") > -1) {
        +	    ie=true;
        +	}
        +	while(cntr < newOptions.length) {
        +	    if (ie){
        +		this.selectedValues.add(newOptions[cntr], cntr);
        +	    }else{
        +		this.selectedValues.add(newOptions[cntr], null);
        +	    }
        +	    //this.selectedValues.children[this.selectedValues.children.length-1] = newOptions[cntr];
        +	    ++cntr;
        +	}
                 /*
                 if(this.selectedOptions.remove == null) {
                     // For Mozilla
        
        
        Show
        Anissa Lam added a comment - - edited IE7 and FF5 expects different value when setting a value in JS. We have to test which browser GUI is running in order to fix this bug. The fix is in Woodstock, we will have to put in the fix and integrate a new version of Woodstock to GF. Why fix this issue in 3.1.1? GUI is required to support both IE7 and FF5. Which is the targeted build of 3.1.1 for this fix? b10 Do regression tests exist for this issue? will add one. Which tests should QA (re)run to verify the fix did not destabilize GlassFish? verify this bug, and also do testing on page where the Add Remove target component is showing. ~/Awork/Woodstock/402_Branch/Woodstock_402_Branch 48) svn diff Index: themes/javascript/addRemove.js =================================================================== --- themes/javascript/addRemove.js (revision 1593) +++ themes/javascript/addRemove.js (working copy) @@ -525,14 +525,22 @@ ++ cntr; } + //need to test IE browser, refer go GLASSFISH-16903 cntr = 0; - - while (cntr < newOptions.length) { - this .selectedValues.add(newOptions[cntr], null ); - // this .selectedValues.children[ this .selectedValues.children.length-1] = newOptions[cntr]; - ++cntr; - } - + var ua = navigator.userAgent;; + var ie = false ; + if (ua.indexOf( "MSIE" ) > -1) { + ie= true ; + } + while (cntr < newOptions.length) { + if (ie){ + this .selectedValues.add(newOptions[cntr], cntr); + } else { + this .selectedValues.add(newOptions[cntr], null ); + } + // this .selectedValues.children[ this .selectedValues.children.length-1] = newOptions[cntr]; + ++cntr; + } /* if ( this .selectedOptions.remove == null ) { // For Mozilla
        Hide
        scatari added a comment -

        Approved for 3.1.1.

        Show
        scatari added a comment - Approved for 3.1.1.
        Hide
        Anissa Lam added a comment -

        New version of woodstock (4.0.2.8) which has the fix has been integrated to both trunk and 3.1.1 branch. marking the bug fixed.

        Show
        Anissa Lam added a comment - New version of woodstock (4.0.2.8) which has the fix has been integrated to both trunk and 3.1.1 branch. marking the bug fixed.
        Hide
        lidiam added a comment -

        Verified in IE7 and Firefox 5 on Windows XP with build ogs-3.1.1-b10-06_28_2011.zip.

        Show
        lidiam added a comment - Verified in IE7 and Firefox 5 on Windows XP with build ogs-3.1.1-b10-06_28_2011.zip.

          People

          • Assignee:
            Anissa Lam
            Reporter:
            lidiam
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: