glassfish
  1. glassfish
  2. GLASSFISH-17005

list-secure-admin-principals and list-secure-admin-internal-users both incorrectly prompt for a command operand

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 3.1.1, 3.1.2_b02, 4.0
    • Fix Version/s: 3.1.2_b02, 4.0
    • Component/s: admin
    • Labels:
      None

      Description

      The list-secure-admin-principals and list-secure-admin-internal-users commands both incorrectly prompt for a command operand. In contrast, they should not – these commands should list all of the respective elements.

      The problem is that I incorrectly specified a resolver for the two list commands in the CRUD notation.

      This is certainly not a show-stopper for 3.1.1 release. Relatively few users will create secure admin principals or secure admin internal users, so few will need to list them. As a workaround, users can use

      asadmin get secure-admin.secure-admin-principal.*

      or

      asadmin get secure-admin.secure-admin-internal-user.*

      In both cases, if no such items are defined then the user gets a message like this:

      remote failure: Dotted name path secure-admin.secure-admin-internal-user.* not found.
      Command get failed.

      which is ugly but it conveys correct information.

      I have marked this for review in case others feel strongly that this is in-your-face enough to warrant a fix at this point.

      Why fix this issue in 3.1.1?
      Although there is a workaround, the error is very in-your-face.

      Which is the targeted build of 3.1.1 for this fix?
      If approved, b11.

      Do regression tests exist for this issue?
      not yet

      Which tests should QA (re)run to verify the fix did not destabilize GlassFish?
      Tests involving enabling secure admin; the CRUD list functionality should be fully insulated from other code paths.

        Activity

        Tim Quinn created issue -
        Tim Quinn made changes -
        Field Original Value New Value
        Assignee Tom Mueller [ tmueller ] Tim Quinn [ tjquinn ]
        scatari made changes -
        Tags 3_1_1-review 3_1_1-approved 3_1_1-review
        scatari made changes -
        Tags 3_1_1-approved 3_1_1-review 3_1_1-approved
        scatari made changes -
        Tags 3_1_1-approved
        scatari made changes -
        Tags 3_1_1-review
        scatari made changes -
        Tags 3_1_1-review 3_1-next 3_1_1-scrubbed
        Tim Quinn made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Fix Version/s 3.2 [ 10969 ]
        Resolution Fixed [ 1 ]
        Tim Quinn made changes -
        Tags 3_1-next 3_1_1-scrubbed 3_1-next 3_1-next_release-notes 3_1_1-scrubbed
        Rebecca Parks made changes -
        Tags 3_1-next 3_1-next_release-notes 3_1_1-scrubbed 3_1-next 3_1-next_release-note-added 3_1-next_release-notes 3_1_1-scrubbed
        Tim Quinn made changes -
        Affects Version/s 3.1.2_b02 [ 15102 ]
        Affects Version/s 3.2 [ 10969 ]
        Affects Version/s 4.0 [ 10970 ]
        Tim Quinn made changes -
        Affects Version/s 3.1.2 [ 15100 ]
        Affects Version/s 3.2 [ 10969 ]
        Affects Version/s 3.1.1 [ 14740 ]
        Affects Version/s 3.1.2_b02 [ 15102 ]
        Tim Quinn made changes -
        Fix Version/s 3.1.2_b02 [ 15102 ]
        Tim Quinn made changes -
        Fix Version/s 4.0 [ 10970 ]
        Tim Quinn made changes -
        Affects Version/s 3.1.1 [ 14740 ]
        Affects Version/s 3.1.2_b02 [ 15102 ]
        Affects Version/s 3.2 [ 10969 ]
        Affects Version/s 4.0 [ 10970 ]
        Affects Version/s 3.1.2 [ 15100 ]
        Jill Sato made changes -
        Affects Version/s 4.0 [ 10970 ]
        Affects Version/s 3.2 [ 10969 ]
        Fix Version/s 3.2 [ 10969 ]

          People

          • Assignee:
            Tim Quinn
            Reporter:
            Tim Quinn
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: