glassfish
  1. glassfish
  2. GLASSFISH-17263

GUI should give appropriate access denied msg

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 3.1.1
    • Fix Version/s: 3.1.2_b13
    • Component/s: admin_gui
    • Labels:
      None

      Description

      secure admin needs to be enabled to allow user to use the Admin Console remotely.
      The enforcement is checked in since in r49138 trunk, r49145 branch.
      However, when access is denied, console always shows login error. Without differentiating whether it is login error or access denied.

      In AdminConsoleAuthModule,
      we should be able to distinguish the response by calling restResp.getResponseCode(). If it is 401, need to display a login page. If it is 403, let user know that remote access is denied.

        Activity

        Hide
        Tim Quinn added a comment -

        For what it's worth, the AdminAdapter (which handles asadmin requests) returns the top-level message in the ActionReport (which is in the HTTP response payload) as "Remote configuration is currently disabled"

        Maybe the console adapter can do the same? I'm not sure what the console does with the ActionReport message, if anything.

        Just a thought.

        Ideally, the adapter that's providing the response status will set a useful message, rather than the client having to assume that 403 always means that remote config is turned off. That might be valid today, but that could change.

        Show
        Tim Quinn added a comment - For what it's worth, the AdminAdapter (which handles asadmin requests) returns the top-level message in the ActionReport (which is in the HTTP response payload) as "Remote configuration is currently disabled" Maybe the console adapter can do the same? I'm not sure what the console does with the ActionReport message, if anything. Just a thought. Ideally, the adapter that's providing the response status will set a useful message, rather than the client having to assume that 403 always means that remote config is turned off. That might be valid today, but that could change.
        Hide
        Jason Lee added a comment -

        Fix committed to branch (r51210) and trunk (r51211).

        Show
        Jason Lee added a comment - Fix committed to branch (r51210) and trunk (r51211).
        Hide
        shaline added a comment -

        Verified in GF 3.1.2 b18.

        Show
        shaline added a comment - Verified in GF 3.1.2 b18.

          People

          • Assignee:
            Jason Lee
            Reporter:
            Anissa Lam
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: