Issue Details (XML | Word | Printable)

Key: GLASSFISH-17366
Type: Improvement Improvement
Status: Resolved Resolved
Resolution: Fixed
Priority: Major Major
Assignee: jjsnyder83
Reporter: thomas.giger
Votes: 1
Watchers: 1
Operations

If you were logged in you would be able to see more operations.
glassfish

Log lines consume a lot of time.

Created: 28/Sep/11 10:21 AM   Updated: 22/Oct/12 08:55 PM   Resolved: 22/Oct/12 08:55 PM
Component/s: cdi
Affects Version/s: 3.1.1
Fix Version/s: 4.0_b64_EE7MS2

Time Tracking:
Not Specified

Environment:

Windows XP


Tags: weld-integration
Participants: jjsnyder83, Sivakumar Thyagarajan, thomas.giger and Tom Mueller


 Description  « Hide

We have an application that consists of a couple of CDI bean modules. I noticed that the time to redeploy could be reduced singnificantly by removing some trace lines in the weld-integration.jar (in my case from 54 to 19 seconds)

The lines are:
BeanDeploymentArchiveImpl.java

  • getBeanClasses()
    • logger.log(FINER, "set TCL for " + this.id + " to " + this.moduleClassLoaderForBDA);

and
DeplyomentAcrhiveImpl.java

  • getBeanDeploymentArchives(boolean printDebug) {
    • if (printDebug) logger.log(FINE, "DeploymentImpl::getBDAs. " +
      "Returning \n" + beanDeploymentArchives);

It seemed strange to me. May be you can have a look into this.



Sivakumar Thyagarajan added a comment - 15/Oct/12 01:24 PM

Will investigate and fix this in 4.0. Exact build TBD.


Sivakumar Thyagarajan made changes - 15/Oct/12 01:24 PM
Field Original Value New Value
Fix Version/s 4.0 [ 10970 ]
Tom Mueller added a comment - 17/Oct/12 08:19 PM

Marking the fix version field as "future-release". This is based on an evaluation by John, Michael, and Tom WRT to the PRD for the Java EE 7 RI/SDK. This issues was deemed to not be a P1 for that release. If this is in error or there are other reasons why this RFE should be targeted for the Java EE 7 RI/SDK release, then change the fix version field back to an appropriate build.


Tom Mueller made changes - 17/Oct/12 08:19 PM
Tags weld-integration ee7ri_cleanup_deferred
Fix Version/s future release [ 11148 ]
Fix Version/s 4.0 [ 10970 ]
jjsnyder83 made changes - 19/Oct/12 01:39 PM
Fix Version/s 4.0 [ 10970 ]
Fix Version/s future release [ 11148 ]
michael.y.chen made changes - 19/Oct/12 04:35 PM
Tags ee7ri_cleanup_deferred
michael.y.chen made changes - 19/Oct/12 04:36 PM
Tags weld-integration
jjsnyder83 made changes - 19/Oct/12 04:59 PM
Assignee Sivakumar Thyagarajan [ sivakumart ] jjsnyder83 [ jjsnyder83 ]
Fix Version/s 4.0_b64_EE7MS2 [ 15653 ]
Fix Version/s 4.0 [ 10970 ]
jjsnyder83 added a comment - 22/Oct/12 08:55 PM

Added checks on the log level so Strings aren't built unnecessarily.

Committed revision 56679


jjsnyder83 made changes - 22/Oct/12 08:55 PM
Status Open [ 1 ] Resolved [ 5 ]
Resolution Fixed [ 1 ]