glassfish
  1. glassfish
  2. GLASSFISH-17447

install-node-ssh should report error not success in this case

    Details

      Description

      Say you have an old version of GlassFish installed on a remote host. You want to upgrade the bits to the latest version.

      You run "asadmin install-node-ssh ...."

      Result:
      Nothing is done but it reports success.

      Why? There is a test:

      if (checkIfAlreadyInstalled(host, sshInstallDir))
      continue;

      – it checks if "asadmin version" runs successfully. If so it silently returns without doing anything. No warning either. It is officially a success.

      Recommended Fix:

      Report an ERROR – the node is already installed. Tell user to run uninstall-node first.

        Activity

        Hide
        Yamini K B added a comment -

        3.1.2 - r50558
        4.0 - r50559

        Show
        Yamini K B added a comment - 3.1.2 - r50558 4.0 - r50559

          People

          • Assignee:
            Yamini K B
            Reporter:
            Byron Nevins
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: