glassfish
  1. glassfish
  2. GLASSFISH-17539

Timeout field under Protocol -> Http tab should allow negative number.

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 3.1.1
    • Fix Version/s: 3.1.2_dev, 3.1.2, 4.0
    • Component/s: admin_gui
    • Labels:
      None

      Description

      request-timeout-seconds attribute for <http> allows -1 , but GUI is enforcing that to be a positive number in the client validation.
      This should be fixed so user can input -1 which means disabling it.

      In the forum discussion:
      http://forums.java.net/node/855551?force=732

      @laptop:~/apps/glassfish/0000/glassfish3/bin$ ./asadmin set
      configs.config.server-config.network-config.protocols.protocol.http-listener-1.http.request-timeout-seconds=-1
      configs.config.server-config.network-config.protocols.protocol.http-listener-1.http.request-timeout-seconds=-1
      Command set executed successfully.

        Issue Links

          Activity

          Hide
          Anissa Lam added a comment -

          While looking into this, sounds like the following fields also allows -1 to indicate disabling it.

          request-timeout-seconds
          timeout-seconds
          connection-upload-timeout-millis

          Will request oleksiys to confirm and will change the validation for those fields also.

          Show
          Anissa Lam added a comment - While looking into this, sounds like the following fields also allows -1 to indicate disabling it. request-timeout-seconds timeout-seconds connection-upload-timeout-millis Will request oleksiys to confirm and will change the validation for those fields also.
          Hide
          oleksiys added a comment -

          you're right Anissa.
          -1 should work similar way for other timeout attributes.

          Show
          oleksiys added a comment - you're right Anissa. -1 should work similar way for other timeout attributes.
          Hide
          Anissa Lam added a comment -

          Fixed in both trunk (4.0) and 3.1.2. Should be available in 3.1.2 promoted build 08.

          Trunk:
          50594 31.10.2011 18:29:58, by anilam
          GLASSFISH-17539. Allows 1 for the following timeout attributes: request-timeout-seconds, timeout-seconds and connection-upload-timeout-millis in protocol>http tab.

          3.1.2 branch:
          50592 31.10.2011 18:20:06, by anilam
          GLASSFISH-17539. Allows 1 for the following timeout attributes: request-timeout-seconds, timeout-seconds and connection-upload-timeout-millis in protocol>http tab.
          M /branches/3.1.2/admingui/common/src/main/resources/js/adminjsf.js
          M /branches/3.1.2/admingui/web/src/main/resources/grizzly/httpAttr.inc
          M /branches/3.1.2/admingui/web/src/main/resources/org/glassfish/web/admingui/Strings.properties

          mark resolved.

          Show
          Anissa Lam added a comment - Fixed in both trunk (4.0) and 3.1.2. Should be available in 3.1.2 promoted build 08. Trunk: 50594 31.10.2011 18:29:58, by anilam GLASSFISH-17539 . Allows 1 for the following timeout attributes: request-timeout-seconds, timeout-seconds and connection-upload-timeout-millis in protocol >http tab. 3.1.2 branch: 50592 31.10.2011 18:20:06, by anilam GLASSFISH-17539 . Allows 1 for the following timeout attributes: request-timeout-seconds, timeout-seconds and connection-upload-timeout-millis in protocol >http tab. M /branches/3.1.2/admingui/common/src/main/resources/js/adminjsf.js M /branches/3.1.2/admingui/web/src/main/resources/grizzly/httpAttr.inc M /branches/3.1.2/admingui/web/src/main/resources/org/glassfish/web/admingui/Strings.properties mark resolved.
          Hide
          tmpsa added a comment -

          Glad to be of help to finding this issue.

          As I said in the forum, please also update the built-in help (both on the form page and the help page); -1 is a magical value with special meaning.

          I also suggested that there should be a NEW SEPARATE timeout for uploads. Perhaps downloads as well... These can run for quite some time; for example when transferring a huge file. As long as there's reasonable traffic (i.e. above a certain number of bytes per seconds during the last y seconds) the request should not time out, no matter how long it has been running.

          In other words, the ordinary Request Timeout should not apply at all to such operations, only when no traffic has occured.

          Perhaps this should be made into a different issue?

          Show
          tmpsa added a comment - Glad to be of help to finding this issue. As I said in the forum, please also update the built-in help (both on the form page and the help page); -1 is a magical value with special meaning. I also suggested that there should be a NEW SEPARATE timeout for uploads. Perhaps downloads as well... These can run for quite some time; for example when transferring a huge file. As long as there's reasonable traffic (i.e. above a certain number of bytes per seconds during the last y seconds) the request should not time out, no matter how long it has been running. In other words, the ordinary Request Timeout should not apply at all to such operations, only when no traffic has occured. Perhaps this should be made into a different issue?
          Hide
          Anissa Lam added a comment -

          Yes, the inline help for those 3 attributes has been modified, spell out that -1 means disabling it. Thats part of the checkin for this bug.

          There is also a doc bug filed for enhancement for http://java.net/jira/browse/GLASSFISH-17480

          As for adding another 'NEW SEPARATE timeout for uploads' attribute, please find another issues against grizzly. Once the backend has added that, we will add that to the console screen.
          thanks.

          Show
          Anissa Lam added a comment - Yes, the inline help for those 3 attributes has been modified, spell out that -1 means disabling it. Thats part of the checkin for this bug. There is also a doc bug filed for enhancement for http://java.net/jira/browse/GLASSFISH-17480 As for adding another 'NEW SEPARATE timeout for uploads' attribute, please find another issues against grizzly. Once the backend has added that, we will add that to the console screen. thanks.
          Hide
          tmpsa added a comment -

          Anissa, I have now filed a new issue against Grizzly, as you suggest. See http://java.net/jira/browse/GRIZZLY-1121 .

          Show
          tmpsa added a comment - Anissa, I have now filed a new issue against Grizzly, as you suggest. See http://java.net/jira/browse/GRIZZLY-1121 .

            People

            • Assignee:
              Anissa Lam
              Reporter:
              Anissa Lam
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: